Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo DeletAdd in ADHybridHealthService #4576

Closed
nschonni opened this issue Nov 27, 2018 · 2 comments
Closed

Typo DeletAdd in ADHybridHealthService #4576

nschonni opened this issue Nov 27, 2018 · 2 comments
Assignees

Comments

@nschonni
Copy link
Contributor

Should be "DeleteAdd" in the enum values here

@amarzavery
Copy link
Contributor

@gamitra This change was made by you in this PR over here.

Looks like the enum value should be DeleteAdd and not DeletAdd. Can you please verify what is the actual value expected by the service on the wire? Otherwise it may cause unnecessary errors to our customers using the SDK.

binilkk added a commit to binilkk/azure-rest-api-specs that referenced this issue Dec 11, 2018
Issue Azure#1 : Azure#4576 (comment)

Typo in the DeltaOperationType Enum.

Issue Azure#2 : Azure#4844 (comment)

GlobalAdmins list is marked as an object, while it's an array.
AutorestCI added a commit to Azure/azure-sdk-for-python that referenced this issue Dec 11, 2018
Fixes for:

Issue #1 : Azure/azure-rest-api-specs#4576 (comment)

Typo in the DeltaOperationType Enum.

Issue #2 : Azure/azure-rest-api-specs#4844 (comment)

GlobalAdmins list is marked as an object, while it's an array.
AutorestCI added a commit to Azure/azure-sdk-for-go that referenced this issue Dec 11, 2018
Fixes for:

Issue #1 : Azure/azure-rest-api-specs#4576 (comment)

Typo in the DeltaOperationType Enum.

Issue #2 : Azure/azure-rest-api-specs#4844 (comment)

GlobalAdmins list is marked as an object, while it's an array.
AutorestCI added a commit to Azure/azure-sdk-for-python that referenced this issue Dec 14, 2018
Fixes for:

Issue #1 : Azure/azure-rest-api-specs#4576 (comment)

Typo in the DeltaOperationType Enum.

Issue #2 : Azure/azure-rest-api-specs#4844 (comment)

GlobalAdmins list is marked as an object, while it's an array.
praries880 pushed a commit that referenced this issue Dec 14, 2018
Issue #1 : #4576 (comment)

Typo in the DeltaOperationType Enum.

Issue #2 : #4844 (comment)

GlobalAdmins list is marked as an object, while it's an array.
AutorestCI added a commit to Azure/azure-sdk-for-python that referenced this issue Dec 14, 2018
…view request for Microsoft.ADHybridHealthService to add version 2014-01-01 (#4040)

* Generated from 5269a33bc4e48e336b7eacdba01c999953f42013

Fixes for:

Issue #1 : Azure/azure-rest-api-specs#4576 (comment)

Typo in the DeltaOperationType Enum.

Issue #2 : Azure/azure-rest-api-specs#4844 (comment)

GlobalAdmins list is marked as an object, while it's an array.

* Generated from 5269a33bc4e48e336b7eacdba01c999953f42013

Fixes for:

Issue #1 : Azure/azure-rest-api-specs#4576 (comment)

Typo in the DeltaOperationType Enum.

Issue #2 : Azure/azure-rest-api-specs#4844 (comment)

GlobalAdmins list is marked as an object, while it's an array.
@nschonni
Copy link
Contributor Author

Fixed by #4880

TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this issue Feb 6, 2019
Issue #1 : Azure#4576 (comment)

Typo in the DeltaOperationType Enum.

Issue #2 : Azure#4844 (comment)

GlobalAdmins list is marked as an object, while it's an array.
jhendrixMSFT pushed a commit that referenced this issue Mar 2, 2019
…01 binilkk (#5042)

* Fixes for:

Issue #1 : #4576 (comment)

Typo in the DeltaOperationType Enum.

Issue #2 : #4844 (comment)

GlobalAdmins list is marked as an object, while it's an array.

* Updated the Specification as example for Risky IP Download report.

* Added the Result details

* Fixed review comments, changed the URI scheme as well as changed get/post methods

* Addressing Review Feedback, changing POST call of blobUri -> generateBlobUri
sergey-shandar added a commit that referenced this issue Mar 15, 2019
* Add mixedreality 2019-02-28 API version to Go SDK (#5271)

* Remove ARM gateway Node.js configuration (#5283)

* Updates to Scheduled Query Rule swagger (#5175)

- making aznsaction paramter optional
  - removing hidden-link value from tags
pu

* Fix JavaScript configuration for ARM Private DNS SDK (#5284)

* Fix JavaScript configuration for ARM Private DNS SDK

* Add quotes

* Add private preview API for Azure Image Builder (#5055)

* Add private preview API for Azure Image Builder

* Review comments

 - Added list-by-resource-group and list-by-subscription
 - Added default error response
 - Removed explicit operation url (implied by async contract)
 - Adjusted 'delete' response codes to match expectations
 - Allow patch for tags
 - Added provider operations API

* Review comment: use "nextLink" for paging

* Adding readme files for SDK generation

* PR: rename 'tags' -> 'artifactTags' for distributor

* Add examples, fix minor issues in swagger

* Updating Blueprint spec to include resource group tags (#5263)

* Add Showback model (#5217)

* Add Showback model

* fix ShowbackRule.json example

* remove "," from line 1709

* Add Put Rule

* Fix Scope

* Update json with pull request changes

* change recurring to enum

* chore: Graphservice -> GraphService (#5098)

* Enable SSL on custom domains using users certificate or CDN managed certificate (#5276)

* Translator Text API V3 (#5230)

* Translator Text API V3

* Fix path and override

* Fix a typo and few other improvements in descriptions.

* Remove after_scripts

* Update readme.md

* Update readme.md

* Update MariaDB api version (#5280)

* Adding Swagger and examples for VirtualClusters operation group (#5248)

* Adding Swagger file for VirtualClusters operation group, together with examples.

* Fixing api version, typos and location in examples.

* Adding virtualclusters.json to readme.md

* Security - Updating API versions of alerts and pricing types (#5269)

* Security - Updating api versions of alerts and pricing types

* fix codegen paths for Go SDK

* typo: asscociation -> association (#5252)

* Fix lintdiff issue (#5299)

* fix Go SDK package path for mariadb stable release (#5298)

* changes to improve documentation of endpoint health statuses for routing (#5290)

* add netapp to Go SDK (#5308)

* Update MariaDB default API version to 2018-06-01 (#5302)

* new application insignts api version for unified schema in action (#5292)

* Added Azure App Configuration event data schema. (#5309)

* Added Azure App Configuration event data schema.

* Added a few missing pieces.

* Prefixed event names with our service prefix 'AppConfiguration'.
* Added Microsoft.AppConfiguration to the event grid data-plane readme.

* Updated api-version path to '2018-01-01' from '2018-02-01'.

* Apim Cache resource + DELETE long running + refactor to align with tooling. (#5260)

* api import and service delete long running operation

* Bring your own Cache

align with spec generated from tooling

user and notification align

Refactor products and apis

* align with spec generated from tooling

user and notification align

Refactor products and apis

validating examples

validating examples

move all parameters to apimanagement.json

Fix reference issue with tagcontract and example DeleteCache.

* switch to plural example file names for LIST

* bring back updatehostname and updatecertificate

* Dev adhybridhealthservice microsoft.ad hybrid health service 2014 01 01 binilkk (#5042)

* Fixes for:

Issue #1 : #4576 (comment)

Typo in the DeltaOperationType Enum.

Issue #2 : #4844 (comment)

GlobalAdmins list is marked as an object, while it's an array.

* Updated the Specification as example for Risky IP Download report.

* Added the Result details

* Fixed review comments, changed the URI scheme as well as changed get/post methods

* Addressing Review Feedback, changing POST call of blobUri -> generateBlobUri

* Update UserAssignedIdentities spec in Web (#5288)

* Update UserAssignedIdentities spec in Web

Microsoft.Web recently added support for UserAssigned managed service identities (in preview), but the swagger spec is incorrect for the identity payload as it follows the old construct of sending an array of identityIds as opposed to the updated spec which instead sends a dictionary object called userAssignedIdentities. 

Spec + history outlined here:
http://sharepoint/sites/AzureUX/Sparta/_layouts/15/WopiFrame2.aspx?sourcedoc=%7b633632B4-02E4-4DE2-92A9-EDCAF9BE73D4%7d&file=ARM%2BMSI.docx&action=default 

Our swagger contains identityids[] because of previous work to future support UserAssigned identities, but never released the feature in that state, rather we opted to wait for the new spec to be supported and then integrated with that on our end. 

Our MSI implementation reflects Microsoft.Compute's spec for user assigned.

https://github.com/Azure/azure-rest-api-specs/blob/78e1feab142c605839aa3cec23442ca26b8ef04d/specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/compute.json

* fix linterdiff tool

* Add private dns module name for java codegen (#5312)

* Update Swagger Files For ManagedInstanceAdministrator (#5095)

* Update Swagger Files For ManagedInstanceAdministrator

* Fix for double wording

* Comments resolved

* Bringing consistency between to "ResourceGroup" definition (#5256)

* Bringing consistency between this "ResourceGroup" definition and the one in Common.

* Fixing broken references

* reverted security python readme to pre multi api (#5301)

* [Azure Search] Add Search API to data plane Swagger spec (#5315)

* [Azure Search] Updating some Swagger descriptions to be more doc-friendly

Sometimes we over-describe things, especially "comma-separated lists" in
query string parameters. These are modeled as arrays in Swagger, which are
already understood to be comma-separated lists. They are modeled as
collections in generated code, so they are decidedly not comma-separated
lists in that context. So removing this phrase is a win-win.

* [Azure Search] Adding some missing readOnly attributes

* Adding Search API to the Azure Search data plane spec

* [Azure Search] Use regexes to generate code for server-side paging

This change introduces some very hacky regexes to customize the generated
code for server-side paging of the GET and POST Search APIs. They work by
splitting the generated SearchGet and SearchPost operations in two, so that
the portion that operates on a URL and request body can be reused.

This workaround is necessary because AutoRest lacks flexibility around
paging. The current x-ms-pageable implementation doesn't work for us because
it doesn't model additional top-level response properties or continuation
POST requests (only nextLink/GET).

The only other alternative to this approach besides custom code would have
been to try to parse the nextLink URL query string to reconstitute parameters
to pass to the generated SearchGet and SearchPost operations. This is
unacceptable for Azure Search, since it would exclude custom parameters that
can't be modeled in Swagger, like personalization IDs for custom ranking.
Neither AutoRest nor apparently Open API support modeling arbitrary query
string parameters.

Ideally we'll find a pattern common to other data plane APIs so we don't have
to hack this with regexes for every target language, but it's good enough for
now.

* [Azure Search] Rename some client properties for consistency

* [Azure Search] Make AutocompleteMode non-nullable

* [Hub Generated] Review request for Microsoft.Web to add version 2018-02-01 (#5137)

* Add Hosting Environment network dependencies

* Address PR description feedback

* Add Network Dependencies examples

* Fix casing

* Remove incorrect pagination from examples.

* Add missing MarketplaceOrdering operations to swagger (#5279)

* Add missing MarketplaceOrdering operations to swagger

* Add examples

* Add example files

* Apply suggestions from code review

Clarify operation descriptions

Co-Authored-By: zachraMSFT <zachra@microsoft.com>

* Fix Hosting Environment Network Dependencies pagination (#5320)

* Add regex validation for ManagedClusterAgentPoolProfile.name (#5324)

* Adding instance pools swagger (#5225)

* Initializing instance pools swagger and examples - no usages / managed instances get by instance pool

* updates to use common resource and sku definitions

* Update instance pool swagger with typo fixes

* Updates to instance pool swagger and reverting readme.md to exclude instance pools reference

* Fix whitespace diff

* Making a whitespace change to re-try linter validation

* Updates to add list instances pools by subscription and update license type param to use enum which is limited to LicenseIncluded and BasePrice

* Enhanced A2ARecoveryPointDetails with "disks" (#5307)

* [DiskRP] Adding swagger spec for 09-30-2018 (#5232)

* commit for the older swagger version to make the PR easier to look at

* Adding the DiskRP 09-30-2018 swagger spec. This includes support for hyperVGeneration, encryptionSettingCollections, diskState, Upload Disks, and Write access

* adding the updated readme

* updating the examples to use 09-30-2018

* removing extraneous examples

* adding a description for the EncryptionSettingsElementand fixing linter issues

* [Computer Vision] Add read to CV OCR API. (#5314)

* Add read to OCR API.

* Add description to OCR related JSON properties.

* Mark asyncBatchAnalyze as long running operation.

* Update page property.

* Revert "Mark asyncBatchAnalyze as long running operation."

This reverts commit 51742b3.

* added links to limits for application gateway (#5265)

* typo: Winodws -> Windows (#5321)

* MultiApi EventHub (#5331)

* try 2 bootstrapping swagger to .net sdk tools (#5334)

* bootstrapping swagger to .net sdk tools

* deleting nuget.exe binary. Updating configs to locally restore pacakges. Adding the directory that will be used in restoring packages locally to .gitignore

* changing directory

* updating feed location to a readonly directory

* Azure Search: Resource Manager: Support 'None' Identity type (#5319)

* Azure Search: Resource Manager: Support 'None' Identity type

* Azure Search: Resource Manager: Adding serice identity creation\removal examples

* [ADLA] - Catalog - Add stream path to USqlTableFragment (#5329)

* [Hub Generated] Review request for Microsoft.Consumption to add version 2019-01-01 (#5311)

* Add GTM scopes for budgets API

* Removed the extra period at the end of the statement

* fixing stos.proj parameter (#5338)

* change flag name from useUnifiedSchema into useCommonAlertSchema per UX requirement (#5323)

* Enhanced A2A protection input and response details (#5330)

Enhanced A2AEnableProtectionInput & A2AReplicationDetails objects with recoveryAvailabilityZone, recoveryAzureNetworkId, and recoverySubnetName.

* [Hub Generated] Review request for Microsoft.ContainerService to add version 2019-02-01 (#5350)

* Adds base for updating Microsoft.ContainerService from version preview/2018-08-01-preview to version 2019-02-01

* Updates readme

* Updates API version in new specs and examples

* [AKS] add availabilityZones to agent pool profile (#5120)

* including orchestratorVersion and provisioning state for agent pool (#5156)

* including orchestratorVersion and provisioning state for agent pool

* fixing the readme.go.md

* including enablePodSecurityPoliy properties for managedcluster and updating examples

* fixing the example for enablePodSecurityPolicy

* including apiServerAuthorizedIPRanges (#5286)

* including apiServerAuthorizedIPRanges

* support azure network policy

* mark the new features as PREVIEW in description  (#5310)

* mark the new features as PREVIEW

* mark vmss as required for az

* Azure Event Grid: Add 2019-02-01-preview tags for Ruby and Go readme files (#5349)

* Add 2019-02-01-preview tags for Ruby and Go readme files

* fix wrong preview subdirectory

* Update some descriptions. (#5305)

* update description. (#5335)

* Added VNet API (#5351)

* EventHub : corrected typo  (#5360)

* corrected typo in uri

* removed unused parameters

* Add annotations property to trigger (#5332)

* EventHub: Revert the NetworkRuleSet  (#5363)

* Revert "EventHub : corrected typo  (#5360)"

This reverts commit 1495122.

* Revert "Added VNet API (#5351)"

This reverts commit f2ab4a8.

* Remove the AzureDataLakeStoreCosmosStructuredStreamDataset since it's internal only (#5277)

* Removing SDK generation from Travis-CI (#5367)

* Microsoft.DataBoxEdge RP: Corrected comments of trigger and extendedinfo APIs, corrected examples (#5322)

* Corrected comments of trigger and extendedinfo APIs, corrected examples

* Microsoft.DataBoxEdge RP: Have better examples

* Corrected parameter description in order API

* oad => @azure/oad (#5362)

* oad => @azure/oad

* oad => @azure/oad

* SRP Swagger changes for 2018-11-01 (#5300)

* SRP Swagger changes for 2018-11-01

* Address CR comments

* Restrict ManagementPolicyRule -> type property to have only values from defined enum

* Make ManagementPolicySchema/version an enum string

* Remove 'version' property from ManagementPolicy schema

* Added List Policies API to SecurityAlerts (#5070)

* Added SecurityAlert List API

Added List api to:
Manged Server + Managed Database
Logical Server + Logical Database

* FIxed a description

this property is for databases+servers

* Added missing Database exmaples

Added missing examples for database security alert

* Added missing description change

For Server Security Alerts

* Revert "FIxed a description"

This reverts commit e01a332.

* Revert "Added missing description change"

This reverts commit 17aeab7.

* Update DatabaseSecurityAlertListByDatabase.json

* fixed examples

* Update DatabaseSecurityAlertCreateMin.json

Deleted wild comma

* Update readme.md

* Minor fixes

Changed tabs to spaces.
Added location for servers exmaples.

* Removed location

removed the location property from examples

* graph: improve API coverage on application & service principal  (#5181)

* [graphrbac]: fix bugs in permission grant apis

* fix paging

* add missing property

* remove pageable

* author pagable in the right way

* breaking changes over a wrong spec

* remove additionalProperties which causes wrong code-gen

* add suppressions

* use code to surpress

* address review feedabck

* moev ahead with the established pattern anyway

* address review feedbacks

* clean up all

* update operation id

* add one more property per CLI user's ask

* Add insights 2019-03-01 package to Go SDK (#5373)

* Add insights 2019-03-01 package to Go SDK

* move global settings before packages

* fix package tag for new API version (#5378)

* Remove GZRS and RAGZRS sku from SRP 2018-11-01 because feature slipped. (#5377)

* typo: upto -> up to (#5376)

* typo: graphrbac/data-plane/Microsoft.GraphRbac/stable/1.6 (#5375)

- requied -> required
- authorizaed -> authorized
- Organizatio -> Organization
- Allorganizations -> AllOrganizations
- Microsof -> Microsoft
- perperties -> prorperties
- servie -> service
- altenative -> alternative
- thubmbprint -> thumbprint

* Azure DevOps Pipeline workaround for private repository (#5374)

* Fix PolicyInsights code generation issue (#5389)

* Add replica creation parameters to Postgres ResourceProvider for SDK (#5379)

*  Add replica creation parameters to Postgres ResourceProvider for SDK

* Add replica creation parameters to Postgres ResourceProvider for SDK

* Add replica creation parameters to Postgres ResourceProvider for SDK

* Add replica creation parameters to Postgres ResourceProvider for SDK

* Add replica creation parameters to Postgres ResourceProvider for SDK
AutorestCI added a commit to Azure/azure-sdk-for-js that referenced this issue Mar 15, 2019
FI from master to network-february-release (#5391)

* Add mixedreality 2019-02-28 API version to Go SDK (#5271)

* Remove ARM gateway Node.js configuration (#5283)

* Updates to Scheduled Query Rule swagger (#5175)

- making aznsaction paramter optional
  - removing hidden-link value from tags
pu

* Fix JavaScript configuration for ARM Private DNS SDK (#5284)

* Fix JavaScript configuration for ARM Private DNS SDK

* Add quotes

* Add private preview API for Azure Image Builder (#5055)

* Add private preview API for Azure Image Builder

* Review comments

 - Added list-by-resource-group and list-by-subscription
 - Added default error response
 - Removed explicit operation url (implied by async contract)
 - Adjusted 'delete' response codes to match expectations
 - Allow patch for tags
 - Added provider operations API

* Review comment: use "nextLink" for paging

* Adding readme files for SDK generation

* PR: rename 'tags' -> 'artifactTags' for distributor

* Add examples, fix minor issues in swagger

* Updating Blueprint spec to include resource group tags (#5263)

* Add Showback model (#5217)

* Add Showback model

* fix ShowbackRule.json example

* remove "," from line 1709

* Add Put Rule

* Fix Scope

* Update json with pull request changes

* change recurring to enum

* chore: Graphservice -> GraphService (#5098)

* Enable SSL on custom domains using users certificate or CDN managed certificate (#5276)

* Translator Text API V3 (#5230)

* Translator Text API V3

* Fix path and override

* Fix a typo and few other improvements in descriptions.

* Remove after_scripts

* Update readme.md

* Update readme.md

* Update MariaDB api version (#5280)

* Adding Swagger and examples for VirtualClusters operation group (#5248)

* Adding Swagger file for VirtualClusters operation group, together with examples.

* Fixing api version, typos and location in examples.

* Adding virtualclusters.json to readme.md

* Security - Updating API versions of alerts and pricing types (#5269)

* Security - Updating api versions of alerts and pricing types

* fix codegen paths for Go SDK

* typo: asscociation -> association (#5252)

* Fix lintdiff issue (#5299)

* fix Go SDK package path for mariadb stable release (#5298)

* changes to improve documentation of endpoint health statuses for routing (#5290)

* add netapp to Go SDK (#5308)

* Update MariaDB default API version to 2018-06-01 (#5302)

* new application insignts api version for unified schema in action (#5292)

* Added Azure App Configuration event data schema. (#5309)

* Added Azure App Configuration event data schema.

* Added a few missing pieces.

* Prefixed event names with our service prefix 'AppConfiguration'.
* Added Microsoft.AppConfiguration to the event grid data-plane readme.

* Updated api-version path to '2018-01-01' from '2018-02-01'.

* Apim Cache resource + DELETE long running + refactor to align with tooling. (#5260)

* api import and service delete long running operation

* Bring your own Cache

align with spec generated from tooling

user and notification align

Refactor products and apis

* align with spec generated from tooling

user and notification align

Refactor products and apis

validating examples

validating examples

move all parameters to apimanagement.json

Fix reference issue with tagcontract and example DeleteCache.

* switch to plural example file names for LIST

* bring back updatehostname and updatecertificate

* Dev adhybridhealthservice microsoft.ad hybrid health service 2014 01 01 binilkk (#5042)

* Fixes for:

Issue #1 : Azure/azure-rest-api-specs#4576 (comment)

Typo in the DeltaOperationType Enum.

Issue #2 : Azure/azure-rest-api-specs#4844 (comment)

GlobalAdmins list is marked as an object, while it's an array.

* Updated the Specification as example for Risky IP Download report.

* Added the Result details

* Fixed review comments, changed the URI scheme as well as changed get/post methods

* Addressing Review Feedback, changing POST call of blobUri -> generateBlobUri

* Update UserAssignedIdentities spec in Web (#5288)

* Update UserAssignedIdentities spec in Web

Microsoft.Web recently added support for UserAssigned managed service identities (in preview), but the swagger spec is incorrect for the identity payload as it follows the old construct of sending an array of identityIds as opposed to the updated spec which instead sends a dictionary object called userAssignedIdentities. 

Spec + history outlined here:
http://sharepoint/sites/AzureUX/Sparta/_layouts/15/WopiFrame2.aspx?sourcedoc=%7b633632B4-02E4-4DE2-92A9-EDCAF9BE73D4%7d&file=ARM%2BMSI.docx&action=default 

Our swagger contains identityids[] because of previous work to future support UserAssigned identities, but never released the feature in that state, rather we opted to wait for the new spec to be supported and then integrated with that on our end. 

Our MSI implementation reflects Microsoft.Compute's spec for user assigned.

https://github.com/Azure/azure-rest-api-specs/blob/78e1feab142c605839aa3cec23442ca26b8ef04d/specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/compute.json

* fix linterdiff tool

* Add private dns module name for java codegen (#5312)

* Update Swagger Files For ManagedInstanceAdministrator (#5095)

* Update Swagger Files For ManagedInstanceAdministrator

* Fix for double wording

* Comments resolved

* Bringing consistency between to "ResourceGroup" definition (#5256)

* Bringing consistency between this "ResourceGroup" definition and the one in Common.

* Fixing broken references

* reverted security python readme to pre multi api (#5301)

* [Azure Search] Add Search API to data plane Swagger spec (#5315)

* [Azure Search] Updating some Swagger descriptions to be more doc-friendly

Sometimes we over-describe things, especially "comma-separated lists" in
query string parameters. These are modeled as arrays in Swagger, which are
already understood to be comma-separated lists. They are modeled as
collections in generated code, so they are decidedly not comma-separated
lists in that context. So removing this phrase is a win-win.

* [Azure Search] Adding some missing readOnly attributes

* Adding Search API to the Azure Search data plane spec

* [Azure Search] Use regexes to generate code for server-side paging

This change introduces some very hacky regexes to customize the generated
code for server-side paging of the GET and POST Search APIs. They work by
splitting the generated SearchGet and SearchPost operations in two, so that
the portion that operates on a URL and request body can be reused.

This workaround is necessary because AutoRest lacks flexibility around
paging. The current x-ms-pageable implementation doesn't work for us because
it doesn't model additional top-level response properties or continuation
POST requests (only nextLink/GET).

The only other alternative to this approach besides custom code would have
been to try to parse the nextLink URL query string to reconstitute parameters
to pass to the generated SearchGet and SearchPost operations. This is
unacceptable for Azure Search, since it would exclude custom parameters that
can't be modeled in Swagger, like personalization IDs for custom ranking.
Neither AutoRest nor apparently Open API support modeling arbitrary query
string parameters.

Ideally we'll find a pattern common to other data plane APIs so we don't have
to hack this with regexes for every target language, but it's good enough for
now.

* [Azure Search] Rename some client properties for consistency

* [Azure Search] Make AutocompleteMode non-nullable

* [Hub Generated] Review request for Microsoft.Web to add version 2018-02-01 (#5137)

* Add Hosting Environment network dependencies

* Address PR description feedback

* Add Network Dependencies examples

* Fix casing

* Remove incorrect pagination from examples.

* Add missing MarketplaceOrdering operations to swagger (#5279)

* Add missing MarketplaceOrdering operations to swagger

* Add examples

* Add example files

* Apply suggestions from code review

Clarify operation descriptions

Co-Authored-By: zachraMSFT <zachra@microsoft.com>

* Fix Hosting Environment Network Dependencies pagination (#5320)

* Add regex validation for ManagedClusterAgentPoolProfile.name (#5324)

* Adding instance pools swagger (#5225)

* Initializing instance pools swagger and examples - no usages / managed instances get by instance pool

* updates to use common resource and sku definitions

* Update instance pool swagger with typo fixes

* Updates to instance pool swagger and reverting readme.md to exclude instance pools reference

* Fix whitespace diff

* Making a whitespace change to re-try linter validation

* Updates to add list instances pools by subscription and update license type param to use enum which is limited to LicenseIncluded and BasePrice

* Enhanced A2ARecoveryPointDetails with "disks" (#5307)

* [DiskRP] Adding swagger spec for 09-30-2018 (#5232)

* commit for the older swagger version to make the PR easier to look at

* Adding the DiskRP 09-30-2018 swagger spec. This includes support for hyperVGeneration, encryptionSettingCollections, diskState, Upload Disks, and Write access

* adding the updated readme

* updating the examples to use 09-30-2018

* removing extraneous examples

* adding a description for the EncryptionSettingsElementand fixing linter issues

* [Computer Vision] Add read to CV OCR API. (#5314)

* Add read to OCR API.

* Add description to OCR related JSON properties.

* Mark asyncBatchAnalyze as long running operation.

* Update page property.

* Revert "Mark asyncBatchAnalyze as long running operation."

This reverts commit 51742b3e212c2e900ed5c24f7c351fa7f896d25e.

* added links to limits for application gateway (#5265)

* typo: Winodws -> Windows (#5321)

* MultiApi EventHub (#5331)

* try 2 bootstrapping swagger to .net sdk tools (#5334)

* bootstrapping swagger to .net sdk tools

* deleting nuget.exe binary. Updating configs to locally restore pacakges. Adding the directory that will be used in restoring packages locally to .gitignore

* changing directory

* updating feed location to a readonly directory

* Azure Search: Resource Manager: Support 'None' Identity type (#5319)

* Azure Search: Resource Manager: Support 'None' Identity type

* Azure Search: Resource Manager: Adding serice identity creation\removal examples

* [ADLA] - Catalog - Add stream path to USqlTableFragment (#5329)

* [Hub Generated] Review request for Microsoft.Consumption to add version 2019-01-01 (#5311)

* Add GTM scopes for budgets API

* Removed the extra period at the end of the statement

* fixing stos.proj parameter (#5338)

* change flag name from useUnifiedSchema into useCommonAlertSchema per UX requirement (#5323)

* Enhanced A2A protection input and response details (#5330)

Enhanced A2AEnableProtectionInput & A2AReplicationDetails objects with recoveryAvailabilityZone, recoveryAzureNetworkId, and recoverySubnetName.

* [Hub Generated] Review request for Microsoft.ContainerService to add version 2019-02-01 (#5350)

* Adds base for updating Microsoft.ContainerService from version preview/2018-08-01-preview to version 2019-02-01

* Updates readme

* Updates API version in new specs and examples

* [AKS] add availabilityZones to agent pool profile (#5120)

* including orchestratorVersion and provisioning state for agent pool (#5156)

* including orchestratorVersion and provisioning state for agent pool

* fixing the readme.go.md

* including enablePodSecurityPoliy properties for managedcluster and updating examples

* fixing the example for enablePodSecurityPolicy

* including apiServerAuthorizedIPRanges (#5286)

* including apiServerAuthorizedIPRanges

* support azure network policy

* mark the new features as PREVIEW in description  (#5310)

* mark the new features as PREVIEW

* mark vmss as required for az

* Azure Event Grid: Add 2019-02-01-preview tags for Ruby and Go readme files (#5349)

* Add 2019-02-01-preview tags for Ruby and Go readme files

* fix wrong preview subdirectory

* Update some descriptions. (#5305)

* update description. (#5335)

* Added VNet API (#5351)

* EventHub : corrected typo  (#5360)

* corrected typo in uri

* removed unused parameters

* Add annotations property to trigger (#5332)

* EventHub: Revert the NetworkRuleSet  (#5363)

* Revert "EventHub : corrected typo  (#5360)"

This reverts commit 1495122039e95d8795e3769d06c60e290cb53d2b.

* Revert "Added VNet API (#5351)"

This reverts commit f2ab4a8208bd3de1813b26b078429357dbd05506.

* Remove the AzureDataLakeStoreCosmosStructuredStreamDataset since it's internal only (#5277)

* Removing SDK generation from Travis-CI (#5367)

* Microsoft.DataBoxEdge RP: Corrected comments of trigger and extendedinfo APIs, corrected examples (#5322)

* Corrected comments of trigger and extendedinfo APIs, corrected examples

* Microsoft.DataBoxEdge RP: Have better examples

* Corrected parameter description in order API

* oad => @azure/oad (#5362)

* oad => @azure/oad

* oad => @azure/oad

* SRP Swagger changes for 2018-11-01 (#5300)

* SRP Swagger changes for 2018-11-01

* Address CR comments

* Restrict ManagementPolicyRule -> type property to have only values from defined enum

* Make ManagementPolicySchema/version an enum string

* Remove 'version' property from ManagementPolicy schema

* Added List Policies API to SecurityAlerts (#5070)

* Added SecurityAlert List API

Added List api to:
Manged Server + Managed Database
Logical Server + Logical Database

* FIxed a description

this property is for databases+servers

* Added missing Database exmaples

Added missing examples for database security alert

* Added missing description change

For Server Security Alerts

* Revert "FIxed a description"

This reverts commit e01a332d6e97ebedf04677ea5eb356ae4570d97b.

* Revert "Added missing description change"

This reverts commit 17aeab7011d6085d08e562248eb89c2b2fe40277.

* Update DatabaseSecurityAlertListByDatabase.json

* fixed examples

* Update DatabaseSecurityAlertCreateMin.json

Deleted wild comma

* Update readme.md

* Minor fixes

Changed tabs to spaces.
Added location for servers exmaples.

* Removed location

removed the location property from examples

* graph: improve API coverage on application & service principal  (#5181)

* [graphrbac]: fix bugs in permission grant apis

* fix paging

* add missing property

* remove pageable

* author pagable in the right way

* breaking changes over a wrong spec

* remove additionalProperties which causes wrong code-gen

* add suppressions

* use code to surpress

* address review feedabck

* moev ahead with the established pattern anyway

* address review feedbacks

* clean up all

* update operation id

* add one more property per CLI user's ask

* Add insights 2019-03-01 package to Go SDK (#5373)

* Add insights 2019-03-01 package to Go SDK

* move global settings before packages

* fix package tag for new API version (#5378)

* Remove GZRS and RAGZRS sku from SRP 2018-11-01 because feature slipped. (#5377)

* typo: upto -> up to (#5376)

* typo: graphrbac/data-plane/Microsoft.GraphRbac/stable/1.6 (#5375)

- requied -> required
- authorizaed -> authorized
- Organizatio -> Organization
- Allorganizations -> AllOrganizations
- Microsof -> Microsoft
- perperties -> prorperties
- servie -> service
- altenative -> alternative
- thubmbprint -> thumbprint

* Azure DevOps Pipeline workaround for private repository (#5374)

* Fix PolicyInsights code generation issue (#5389)

* Add replica creation parameters to Postgres ResourceProvider for SDK (#5379)

*  Add replica creation parameters to Postgres ResourceProvider for SDK

* Add replica creation parameters to Postgres ResourceProvider for SDK

* Add replica creation parameters to Postgres ResourceProvider for SDK

* Add replica creation parameters to Postgres ResourceProvider for SDK

* Add replica creation parameters to Postgres ResourceProvider for SDK
praries880 pushed a commit that referenced this issue Mar 22, 2019
* Fixes for:

Issue #1 : #4576 (comment)

Typo in the DeltaOperationType Enum.

Issue #2 : #4844 (comment)

GlobalAdmins list is marked as an object, while it's an array.

* Updated the Specification as example for Risky IP Download report.

* Added the Result details

* Fixed review comments, changed the URI scheme as well as changed get/post methods

* Addressing Review Feedback, changing POST call of blobUri -> generateBlobUri

* Added new operation to get connector metadata.

* Addressing PR Comments

* Fixing typo

* Updated examples with real values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants