Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full vault restore swagger some types missing descriptions or with ambiguous names #9812

Closed
christothes opened this issue Jun 11, 2020 · 9 comments
Closed

Full vault restore swagger some types missing descriptions or with ambiguous names #9812

christothes opened this issue Jun 11, 2020 · 9 comments
Assignees
@vasanthrajams
Labels
KeyVault needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team.
Milestone
Sprint 172

Comments

@christothes
Copy link
Member

christothes commented Jun 11, 2020 •
edited
Loading

Missing descriptions

azure-rest-api-specs/specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.2/backuprestore.json

Line 274 in 9a54fc6

"sasTokenParameters": {

azure-rest-api-specs/specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.2/backuprestore.json

Line 289 in 9a54fc6

"sasTokenParameters": {

Ambiguous names

The common Error type gets flagged by some generators as being too generic. Could we possibly rename it to something like KeyValuOperationError or KeyVaultServiceError?

azure-rest-api-specs/specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.2/common.json

Line 52 in 9a54fc6

"Error": {

@christothes christothes added KeyVault Service Attention Workflow: This issue is responsible by Azure service team. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team labels Jun 11, 2020
@christothes christothes added this to the Sprint 172 milestone Jun 11, 2020
@ghost
Copy link

ghost commented Jun 11, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @RandalliLama, @schaabs, @jlichwa.

@jlichwa
Copy link
Contributor

jlichwa commented Jul 24, 2020

@amitbapat is that related to full backup?

@amitbapat
Copy link

@vasanthrajams and @vickm to address.

@jlichwa jlichwa assigned vasanthrajams and unassigned amitbapat and jlichwa Aug 10, 2020
@sebansal
Copy link
Contributor

sebansal commented Nov 6, 2020

Ping @vasanthrajams

@sebansal
Copy link
Contributor

Ping @vickm

@sebansal
Copy link
Contributor

sebansal commented Dec 4, 2020

Is there an internal ADO work item open to track @vasanthrajams @vickm

@sebansal
Copy link
Contributor

sebansal commented Jan 5, 2021

Ping @vasanthrajams

@vasanthrajams
Copy link
Contributor

The first part of the changes for this issue already been merged. #11772
The second part of this issue(Ambiguous Names) was discussed in an email titled "AKV - github issues #ServiceAttention" and the consensus was to ignore for now.

@sebansal
Copy link
Contributor

sebansal commented Jan 5, 2021

Thank you @vasanthrajams, will close the issue for now.

@sebansal sebansal closed this as completed Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vasanthrajams vasanthrajams

Labels
KeyVault needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Milestone
Sprint 172
Development

No branches or pull requests
5 participants
@christothes @amitbapat @jlichwa @vasanthrajams @sebansal