Missing description #11772
Merged
Missing description #11772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding 7.2-preview version Signed-off-by: vasanthrajams <vasanthrajams@microsoft.com> * Resolve PR feedback * Fix output-folder for go code generation Co-authored-by: Heath Stewart <heaths@outlook.com>
vasanthrajams
requested review from
heaths,
jlichwa and
RandalliLama
as code owners
Swagger Validation Report
|
Swagger Generation Artifacts
|
vasanthrajams
requested review from
vickm,
docschmidt,
amitbapat and
christothes
tjprescott
approved these changes
Nov 23, 2020
heaths
approved these changes
Nov 23, 2020
| @@ -284,7 +284,8 @@ | |||
| "RestoreOperationParameters": { | |||
| "properties": { | |||
| "sasTokenParameters": { | |||
| "$ref": "#/definitions/SASTokenParameter" | |||
| "$ref": "#/definitions/SASTokenParameter", | |||
| "description": "SAS token parameter object containing azure storage resourceUri and token" | |||
There was a problem hiding this comment.
Please capitalize product marketing names, e.g. "Azure". Same below.
|
@heaths is the LintDiff failure expected (I have this vague notion that I've run into this before)? If so, is there a way to add an exclusion? |
|
Not those particular errors, no - just the |
tjprescott
approved these changes
Dec 14, 2020
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This was referenced Dec 14, 2020
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
* Adding 7.2-preview version (Azure#8397) * Adding 7.2-preview version Signed-off-by: vasanthrajams <vasanthrajams@microsoft.com> * Resolve PR feedback * Fix output-folder for go code generation Co-authored-by: Heath Stewart <heaths@outlook.com> * Add missing description for SASTokenParameter * Capitalize Azure Co-authored-by: Heath Stewart <heaths@outlook.com> Co-authored-by: vasanthrajams <vasanthrajams@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.