Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.AlertsManagement to add version preview/2019-05-05-preview #10028

Merged
merged 2 commits into from
Aug 11, 2020
Merged

[Hub Generated] Review request for Microsoft.AlertsManagement to add version preview/2019-05-05-preview #10028

merged 2 commits into from
Aug 11, 2020

Conversation

avjerafi
Copy link
Contributor

@avjerafi avjerafi commented Jul 3, 2020

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 3, 2020 •
edited
Loading

[Staging] Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings [Detail] [Expand]
Rule Message
❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'suppressionConfig' renamed or removed?
Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L2263:7
❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'actionGroupId' renamed or removed?
Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L2284:7
️️✔️LintDiff [Detail] 
 Validation passes for LintDiff.
️️✔️Avocado [Detail] 
 Validation passes for Avocado.
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 3, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 3, 2020 •
edited
Loading

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 3, 2020 •
edited
Loading

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 3, 2020 •
edited
Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 3, 2020 •
edited
Loading

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 3, 2020 •
edited
Loading

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 3, 2020 •
edited
Loading

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 2a77820 with merge commit 4ccf853. SDK Automation 13.0.17.20200807.2
  • ️✔️azure-mgmt-alertsmanagement [View full logs]  [Release SDK Changes] 
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-alertsmanagement
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-alertsmanagement
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 3.236% size of original (original: 35229 chars, delta: 1140 chars)
[ChangeLog]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 3, 2020 •
edited
Loading

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

ChenTanyi
ChenTanyi approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@ChenTanyi ChenTanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix ci error

@avjerafi
Copy link
Contributor Author

Is there anything I can/should do to expedite the approval of this breaking change?

@ChenTanyi
Copy link
Contributor

@avjerafi you need to fix the prettier check, please refer to the first comment.

For breaking change, please follow Azure Breaking changes approval request form as defined @ Breaking Change Process

@avjerafi
Copy link
Contributor Author

I've reviewed the Breaking Change policy, wiki and form. I don't believe this commit is rightly considered a breaking change. Currently, there are missing fields in the responses due to a wrongly structured definition of inheritance by use of a discriminator. This PR fixes this: the only effect of this change is the returning in the response of expected fields which are currently missing. This change is aligning the behavior with the customer's current expectation.

@ChenTanyi
Copy link
Contributor

@avjerafi You need to ask API Review Board @adrianhall to review. If it is emergent, please ask @akning-ms (ankun.ning@microsoft.com) for approve the breaking change.

Meanwhile, please fix the prettier check first. Otherwise, it could not be merged.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@avjerafi
Copy link
Contributor Author

avjerafi commented Aug 7, 2020

@akning-ms Following our mail correspondence, please approve this breaking change

@akning-ms akning-ms added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed BreakingChangeReviewRequired labels Aug 11, 2020
@akning-ms
Copy link
Contributor

approved breaking change as it is fixing bug in swagger, and this preview version plan to GA at the end of 2020

@akning-ms akning-ms merged commit 4ccf853 into Azure:master Aug 11, 2020
innosam pushed a commit to innosam/azure-rest-api-specs that referenced this pull request Aug 17, 2020
@avjerafi @innosam
[Hub Generated] Review request for Microsoft.AlertsManagement to add …
0aacded 
…version preview/2019-05-05-preview (Azure#10028)

* Fixed ActionRule's polymorphism via discriminator

* Applied prettier fixes

Co-authored-by: Avi Jerafi <avjerafi@microsoft.com>
@EranGon EranGon mentioned this pull request Sep 17, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenTanyi ChenTanyi ChenTanyi approved these changes

Assignees

@ChenTanyi ChenTanyi

Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avjerafi @azuresdkci @ChenTanyi @akning-ms