-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all premium firewall policy properties (private preview feature) #10072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adgrieve
requested review from
MikhailTryakhov,
anton-evseev and
v-shhatt
as code owners
July 8, 2020 19:38
[Staging] Swagger Validation Report
Only 10 items are listed, please refer to log for more details.
❌ |
Rule | Message |
---|---|
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'FirewallPolicyCertificateAuthority' removed or renamed? New: Microsoft.Network/stable/2020-04-01/firewallPolicy.json#L557:3 Old: Microsoft.Network/stable/2020-04-01/firewallPolicy.json#L557:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'FirewallPolicyCertificateAuthorityPropertiesFormat' removed or renamed? New: Microsoft.Network/stable/2020-04-01/firewallPolicy.json#L557:3 Old: Microsoft.Network/stable/2020-04-01/firewallPolicy.json#L557:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'FirewallPolicyIntrusionSystemMode' removed or renamed? New: Microsoft.Network/stable/2020-05-01/firewallPolicy.json#L557:3 Old: Microsoft.Network/stable/2020-05-01/firewallPolicy.json#L557:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'FirewallPolicyIntrusionSystemMode' removed or renamed? New: Microsoft.Network/stable/2020-03-01/firewallPolicy.json#L557:3 Old: Microsoft.Network/stable/2020-03-01/firewallPolicy.json#L557:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'FirewallPolicyCertificateAuthorityPropertiesFormat' removed or renamed? New: Microsoft.Network/stable/2020-05-01/firewallPolicy.json#L557:3 Old: Microsoft.Network/stable/2020-05-01/firewallPolicy.json#L557:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'FirewallPolicyCertificateAuthority' removed or renamed? New: Microsoft.Network/stable/2020-05-01/firewallPolicy.json#L557:3 Old: Microsoft.Network/stable/2020-05-01/firewallPolicy.json#L557:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'FirewallPolicyTransportSecurity' removed or renamed? New: Microsoft.Network/stable/2020-04-01/firewallPolicy.json#L557:3 Old: Microsoft.Network/stable/2020-04-01/firewallPolicy.json#L557:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'ManagedServiceIdentity' removed or renamed? New: Microsoft.Network/stable/2020-05-01/firewallPolicy.json#L557:3 Old: Microsoft.Network/stable/2020-05-01/firewallPolicy.json#L557:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'FirewallPolicyIntrusionSystemMode' removed or renamed? New: Microsoft.Network/stable/2020-04-01/firewallPolicy.json#L557:3 Old: Microsoft.Network/stable/2020-04-01/firewallPolicy.json#L557:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'FirewallPolicyTransportSecurity' removed or renamed? New: Microsoft.Network/stable/2020-05-01/firewallPolicy.json#L557:3 Old: Microsoft.Network/stable/2020-05-01/firewallPolicy.json#L557:3 |
️️✔️
LintDiff [Detail]
️✔️
Validation passes for LintDiff.
️️✔️
Avocado [Detail]
️✔️
Validation passes for Avocado.
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-js - Release
|
This was referenced Jul 8, 2020
Can one of the admins verify this patch? |
This was referenced Jul 8, 2020
@changlong-liu for comments impact for python sdk breaking change |
Hi @adgrieve , @akning-ms , This PR will bring breaking changes in Python: Breaking changes
|
lirenhe
added
the
Approved-BreakingChange
DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
label
Jul 9, 2020
lirenhe
approved these changes
Jul 9, 2020
azure-sdk-for-python-track2 - Release
|
4 tasks
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
…e) (Azure#10072) * Remove premium firewall policy properties (private) * Remove premium firewall policy properties (private)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved-BreakingChange
DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.