Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Security Center - Adaptive Application Control - Rename 'whitelist' #10100

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Azure Security Center - Adaptive Application Control - Rename 'whitelist' #10100

merged 2 commits into from
Jul 17, 2020

Conversation

erelh
Copy link
Contributor

@erelh erelh commented Jul 12, 2020 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask tih@microsoft.com (or NullMDR in github) for additional help.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 12, 2020 •
edited
Loading

[Staging] Swagger Validation Report

️❌BreakingChange: 4 Errors, 0 Warnings [Detail] [Expand]
Rule Message
❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AppWhitelistingGroup' removed or renamed?
New: Microsoft.Security/stable/2020-01-01/applicationWhitelistings.json#L217:3
Old: Microsoft.Security/stable/2020-01-01/applicationWhitelistings.json#L217:3
❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AppWhitelistingGroupData' removed or renamed?
New: Microsoft.Security/stable/2020-01-01/applicationWhitelistings.json#L217:3
Old: Microsoft.Security/stable/2020-01-01/applicationWhitelistings.json#L217:3
❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AppWhitelistingIssuesSummaries' removed or renamed?
New: Microsoft.Security/stable/2020-01-01/applicationWhitelistings.json#L217:3
Old: Microsoft.Security/stable/2020-01-01/applicationWhitelistings.json#L217:3
❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'AppWhitelistingGroup' removed or renamed?
New: Microsoft.Security/stable/2020-01-01/applicationWhitelistings.json#L541:3
Old: Microsoft.Security/stable/2020-01-01/applicationWhitelistings.json#L546:3
️️✔️LintDiff [Detail] 
 Validation passes for LintDiff.
️️✔️Avocado [Detail] 
 Validation passes for Avocado.
Posted by Swagger Pipeline | How to fix these errors?

@erelh
Copy link
Contributor Author

erelh commented Jul 12, 2020 •
edited
Loading

Hi,
We renamed some of the descriptions & models that had the word "whitelist".
That is why tests fail (only) on "breaking change" - some of the models were renamed.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@erelh
Copy link
Contributor Author

erelh commented Jul 14, 2020

@markcowl ?

@erelh
Copy link
Contributor Author

erelh commented Jul 15, 2020

@ChenTanyi @xccc-msft @raych1 @tjprescott @myronfanqiu can somebody please review ? note that tests fail (only) on "breaking change" because some of the internal models were renamed (no API change)

markcowl
markcowl requested changes Jul 17, 2020
View reviewed changes
...security/resource-manager/Microsoft.Security/stable/2020-01-01/applicationWhitelistings.json
@@ -359,9 +359,9 @@
"VersionAndAboveSignature"
]
},
"AppWhitelistingIssue": {
"AdaptiveApplicationControlIssue": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These name changes in your schemas will create breaking changes in all generated SDKs. Please revert.

@markcowl markcowl added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Jul 17, 2020
@markcowl
Copy link
Member

/openapibot sdkautomation

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

3 similar comments
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 17, 2020 •
edited
Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 17, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 17, 2020 •
edited
Loading

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from acb4f40 with merge commit 2fa64c8. SDK Automation 13.0.17.20200619.4
  • ️✔️azure-mgmt-security [View full logs]  [Release SDK Changes] 
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-security
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-security
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 11.447% size of original (original: 154481 chars, delta: 17684 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Added operation group IotAlertTypesOperations
[ChangeLog]   - Added operation group SecuritySolutionsOperations
[ChangeLog]   - Added operation group SecuritySolutionsReferenceDataOperations
[ChangeLog]   - Added operation group ConnectorsOperations
[ChangeLog]   - Added operation group IotAlertsOperations

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 17, 2020 •
edited
Loading

azure-sdk-for-js - Release

❌ failed [Logs] [Expand Details]
  • ❌ Generate from acb4f40 with merge commit 2fa64c8. SDK Automation 13.0.17.20200619.4
  • ❌@azure/arm-security [View full logs]  [Release SDK Changes] 
      [npmPack] npm ERR! code ENOTFOUND
[npmPack] npm ERR! errno ENOTFOUND
[npmPack] npm ERR! network request to https://registry.npmjs.org/@azure%2fms-rest-js failed, reason: getaddrinfo ENOTFOUND registry.npmjs.org
[npmPack] npm ERR! network This is a problem related to network connectivity.
[npmPack] npm ERR! network In most cases you are behind a proxy or have bad network settings.
[npmPack] npm ERR! network 
[npmPack] npm ERR! network If you are behind a proxy, please make sure that the
[npmPack] npm ERR! network 'proxy' config is set properly.  See: 'npm help config'
[npmPack] 
[npmPack] npm ERR! A complete log of this run can be found in:
[npmPack] npm ERR!     /home/sdk/.npm/_logs/2020-07-17T21_18_03_347Z-debug.log
[npmPack] npm ERR! code ELIFECYCLE
[npmPack] npm ERR! errno 1
[npmPack] npm ERR! @azure/arm-security@2.0.0 prepack: `npm install && npm run build`
[npmPack] npm ERR! Exit status 1
[npmPack] npm ERR! 
[npmPack] npm ERR! Failed at the @azure/arm-security@2.0.0 prepack script.
[npmPack] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
[npmPack] npm WARN Local package.json exists, but node_modules missing, did you mean to install?
[npmPack] 
[npmPack] npm ERR! A complete log of this run can be found in:
[npmPack] npm ERR!     /home/sdk/.npm/_logs/2020-07-17T21_18_03_366Z-debug.log
Failed to create the package @azure/arm-security.
Error: npm pack npm ERR! code ENOTFOUND
npm ERR! errno ENOTFOUND
npm ERR! network request to https://registry.npmjs.org/@azure%2fms-rest-js failed, reason: getaddrinfo ENOTFOUND registry.npmjs.org
npm ERR! network This is a problem related to network connectivity.
npm ERR! network In most cases you are behind a proxy or have bad network settings.
npm ERR! network 
npm ERR! network If you are behind a proxy, please make sure that the
npm ERR! network 'proxy' config is set properly.  See: 'npm help config'

      npm ERR! A complete log of this run can be found in:
      
npm ERR!     /home/sdk/.npm/_logs/2020-07-17T21_18_03_347Z-debug.log
      
npm ERR! code ELIFECYCLE
      
npm ERR! errno 1
      
npm ERR! @azure/arm-security@2.0.0 prepack: npm install && npm run build
      
npm ERR! Exit status 1
      
npm ERR!
      
npm ERR! Failed at the @azure/arm-security@2.0.0 prepack script.
      
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
      
npm WARN Local package.json exists, but node_modules missing, did you mean to install?
      

      npm ERR! A complete log of this run can be found in:
      
npm ERR!     /home/sdk/.npm/_logs/2020-07-17T21_18_03_366Z-debug.log
      
, {}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 17, 2020 •
    edited
    Loading

    azure-sdk-for-go - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 17, 2020 •
    edited
    Loading

    azure-sdk-for-go

    ⚠️ warning [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 17, 2020 •
    edited
    Loading

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 17, 2020 •
    edited
    Loading

    Azure CLI Extension Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 17, 2020 •
    edited
    Loading

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    markcowl
    markcowl approved these changes Jul 17, 2020
    View reviewed changes
    Copy link
    Member

    @markcowl markcowl left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    After discussion, the breaking changes are desirable to remove an offensive term.

    @markcowl markcowl added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review labels Jul 17, 2020
    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jul 17, 2020
    Closed
    This was referenced Jul 17, 2020
    Closed
    Closed
    @markcowl markcowl merged commit 2fa64c8 into Azure:master Jul 17, 2020
    This was referenced Aug 20, 2020
    Merged
    Closed
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    @erelh @00Kai0
    Azure Security Center - Adaptive Application Control - Rename 'whitel…
    ef7dd62 
    …ist' (Azure#10100)

* Rename 'whitelist'

* add missing 'Group' in renamed file

Co-authored-by: Erel Hansav <erelh@microsoft.com>
    @eliagrady eliagrady mentioned this pull request Nov 11, 2020
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @markcowl markcowl markcowl approved these changes

    Assignees

    @markcowl markcowl

    @erelh erelh

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @erelh @AutorestCI @azuresdkci @markcowl