Make origin a ProxyResource instead of TrackedResource #10126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Can one of the admins verify this patch? |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
We have not released this API version as yet for public preview. It is scheduled for release next week. So, this is not a breaking change for the users. |
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 14, 2020
|
@akning-ms - Yes we have not released any new versions of SDKs since our 2019-06-15-preview version of the API. So, none of these API versions have any SDK released. |
|
Hi @nachakra, Noticed you just have one more commit which also updated 2020-03-01 and 2020-04-15, plus 2019-12-31 totally 3 stable version. so I am confused, are they all not released? if yes, can I know why? :) |
akning-ms
reviewed
Jul 15, 2020
| @@ -4332,7 +4332,7 @@ | |||
| "type": "object", | |||
| "allOf": [ | |||
| { | |||
| "$ref": "#/definitions/TrackedResource" | |||
| "$ref": "#/definitions/ProxyResource" | |||
There was a problem hiding this comment.
Can I know why have this change from business/service perspective? as it is a breaking change for a stable api version
There was a problem hiding this comment.
It should have always been a proxy resource - it is associated with an endpoint which is a tracked resource. We don't need location/tags for this resource. As I said, this API version and the ones following it are not released as yet.
Because of covid/JEDI related deployment freezes, the 2019-12-31 version slipped quite a bit. 2020-03-01 is in private preview but 2020-04-15 is the version(uber version with 2019-12-31 changes) that we are targeting to release since it is associated with JEDI requirements. So, we will release 2019-12-31 version first with 2020-04-15 releasing in just few weeks after that. |
|
@akning-ms - I addressed your comments. Please take a look and let me know if you still have concerns. |
akning-ms
added
the
Approved-BreakingChange
akning-ms
approved these changes
Jul 17, 2020
@nachakra Could you elaborate on what "released" means in this context? Does that apply to SDKs only? Were the API endpoints available for these versions? If yes, this means that changes in specs are breaking for all non-SDK clients? For instance, What is the place to track whether these or other spec versions are released or not? |
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* Make origin a ProxyResource instead of TrackedResource * Fix model validation error * Fix model validation errors * Fix prettier errors * Make origin a proxyresource for all API versions starting from 12-30-2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.