-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft.AppConfiguration: Add 2020-07-01-preview API version #10224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
Can one of the admins verify this patch? |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-python-track2 - Release
- Breaking Change detected in SDK
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 22, 2020
openapi-assignment-bot
bot
added
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Jul 22, 2020
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
* Updated key-value operation ids to be consistent with other child resources * key value -> key-value for consistency
Pull request contains merge conflicts. |
pilor
added
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
and removed
ARMChangesRequested
<valid label in PR review process>add this label when require changes after ARM review
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
labels
Oct 21, 2020
pilor
approved these changes
Oct 21, 2020
Please fix the conflict first. |
No commit pushedDate could be found for PR 10224 in repo Azure/azure-rest-api-specs |
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Oct 22, 2020
This was referenced Oct 22, 2020
ChenTanyi
approved these changes
Oct 22, 2020
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
#sign-off |
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
…#10224) * Microsoft.AppConfiguration: Add 2020-07-01-preview API version * Prettier fix * Fix readme * Fix lint errors * revert * Fix error response * Fix syntax error * * Added required key-value list & delete operations. * Updated key-value operation ids to be consistent with other child resources * key value -> key-value for consistency * Prettier Co-authored-by: Jimmy Campbell <jimmyca@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
CI-BreakingChange-Python
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has already been reviewed and approved in the private repo: Azure/azure-rest-api-specs-pr#1497
The PR adds new API version 2020-07-01-preview, which includes two changes comparing with version 2020-06-01.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.