Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove premium SKU requirement for patch schedules #10241

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

curib
Copy link
Contributor

@curib curib commented Jul 23, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@curib curib requested a review from TimLovellSmith as a code owner July 23, 2020 17:26
@AutorestCI
Copy link

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask tih@microsoft.com (or NullMDR in github) for additional help.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 23, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@TimLovellSmith
Copy link
Member

@curib Could you please check off the contribution checkboxes assuming they are done?

Copy link
Member

@TimLovellSmith TimLovellSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! Signing off!

@weidongxu-microsoft
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 24, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 24, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 24, 2020

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 117420f with merge commit 41d9e7f. SDK Automation 13.0.17.20200619.4
  • ⚠️azure-mgmt-redis [View full logs]  [Release SDK Changes] Breaking Change Detected
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-redis
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-redis
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 2.480% size of original (original: 22218 chars, delta: 551 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model RedisInstanceDetails has a new parameter is_master
    [ChangeLog]   - Model RedisRebootParameters has a new parameter ports
    [ChangeLog] 
    [ChangeLog] **Breaking changes**
    [ChangeLog] 
    [ChangeLog]   - Operation RedisOperations.force_reboot has a new signature

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 24, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 24, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 24, 2020

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 117420f with merge commit 41d9e7f. SDK Automation 13.0.17.20200619.4
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 24, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 117420f with merge commit 41d9e7f. SDK Automation 13.0.17.20200619.4
  • ️✔️sdk/redis/mgmt-v2017_10_01 [View full logs]  [Release SDK Changes]
  • ⚠️sdk/redis/mgmt-v2018_03_01 [View full logs]  [Release SDK Changes]
      [mvn] [ERROR] COMPILATION ERROR : 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/redis/mgmt-v2018_03_01/src/main/java/com/microsoft/azure/management/redis/v2018_03_01/implementation/RedisManager.java:[88,50] incompatible types: com.microsoft.azure.management.redis.v2018_03_01.implementation.RedisManager cannot be converted to com.microsoft.azure.management.redis.v2018_03_01.implementation.CacheManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/redis/mgmt-v2018_03_01/src/main/java/com/microsoft/azure/management/redis/v2018_03_01/implementation/RedisManager.java:[98,40] incompatible types: com.microsoft.azure.management.redis.v2018_03_01.implementation.RedisManager cannot be converted to com.microsoft.azure.management.redis.v2018_03_01.implementation.CacheManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/redis/mgmt-v2018_03_01/src/main/java/com/microsoft/azure/management/redis/v2018_03_01/implementation/RedisManager.java:[108,56] incompatible types: com.microsoft.azure.management.redis.v2018_03_01.implementation.RedisManager cannot be converted to com.microsoft.azure.management.redis.v2018_03_01.implementation.CacheManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/redis/mgmt-v2018_03_01/src/main/java/com/microsoft/azure/management/redis/v2018_03_01/implementation/RedisManager.java:[118,58] incompatible types: com.microsoft.azure.management.redis.v2018_03_01.implementation.RedisManager cannot be converted to com.microsoft.azure.management.redis.v2018_03_01.implementation.CacheManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/redis/mgmt-v2018_03_01/src/main/java/com/microsoft/azure/management/redis/v2018_03_01/implementation/RedisManager.java:[128,56] incompatible types: com.microsoft.azure.management.redis.v2018_03_01.implementation.RedisManager cannot be converted to com.microsoft.azure.management.redis.v2018_03_01.implementation.CacheManager
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-cache: Compilation failure: Compilation failure: 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/redis/mgmt-v2018_03_01/src/main/java/com/microsoft/azure/management/redis/v2018_03_01/implementation/RedisManager.java:[88,50] incompatible types: com.microsoft.azure.management.redis.v2018_03_01.implementation.RedisManager cannot be converted to com.microsoft.azure.management.redis.v2018_03_01.implementation.CacheManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/redis/mgmt-v2018_03_01/src/main/java/com/microsoft/azure/management/redis/v2018_03_01/implementation/RedisManager.java:[98,40] incompatible types: com.microsoft.azure.management.redis.v2018_03_01.implementation.RedisManager cannot be converted to com.microsoft.azure.management.redis.v2018_03_01.implementation.CacheManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/redis/mgmt-v2018_03_01/src/main/java/com/microsoft/azure/management/redis/v2018_03_01/implementation/RedisManager.java:[108,56] incompatible types: com.microsoft.azure.management.redis.v2018_03_01.implementation.RedisManager cannot be converted to com.microsoft.azure.management.redis.v2018_03_01.implementation.CacheManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/redis/mgmt-v2018_03_01/src/main/java/com/microsoft/azure/management/redis/v2018_03_01/implementation/RedisManager.java:[118,58] incompatible types: com.microsoft.azure.management.redis.v2018_03_01.implementation.RedisManager cannot be converted to com.microsoft.azure.management.redis.v2018_03_01.implementation.CacheManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/redis/mgmt-v2018_03_01/src/main/java/com/microsoft/azure/management/redis/v2018_03_01/implementation/RedisManager.java:[128,56] incompatible types: com.microsoft.azure.management.redis.v2018_03_01.implementation.RedisManager cannot be converted to com.microsoft.azure.management.redis.v2018_03_01.implementation.CacheManager
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jul 24, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants