-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add private endpoint names for datasync #10264
Add private endpoint names for datasync #10264
Conversation
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python - Release
|
azure-sdk-for-python
- Breaking Change detected in SDK
|
azure-sdk-for-net - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Can one of the admins verify this patch? |
@danikaZ , can you fix the PrettierCheck failure? |
Azure Pipelines successfully started running 1 pipeline(s). |
@raych1 Thanks for the comment! Fixed the format! |
There is no new API version/service not sure why WaitForARMFeedback label was applied. Removing. Please review the instructions and add if necessary. |
@danikaZ , are you still working on this PR? |
@danikaZ , I'm going to close this PR if there's no response in 2 days. Feel free to re-open it to continue your work. |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-resource-manager-schemas - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
@raych1 sorry for the delay. Yes, I was waiting on the changes deployment. Now the change has been enabled in more than one production regions. |
|
* Add private endpoint names for datasync * fix prettier formatting
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.