Add preAttack tactic to swagger #10332

Amitbergman · 2020-08-04T05:27:09Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

AutorestCI · 2020-08-04T05:27:11Z

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask tih@microsoft.com (or NullMDR in github) for additional help.

openapi-pipeline-app · 2020-08-04T05:27:13Z

[Staging] Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings [Detail] [Expand]

Rule	Message
`❌` 1020 - AddedEnumValue	The new version is adding enum value(s) 'PreAttack' from the old version. New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L4584:11 Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L4583:11
`❌` 1020 - AddedEnumValue	The new version is adding enum value(s) 'PreAttack' from the old version. New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L5958:11 Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L5957:11

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azuresdkci · 2020-08-04T05:28:09Z

Can one of the admins verify this patch?

njuCZ · 2020-08-04T06:27:50Z

/azp run

azure-pipelines · 2020-08-04T06:28:10Z

Azure Pipelines successfully started running 3 pipeline(s).

openapi-sdkautomation · 2020-08-04T06:29:27Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from ea4538d with merge commit e345bb9. SDK Automation 13.0.17.20200619.4
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-08-04T06:29:28Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from ea4538d with merge commit e345bb9. SDK Automation 13.0.17.20200619.4

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.SecurityInsights [View full logs] [Release SDK Changes]
No Artifact Generated.

openapi-sdkautomation · 2020-08-04T06:29:30Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-04T06:29:31Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-04T06:29:31Z

Azure CLI Extension Generation - Release

Installation instruction for service securityinsight [Preview Changes]
az extension add --source=https://sdkautomation.blob.core.windows.net/sdkautomation-pipeline/Azure/azure-rest-api-specs/10332/azure-cli-extensions/Azure/azure-cli-extensions/securityinsight/sentinel-0.1.0-py3-none-any.whl

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from ea4538d with merge commit e345bb9. Azure CLI Automation 13.0.17.20200619.4

[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'AwsCloudTrailDataConnectorDataTypes-logs' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-exchange' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-sharePoint' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'TIDataConnectorDataTypes-indicators' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRuleTemplatesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRulesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BookmarkList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DataConnectorList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentCommentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OfficeConsentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceWithEtag' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'MCASDataConnectorDataTypes' has a property 'alerts' that is already declared the parent schema 'AlertsDataTypeOfDataConnector' but isn't significantly different. The property has been removed from MCASDataConnectorDataTypes
[AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
[AutoRest] 
[AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
[AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
[AutoRest] --------------------------------------------------------
[AutoRest]   test-scenario:
[AutoRest]     - name: /Actions/get/Get all actions of alert rule.
[AutoRest]     - name: /AlertRuleTemplates/get/Get alert rule template by Id.
[AutoRest]     - name: /AlertRuleTemplates/get/Get all alert rule templates.
[AutoRest]     - name: /AlertRules/put/Creates or updates a Fusion alert rule.
[AutoRest]     - name: /AlertRules/put/Creates or updates a MicrosoftSecurityIncidentCreation rule.
[AutoRest]     - name: /AlertRules/put/Creates or updates a Scheduled alert rule.
[AutoRest]     - name: /AlertRules/put/Creates or updates an action of alert rule.
[AutoRest]     - name: /AlertRules/get/Get a Fusion alert rule.
[AutoRest]     - name: /AlertRules/get/Get a MicrosoftSecurityIncidentCreation rule.
[AutoRest]     - name: /AlertRules/get/Get a Scheduled alert rule.
[AutoRest]     - name: /AlertRules/get/Get all alert rules.
[AutoRest]     - name: /AlertRules/get/Get an action of alert rule.
[AutoRest]     - name: /Bookmarks/put/Creates or updates a bookmark.
[AutoRest]     - name: /Bookmarks/get/Get a bookmark.
[AutoRest]     - name: /Bookmarks/get/Get all bookmarks.
[AutoRest]     - name: /DataConnectors/put/Creates or updates an Office365 data connector.
[AutoRest]     - name: /DataConnectors/get/Get a ASC data connector.
[AutoRest]     - name: /DataConnectors/get/Get a MCAS data connector.
[AutoRest]     - name: /DataConnectors/get/Get a MDATP data connector
[AutoRest]     - name: /DataConnectors/get/Get a TI data connector.
[AutoRest]     - name: /DataConnectors/get/Get all data connectors.
[AutoRest]     - name: /DataConnectors/get/Get an AAD data connector.
[AutoRest]     - name: /DataConnectors/get/Get an AATP data connector.
[AutoRest]     - name: /DataConnectors/get/Get an AwsCloudTrail data connector.
[AutoRest]     - name: /DataConnectors/get/Get an Office365 data connector.
[AutoRest]     - name: /IncidentComments/put/Creates an incident comment.
[AutoRest]     - name: /IncidentComments/get/Get all incident comments.
[AutoRest]     - name: /IncidentComments/get/Get an incident comment.
[AutoRest]     - name: /Incidents/put/Creates or updates an incident.
[AutoRest]     - name: /Incidents/get/Get all incidents.
[AutoRest]     - name: /Incidents/get/Get an incident.
[AutoRest]     - name: /AlertRules/delete/Delete an alert rule.
[AutoRest]     - name: /AlertRules/delete/Delete an action of alert rule.
[AutoRest]     - name: /Bookmarks/delete/Delete a bookmark.
[AutoRest]     - name: /DataConnectors/delete/Delete an Office365 data connector.
[AutoRest]     - name: /Incidents/delete/Delete an incident.
[AutoRest] --------------------------------------------------------

️✔️securityinsight [View full logs] [Release Azure CLI Changes]
- sentinel-0.1.0-py3-none-any.whl
- sentinel-0.1.0.zip

openapi-sdkautomation · 2020-08-04T06:29:32Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from ea4538d with merge commit e345bb9. SDK Automation 13.0.17.20200619.4
```
[azure-mgmt-securityinsight][ChangeLog] WARNING: Failed to generate ChangeLog.
```

⚠️azure-mgmt-securityinsight [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-mgmt-securityinsight
[build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-securityinsight
[build_conf] INFO:packaging_tools:Template done azure-mgmt-securityinsight
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
Not exact 2 reports found:
Not generating changelog.
[ChangeLog] WARNING: Failed to generate ChangeLog.

openapi-sdkautomation · 2020-08-04T06:29:34Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from ea4538d with merge commit e345bb9. SDK Automation 13.0.17.20200619.4
️✔️preview/securityinsight/mgmt/2019-01-01-preview [View full logs] [Release SDK Changes]
- preview.securityinsight.mgmt.2019-01-01-preview.zip
️✔️preview/securityinsight/mgmt/v1.0 [View full logs] [Release SDK Changes]
- preview.securityinsight.mgmt.v1.0.zip

openapi-sdkautomation · 2020-08-04T06:29:34Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

…into fix_kv_python_readme * 'master' of https://github.com/Azure/azure-rest-api-specs: (29 commits) Add preAttack tactic to swagger (Azure#10332) Add Url Signing action definition (Azure#10326) [Synapse] Support long running operation and add subclass of Activity in artifact (Azure#10270) Add native blob soft delete (Azure#10308) Fix Microsoft.Resources naming issue (Azure#10318) Notebooks swagger spec (Azure#9841) Add network profile in Spring payload. (Azure#10313) Fix output-folder for go SDK in timeseriesinsight (Azure#10300) Alias Put Subscription API (Azure#10205) resource-resource-2019-03-01-python-config (Azure#10314) New Api version 2020-06-15- fixing certificate put/get issues with ARM (Azure#10251) [DataFactory] Support source sink level staging (Azure#10290) Added swagger files for PostgreSQL Flexible Server preview (Azure#10020) [Hub Generated] Review request for Microsoft.AppPlatform to add version preview/2019-05-01-preview (Azure#10302) Adding Untracked Public Maintenance Config Resource Type (Azure#10281) add assignment resource id to the schema (Azure#10309) [datashare] sort api's and definitions (Azure#10273) Update readme.md all-api-versions tags (Azure#10296) Documentation updated (Azure#10283) [CosmosDB] Migration support of existing containers/databases to autoscale (Azure#9258) ...

Add preAttack tactic to swagger

ea4538d

openapi-assignment-bot bot assigned njuCZ Aug 4, 2020

njuCZ added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 4, 2020

njuCZ approved these changes Aug 4, 2020

View reviewed changes

njuCZ merged commit e345bb9 into Azure:master Aug 4, 2020

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

Add preAttack tactic to swagger (Azure#10332)

13cce86

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add preAttack tactic to swagger #10332

Add preAttack tactic to swagger #10332

Amitbergman commented Aug 4, 2020

AutorestCI commented Aug 4, 2020

openapi-pipeline-app bot commented Aug 4, 2020 •

edited

Loading

azuresdkci commented Aug 4, 2020

njuCZ commented Aug 4, 2020

azure-pipelines bot commented Aug 4, 2020

openapi-sdkautomation bot commented Aug 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 4, 2020 •

edited

Loading

Add preAttack tactic to swagger #10332

Add preAttack tactic to swagger #10332

Conversation

Amitbergman commented Aug 4, 2020

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

AutorestCI commented Aug 4, 2020

openapi-pipeline-app bot commented Aug 4, 2020 • edited Loading

[Staging] Swagger Validation Report

azuresdkci commented Aug 4, 2020

njuCZ commented Aug 4, 2020

azure-pipelines bot commented Aug 4, 2020

openapi-sdkautomation bot commented Aug 4, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Aug 4, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Aug 4, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Aug 4, 2020 • edited Loading

Trenton Generation - Release

openapi-sdkautomation bot commented Aug 4, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Aug 4, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Aug 4, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Aug 4, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

openapi-pipeline-app bot commented Aug 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 4, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 4, 2020 •

edited

Loading