correct example responses #10360

changlong-liu · 2020-08-06T07:54:50Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-08-06T07:54:54Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-08-06T07:55:07Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-08-06T08:01:38Z

Azure CLI Extension Generation - Release

Installation instruction for service desktopvirtualization [Preview Changes]
curl -L "https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/azure-rest-api-specs/10360/azure-cli-extensions/desktopvirtualization/desktopvirtualization-0.1.0-py3-none-any.whl" -o desktopvirtualization-0.1.0-py3-none-any.whl az extension add --source=desktopvirtualization-0.1.0-py3-none-any.whl

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from bdd76f9 with merge commit d587005. Azure CLI Automation 13.0.17.20200918.2

[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperationList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'TrackedResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
[AutoRest] WARNING (): Operation Update has already existed in group! Skip split!
[AutoRest] WARNING (): Operation Update has already existed in group! Skip split!
[AutoRest] WARNING (): Operation Update has already existed in group! Skip split!
[AutoRest] WARNING (): Operation Update has already existed in group! Skip split!
[AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
[AutoRest] 
[AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
[AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
[AutoRest] --------------------------------------------------------
[AutoRest]   test-scenario:
[AutoRest]     - name: /HostPools/put/HostPool_Create
[AutoRest]     - name: /HostPools/get/HostPool_Get
[AutoRest]     - name: /HostPools/get/HostPool_List
[AutoRest]     - name: /HostPools/get/HostPool_ListByResourceGroup
[AutoRest]     - name: /HostPools/patch/HostPool_Update
[AutoRest]     - name: /ApplicationGroups/put/ApplicationGroup_Create
[AutoRest]     - name: /ApplicationGroups/get/ApplicationGroup_Get
[AutoRest]     - name: /ApplicationGroups/get/ApplicationGroup_List
[AutoRest]     - name: /ApplicationGroups/get/ApplicationGroup_ListByResourceGroup
[AutoRest]     - name: /ApplicationGroups/patch/ApplicationGroups_Update
[AutoRest]     - name: /ApplicationGroups/delete/ApplicationGroup_Delete
[AutoRest]     - name: /Workspaces/put/Workspace_Create
[AutoRest]     - name: /Workspaces/get/Workspace_Get
[AutoRest]     - name: /Workspaces/get/Workspace_ListByResourceGroup
[AutoRest]     - name: /Workspaces/get/Workspace_ListBySubscription
[AutoRest]     - name: /Workspaces/patch/Workspace_Update
[AutoRest]     - name: /HostPools/delete/HostPool_Delete
[AutoRest]     - name: /Workspaces/delete/Workspace_Delete
[AutoRest] --------------------------------------------------------

️✔️desktopvirtualization [View full logs] [Release Azure CLI Changes]

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 23 Sep 2020 19:28:49 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0482:32EF:B83209:199F1DF:5F6BA1F1","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-08-06T08:02:29Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from bdd76f9 with merge commit d587005. SDK Automation 13.0.17.20200918.2
⚠️preview/desktopvirtualization/mgmt/2019-01-23-preview [View full logs]
- preview.desktopvirtualization.mgmt.2019-01-23-preview.zip
```
No file is changed.
```
⚠️preview/desktopvirtualization/mgmt/2019-09-24-preview [View full logs]
- preview.desktopvirtualization.mgmt.2019-09-24-preview.zip
```
No file is changed.
```
⚠️preview/desktopvirtualization/mgmt/2019-12-10-preview [View full logs]
- preview.desktopvirtualization.mgmt.2019-12-10-preview.zip
```
No file is changed.
```

openapi-sdkautomation · 2020-08-06T08:02:44Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from bdd76f9 with merge commit d587005. SDK Automation 13.0.17.20200918.2

️✔️sdk/desktopvirtualization/mgmt-v2019_12_10_preview [View full logs] [Release SDK Changes]

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 23 Sep 2020 19:31:40 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0401:3DCF:4C1008B:8651842:5F6BA29C","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-08-06T08:02:48Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-06T08:02:53Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from bdd76f9 with merge commit d587005. SDK Automation 13.0.17.20200918.2
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-08-06T08:02:55Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from bdd76f9 with merge commit d587005. SDK Automation 13.0.17.20200918.2
```
[azure-mgmt-desktopvirtualization][ChangeLog] WARNING: Failed to generate ChangeLog.
```

⚠️azure-mgmt-desktopvirtualization [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-mgmt-desktopvirtualization
[build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-desktopvirtualization
[build_conf] INFO:packaging_tools:Template done azure-mgmt-desktopvirtualization
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 23 Sep 2020 19:29:07 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"04C3:7FB6:16B879D:266C284:5F6BA203","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
Not exact 2 reports found:
Not generating changelog.
[ChangeLog] WARNING: Failed to generate ChangeLog.

openapi-sdkautomation · 2020-08-06T08:03:01Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-06T08:03:05Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azuresdkci · 2020-08-06T08:17:11Z

Can one of the admins verify this patch?

markcowl · 2020-08-07T23:38:29Z

/azp run

azure-pipelines · 2020-08-07T23:38:50Z

Azure Pipelines successfully started running 3 pipeline(s).

markcowl

Approved once the checks pass.

markcowl · 2020-08-18T02:43:55Z

/azp run Swagger BreakingChange

azure-pipelines · 2020-08-18T02:44:00Z

No pipelines are associated with this pull request.

azure-pipelines · 2020-08-19T08:37:31Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-08-19T08:40:00Z

azure-resource-manager-schemas - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from bdd76f9 with merge commit d587005. Schema Automation 13.0.17.20200918.2
```
Failed to find any diff after autorest so no changed packages was found.
```

changlong-liu · 2020-08-19T08:54:02Z

Hi @markcowl , it get green after I make a rebase to the latest master

changlong-liu requested a review from datr93 August 6, 2020 07:54

openapi-assignment-bot bot assigned markcowl Aug 6, 2020

datr93 approved these changes Aug 6, 2020

View reviewed changes

openapi-sdkautomation bot mentioned this pull request Aug 7, 2020

[AutoPR desktopvirtualization] correct example responses AzureSDKAutomation/azure-cli-extensions#172

Closed

markcowl approved these changes Aug 7, 2020

View reviewed changes

correct example responses

bdd76f9

changlong-liu force-pushed the 20200806-desktopvritualization branch from adf8876 to bdd76f9 Compare August 19, 2020 08:37

This was referenced Aug 19, 2020

[AutoPR azure-mgmt-desktopvirtualization] correct example responses AzureSDKAutomation/azure-sdk-for-python#1821

Closed

[AutoPR desktopvirtualization] correct example responses AzureSDKAutomation/azure-resource-manager-schemas#106

Closed

markcowl merged commit d587005 into Azure:master Sep 23, 2020

nitegupt pushed a commit to nitegupt/azure-rest-api-specs that referenced this pull request Sep 25, 2020

correct example responses (Azure#10360)

b3ecf9f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

correct example responses #10360

correct example responses #10360

changlong-liu commented Aug 6, 2020

openapi-pipeline-app bot commented Aug 6, 2020 •

edited

Loading

azure-pipelines bot commented Aug 6, 2020

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

azuresdkci commented Aug 6, 2020

markcowl commented Aug 7, 2020

azure-pipelines bot commented Aug 7, 2020

markcowl left a comment

markcowl commented Aug 18, 2020

azure-pipelines bot commented Aug 18, 2020

azure-pipelines bot commented Aug 19, 2020

openapi-sdkautomation bot commented Aug 19, 2020 •

edited

Loading

changlong-liu commented Aug 19, 2020

correct example responses #10360

correct example responses #10360

Conversation

changlong-liu commented Aug 6, 2020

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Aug 6, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Aug 6, 2020

openapi-sdkautomation bot commented Aug 6, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Aug 6, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Aug 6, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Aug 6, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Aug 6, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Aug 6, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Aug 6, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

openapi-sdkautomation bot commented Aug 6, 2020 • edited Loading

Trenton Generation - Release

azuresdkci commented Aug 6, 2020

markcowl commented Aug 7, 2020

azure-pipelines bot commented Aug 7, 2020

markcowl left a comment

Choose a reason for hiding this comment

markcowl commented Aug 18, 2020

azure-pipelines bot commented Aug 18, 2020

azure-pipelines bot commented Aug 19, 2020

openapi-sdkautomation bot commented Aug 19, 2020 • edited Loading

azure-resource-manager-schemas - Release

changlong-liu commented Aug 19, 2020

openapi-pipeline-app bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 19, 2020 •

edited

Loading