-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating ThreatIntelligence api #10463
Conversation
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
|
azure-resource-manager-schemas - Release
|
Azure CLI Extension Generation - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
Can one of the admins verify this patch? |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json
Outdated
Show resolved
Hide resolved
...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json
Outdated
Show resolved
Hide resolved
...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json
Outdated
Show resolved
Hide resolved
...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json
Outdated
Show resolved
Hide resolved
...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json
Outdated
Show resolved
Hide resolved
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous reviewers' comments remain unaddressed. I think there's also some fundamental confusion on how URLs are structured in ARM. The expectation from all ARM APIs is to have alternating "type" and "name" segments.
Consider an example VM resource ID: /subscriptions/{id}/resourceGroups/{name}/providers/Microsoft.Compute/virtualMachines/{vm}
.
The "type" segments are: subscriptions
, resourceGroups
, providers
, virtualMachines
. The "name" or "instance" segments are: {id}
, {name}
, Microsoft.Compute
, {vm}
. This rule applies to all resource types regardless whether they are tracked or proxy.
If there's a singleton resource you need, you set the name segment to default
, current
, latest
, or something similar.
I'm not comfortable approving this until these issues are addressed.
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should consider adding a GET /threatIntelligence as well even though it's a singleton, but it's not really blocking I think. Signed off from ARM side.
Azure Pipelines successfully started running 1 pipeline(s). |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.