Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ThreatIntelligence api #10463

Merged
merged 18 commits into from
Sep 3, 2020
Merged

Updating ThreatIntelligence api #10463

merged 18 commits into from
Sep 3, 2020

Conversation

Mounika-Chillamcherla
Copy link
Contributor

@Mounika-Chillamcherla Mounika-Chillamcherla commented Aug 13, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 13, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 13, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 46b9f6f with merge commit edf2fc2. SDK Automation 13.0.17.20200828.8
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-go/pull/8058: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 03 Sep 2020 06:15:24 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"0406:28D7:2D86CE4:6471EA7:5F5089FB","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4756","x-ratelimit-reset":"1599116624","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-go/git/refs/heads/sdkAutomation/preview_securityinsight_mgmt_2019-01-01-preview@10463","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/12.18.3 (Linux 5.3; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
  • ️✔️preview/securityinsight/mgmt/2019-01-01-preview [View full logs]  [Release SDK Changes]
  • ️✔️securityinsight/mgmt/v1.0 [View full logs]  [Release SDK Changes]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 46b9f6f with merge commit edf2fc2. SDK Automation 13.0.17.20200828.8
    [azure-mgmt-securityinsight][ChangeLog] WARNING: Failed to generate ChangeLog.
  • ⚠️azure-mgmt-securityinsight [View full logs]  [Release SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-securityinsight
    [build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-securityinsight
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-securityinsight
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    Not exact 2 reports found:
    Not generating changelog.
    [ChangeLog] WARNING: Failed to generate ChangeLog.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-resource-manager-schemas - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 46b9f6f with merge commit edf2fc2. Schema Automation 13.0.17.20200828.8
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-resource-manager-schemas/pull/16: HttpError: Reference does not exist, {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 03 Sep 2020 06:13:36 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; format=json","x-github-request-id":"07C5:2263:5D5C979:9A348B4:5F50898F","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4933","x-ratelimit-reset":"1599116624","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-resource-manager-schemas/git/refs/heads/sdkAutomation/securityinsights@10463","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/16.43.1 Node.js/12.18.3 (Linux 5.3; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest/reference/git#delete-a-reference"}
  • ️✔️securityinsights [View full logs]  [Release Schema Changes]
      [after_scripts|node] PostProcessor finished successfully.
      [after_scripts|node]   5641 passing (1m)
      AzureResourceSchema has no registered package commands.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 13, 2020

    Azure CLI Extension Generation - Release

    • Installation instruction for service securityinsight [Preview Changes]
      az extension add --source=https://sdkautomation.blob.core.windows.net/sdkautomation-pipeline/Azure/azure-rest-api-specs/10463/azure-cli-extensions/Azure/azure-cli-extensions/securityinsight/sentinel-0.1.0-py3-none-any.whl
    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 46b9f6f with merge commit edf2fc2. Azure CLI Automation 13.0.17.20200828.8
      [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'AwsCloudTrailDataConnectorDataTypes-logs' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-exchange' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-sharePoint' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'TIDataConnectorDataTypes-indicators' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRuleTemplatesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRulesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BookmarkList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DataConnectorList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentCommentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OfficeConsentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceWithEtag' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
      [AutoRest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'MCASDataConnectorDataTypes' has a property 'alerts' that is already declared the parent schema 'AlertsDataTypeOfDataConnector' but isn't significantly different. The property has been removed from MCASDataConnectorDataTypes
      [AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
      [AutoRest] 
      [AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
      [AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
      [AutoRest] --------------------------------------------------------
      [AutoRest]   test-scenario:
      [AutoRest]     - name: /Actions/get/Get all actions of alert rule.
      [AutoRest]     - name: /AlertRuleTemplates/get/Get alert rule template by Id.
      [AutoRest]     - name: /AlertRuleTemplates/get/Get all alert rule templates.
      [AutoRest]     - name: /AlertRules/put/Creates or updates a Fusion alert rule.
      [AutoRest]     - name: /AlertRules/put/Creates or updates a MicrosoftSecurityIncidentCreation rule.
      [AutoRest]     - name: /AlertRules/put/Creates or updates a Scheduled alert rule.
      [AutoRest]     - name: /AlertRules/put/Creates or updates an action of alert rule.
      [AutoRest]     - name: /AlertRules/get/Get a Fusion alert rule.
      [AutoRest]     - name: /AlertRules/get/Get a MicrosoftSecurityIncidentCreation rule.
      [AutoRest]     - name: /AlertRules/get/Get a Scheduled alert rule.
      [AutoRest]     - name: /AlertRules/get/Get all alert rules.
      [AutoRest]     - name: /AlertRules/get/Get an action of alert rule.
      [AutoRest]     - name: /Bookmarks/put/Creates or updates a bookmark.
      [AutoRest]     - name: /Bookmarks/get/Get a bookmark.
      [AutoRest]     - name: /Bookmarks/get/Get all bookmarks.
      [AutoRest]     - name: /DataConnectors/put/Creates or updates an Office365 data connector.
      [AutoRest]     - name: /DataConnectors/get/Get a ASC data connector.
      [AutoRest]     - name: /DataConnectors/get/Get a MCAS data connector.
      [AutoRest]     - name: /DataConnectors/get/Get a MDATP data connector
      [AutoRest]     - name: /DataConnectors/get/Get a TI data connector.
      [AutoRest]     - name: /DataConnectors/get/Get all data connectors.
      [AutoRest]     - name: /DataConnectors/get/Get an AAD data connector.
      [AutoRest]     - name: /DataConnectors/get/Get an AATP data connector.
      [AutoRest]     - name: /DataConnectors/get/Get an AwsCloudTrail data connector.
      [AutoRest]     - name: /DataConnectors/get/Get an Office365 data connector.
      [AutoRest]     - name: /IncidentComments/put/Creates an incident comment.
      [AutoRest]     - name: /IncidentComments/get/Get all incident comments.
      [AutoRest]     - name: /IncidentComments/get/Get an incident comment.
      [AutoRest]     - name: /Incidents/put/Creates or updates an incident.
      [AutoRest]     - name: /Incidents/get/Get all incidents.
      [AutoRest]     - name: /Incidents/get/Get an incident.
      [AutoRest]     - name: /AlertRules/delete/Delete an alert rule.
      [AutoRest]     - name: /AlertRules/delete/Delete an action of alert rule.
      [AutoRest]     - name: /Bookmarks/delete/Delete a bookmark.
      [AutoRest]     - name: /DataConnectors/delete/Delete an Office365 data connector.
      [AutoRest]     - name: /Incidents/delete/Delete an incident.
      [AutoRest] --------------------------------------------------------
    • ️✔️securityinsight [View full logs]  [Release Azure CLI Changes]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 13, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 13, 2020

    azure-sdk-for-js - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 46b9f6f with merge commit edf2fc2. SDK Automation 13.0.17.20200828.8
      Failed to find any diff after autorest so no changed packages was found.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 13, 2020

    azure-sdk-for-net - Release

    failed [Logs] [Expand Details]
    • Generate from 46b9f6f with merge commit edf2fc2. SDK Automation 13.0.17.20200828.8
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
    • Microsoft.Azure.Management.SecurityInsights [View full logs]  [Release SDK Changes]
        [MSBuild] A compatible installed .NET Core SDK for global.json version [3.1.301] from [/z/work/azure-sdk-for-net/global.json] was not found
        [MSBuild] Install the [3.1.301] .NET Core SDK or update [/z/work/azure-sdk-for-net/global.json] with an installed .NET Core SDK:
        Failed to create the package Microsoft.Azure.Management.SecurityInsights.
        Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=securityinsights /v:n /p:SkipTests=true A compatible installed .NET Core SDK for global.json version [3.1.301] from [/z/work/azure-sdk-for-net/global.json] was not found
        Install the [3.1.301] .NET Core SDK or update [/z/work/azure-sdk-for-net/global.json] with an installed .NET Core SDK:
        , {} 

      @azuresdkci
      Copy link
      Contributor

      Can one of the admins verify this patch?

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Aug 17, 2020

      azure-sdk-for-python-track2 - Release

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      Copy link
      Member

      @majastrz majastrz left a comment

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      The previous reviewers' comments remain unaddressed. I think there's also some fundamental confusion on how URLs are structured in ARM. The expectation from all ARM APIs is to have alternating "type" and "name" segments.

      Consider an example VM resource ID: /subscriptions/{id}/resourceGroups/{name}/providers/Microsoft.Compute/virtualMachines/{vm}.

      The "type" segments are: subscriptions, resourceGroups, providers, virtualMachines. The "name" or "instance" segments are: {id}, {name}, Microsoft.Compute, {vm}. This rule applies to all resource types regardless whether they are tracked or proxy.

      If there's a singleton resource you need, you set the name segment to default, current, latest, or something similar.

      I'm not comfortable approving this until these issues are addressed.

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      Copy link
      Member

      @majastrz majastrz left a comment

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      You should consider adding a GET /threatIntelligence as well even though it's a singleton, but it's not really blocking I think. Signed off from ARM side.

      @majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 3, 2020
      @majastrz majastrz requested a review from pilor September 3, 2020 00:19
      @pilor pilor removed their request for review September 3, 2020 02:10
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @PhoenixHe-NV PhoenixHe-NV merged commit edf2fc2 into Azure:master Sep 3, 2020
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Labels
      ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
      Projects
      None yet
      Development

      Successfully merging this pull request may close these issues.

      10 participants