-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eventhub: Added PrivateEndpointConnection API #10635
Eventhub: Added PrivateEndpointConnection API #10635
Conversation
[Staging] Swagger Validation Report
️✔️ |
Rule | Message |
---|---|
INCONSISTENT_API_VERSION |
The API version of the swagger is inconsistent with its file path. readme: specification/eventhub/resource-manager/readme.md json: resource-manager/common/v1/definitions.json |
️️✔️
ModelValidation [Detail]
️✔️
Validation passes for ModelValidation.
️️✔️
SemanticValidation [Detail]
️✔️
Validation passes for SemanticValidation.
Azure Pipelines successfully started running 1 pipeline(s). |
azure-resource-manager-schemas - Release
|
azure-sdk-for-java - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-python-track2 - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
If possible see if can be same or similar to the reference type https://github.com/Azure/azure-rest-api-specs/blob/master/specification/common-types/resource-management/v1/privatelinks.json (I know there is difference)
Azure Pipelines successfully started running 1 pipeline(s). |
…into msprivateendpoint
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed off from ARM side.
Talked with management, you can suppress LintDiff on ErrorResponse (you are not likely able to fix it in this api-version as it would cause breaking changes). If you prepare to fix the issue in next api-version, I can also ask management to force merge it for you (down-side of this is that any subsequent change also need force merge, as it triggers same LintDiff). General guideline |
@weidongxu-microsoft We will be fixing it in next API version. |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
* Added PrivateEndpointConnection API * fix * updated description * lint fix * update * update * updated examples * reverted the erorrresonse changes * testing supperssion lintdiff errorresponse * suppres lintdiff * lintdiff fixes * correted the typo in readme Co-authored-by: v-ajnava <v-ajnava@microsoft.com>
…into formrecognizer_regeneration * 'master' of https://github.com/Azure/azure-rest-api-specs: (545 commits) Changes for new api version sdk generate (Azure#10685) Update batch sdk comments (Azure#10517) Dev StreamAnalytics 2017-04-01-preview version for streaming job and 2020-03-01-preview version for dedicated cluster (Azure#10673) Bump node-fetch from 2.6.0 to 2.6.1 in /.azure-pipelines-preproduction (Azure#10762) Spark Compute Isolation enabled (Azure#10726) [Hub Generated] Review request for Microsoft.BareMetalInfrastructure to add version preview/2020-08-06-preview (Azure#10677) PostgreSQL Flexible Server New API Swagger Changes (Azure#10586) Bump node-fetch from 2.6.0 to 2.6.1 (Azure#10760) Swagger changes. Remove weekly and monthly options from replicationSchedule enum (Azure#10752) modify description of properties to be self consistent (Azure#10711) Adding ComputeInstance to preview swagger (Azure#10654) remove unsupported reversproxy and useTestExtension (Azure#10728) Dev deviceprovisioningservices microsoft.devices 2020 09 01 preview (Azure#10735) FR v2.1-preview.1 update (Azure#10747) ServiceBus : Swagger Split and Added PrivateEndPointConnection API (Azure#10071) Eventhub: Added PrivateEndpointConnection API (Azure#10635) codegen onboard df for cli (Azure#8531) Update swagger for outbound public ip feature (Azure#10713) 2020-09-01-hybrid profile for AzureStack (Azure#10295) Update pull_request_assignment.yml (Azure#10724) ...
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.