[Hub Generated] Review request for Microsoft.DigitalTwins to add version stable/2020-10-31 #10653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…20-03-01-preview to version 2020-10-31
…ttps://github.com/sjiherzig/azure-rest-api-specs into dev-digitaltwins-Microsoft.DigitalTwins-2020-10-31
…ttps://github.com/sjiherzig/azure-rest-api-specs into dev-digitaltwins-Microsoft.DigitalTwins-2020-10-31
[Staging] Swagger Validation Report
️✔️ |
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Aug 31, 2020
This was referenced Aug 31, 2020
openapi-assignment-bot
bot
added
the
WaitForARMFeedback
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Validation tools were run, but an exception occurred when running the linter in OpenApi hub: x-ms-secret was not recognized as a valid extension when checking against the schema. |
|
@sjiherzig, do you plan to release SDKs for this version after merging this PR? Please update readme.md if your answer is yes. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks! I've updated the readmes accordingly. |
|
@sjiherzig, if you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them. |
chiragg4u
added
ARMSignedOff
|
Changes looks good. Marked it as ARMSignedoff. |
|
@erich-wang What would be the next step? We're all set for merging in our changes, I think. |
|
@sjiherzig, I'm going to merge this PR, but I noticed that the API version is 2020-10-31, please let me know if this PR is ready to merge from service team perspective. |
|
@erich-wang I discussed it internally, and we are ready to merge! |
erich-wang
approved these changes
Sep 14, 2020
nitegupt
pushed a commit
to nitegupt/azure-rest-api-specs
that referenced
this pull request
Sep 25, 2020
…ion stable/2020-10-31 (Azure#10653) * Adds base for updating Microsoft.DigitalTwins from version preview/2020-03-01-preview to version 2020-10-31 * Updates readme * Updates API version in new specs and examples * Aligned descriptions with GA controller models, and regex patterns in parameters * Update nullable attribute to x-nullable * Latest updates * Add x-ms-secret = true for endpoint PUT * Latest changes * Fix reference issue * Simplify operationResults * Update required property name * Update examples * Update provisioning states * Add 200OK response to delete endpoints * Adds suppression to readme * Adds suppression to readme * Fix operation list example * Add additional provisioning state for endpoints * Remove tags from endpoint * Address internal reviewer comments * Update x-ms-secret properties to be nullable * Adds suppression to readme * Update examples with more realistic obfuscated connection strings * Adds suppression to readme * Adds suppression to readme * Adds suppression to readme * Run npm prettier on changes * Updated readmes
iscai-msft
added a commit
to iscai-msft/azure-rest-api-specs
that referenced
this pull request
Oct 14, 2020
…into formrecognizer_regeneration * 'master' of https://github.com/Azure/azure-rest-api-specs: [Hub Generated] Review request for Microsoft.DigitalTwins to add version stable/2020-10-31 (Azure#10653) [SRP] Introduce 2020-08-01-preview version. (Azure#10570) Update Readmes for Python for Automanage (Azure#10633) Incident entities (Azure#10648) Fix Billing Swagger (Azure#10276) Connected machine az cli (Azure#10640) [Azure Stack] Updates to Azs.AzureBridge.Admin spec (Azure#9035)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.