Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix operations API #10731

Conversation

mbialecka
Copy link
Contributor

@mbialecka mbialecka commented Sep 9, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 9, 2020

[Staging] Swagger Validation Report

BreakingChange: 5 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
New: Microsoft.AzureStackHCI/preview/2020-03-01-preview/azurestackhci.json#L570:9
Old: Microsoft.AzureStackHCI/preview/2020-03-01-preview/azurestackhci.json#L570:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
New: Microsoft.AzureStackHCI/preview/2020-03-01-preview/azurestackhci.json#L560:9
Old: Microsoft.AzureStackHCI/preview/2020-03-01-preview/azurestackhci.json#L559:9
1041 - AddedPropertyInResponse The new version has a new property 'isDataAction' in response that was not found in the old version.
New: Microsoft.AzureStackHCI/preview/2020-03-01-preview/azurestackhci.json#L569:7
Old: Microsoft.AzureStackHCI/preview/2020-03-01-preview/azurestackhci.json#L569:7
1041 - AddedPropertyInResponse The new version has a new property 'origin' in response that was not found in the old version.
New: Microsoft.AzureStackHCI/preview/2020-03-01-preview/azurestackhci.json#L569:7
Old: Microsoft.AzureStackHCI/preview/2020-03-01-preview/azurestackhci.json#L569:7
1041 - AddedPropertyInResponse The new version has a new property 'properties' in response that was not found in the old version.
New: Microsoft.AzureStackHCI/preview/2020-03-01-preview/azurestackhci.json#L569:7
Old: Microsoft.AzureStackHCI/preview/2020-03-01-preview/azurestackhci.json#L569:7
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 9, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 9, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from efce41d with merge commit bc52763. SDK Automation 13.0.17.20200918.2
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 9, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from efce41d with merge commit bc52763. SDK Automation 13.0.17.20200918.2
  • ️✔️@azure/arm-azurestackhci [View full logs]  [Release SDK Changes]
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/azureStackHCIClient.js → ./dist/arm-azurestackhci.js...
    [npmPack] created ./dist/arm-azurestackhci.js in 211ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/arm-azurestackhci@1.0.0
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 38.5kB dist/arm-azurestackhci.js              
    [npmPack] npm notice 13.0kB dist/arm-azurestackhci.min.js          
    [npmPack] npm notice 1.5kB  esm/azureStackHCIClient.js             
    [npmPack] npm notice 2.5kB  esm/azureStackHCIClientContext.js      
    [npmPack] npm notice 8.2kB  esm/operations/clusters.js             
    [npmPack] npm notice 601B   esm/models/clustersMappers.js          
    [npmPack] npm notice 345B   esm/models/index.js                    
    [npmPack] npm notice 409B   esm/operations/index.js                
    [npmPack] npm notice 14.9kB esm/models/mappers.js                  
    [npmPack] npm notice 1.6kB  esm/operations/operations.js           
    [npmPack] npm notice 505B   esm/models/operationsMappers.js        
    [npmPack] npm notice 1.9kB  esm/models/parameters.js               
    [npmPack] npm notice 991B   rollup.config.js                       
    [npmPack] npm notice 1.7kB  package.json                           
    [npmPack] npm notice 457B   tsconfig.json                          
    [npmPack] npm notice 83.5kB dist/arm-azurestackhci.js.map          
    [npmPack] npm notice 12.6kB dist/arm-azurestackhci.min.js.map      
    [npmPack] npm notice 648B   esm/azureStackHCIClient.d.ts.map       
    [npmPack] npm notice 742B   esm/azureStackHCIClient.js.map         
    [npmPack] npm notice 504B   esm/azureStackHCIClientContext.d.ts.map
    [npmPack] npm notice 1.4kB  esm/azureStackHCIClientContext.js.map  
    [npmPack] npm notice 3.6kB  esm/operations/clusters.d.ts.map       
    [npmPack] npm notice 5.1kB  esm/operations/clusters.js.map         
    [npmPack] npm notice 308B   esm/models/clustersMappers.d.ts.map    
    [npmPack] npm notice 321B   esm/models/clustersMappers.js.map      
    [npmPack] npm notice 5.5kB  esm/models/index.d.ts.map              
    [npmPack] npm notice 158B   esm/operations/index.d.ts.map          
    [npmPack] npm notice 126B   esm/models/index.js.map                
    [npmPack] npm notice 173B   esm/operations/index.js.map            
    [npmPack] npm notice 936B   esm/models/mappers.d.ts.map            
    [npmPack] npm notice 8.6kB  esm/models/mappers.js.map              
    [npmPack] npm notice 663B   esm/operations/operations.d.ts.map     
    [npmPack] npm notice 908B   esm/operations/operations.js.map       
    [npmPack] npm notice 241B   esm/models/operationsMappers.d.ts.map  
    [npmPack] npm notice 254B   esm/models/operationsMappers.js.map    
    [npmPack] npm notice 445B   esm/models/parameters.d.ts.map         
    [npmPack] npm notice 1.3kB  esm/models/parameters.js.map           
    [npmPack] npm notice 3.2kB  README.md                              
    [npmPack] npm notice 1.0kB  esm/azureStackHCIClient.d.ts           
    [npmPack] npm notice 1.5kB  src/azureStackHCIClient.ts             
    [npmPack] npm notice 794B   esm/azureStackHCIClientContext.d.ts    
    [npmPack] npm notice 2.3kB  src/azureStackHCIClientContext.ts      
    [npmPack] npm notice 8.8kB  esm/operations/clusters.d.ts           
    [npmPack] npm notice 16.9kB src/operations/clusters.ts             
    [npmPack] npm notice 291B   esm/models/clustersMappers.d.ts        
    [npmPack] npm notice 585B   src/models/clustersMappers.ts          
    [npmPack] npm notice 14.6kB esm/models/index.d.ts                  
    [npmPack] npm notice 93B    esm/operations/index.d.ts              
    [npmPack] npm notice 14.1kB src/models/index.ts                    
    [npmPack] npm notice 377B   src/operations/index.ts                
    [npmPack] npm notice 1.1kB  esm/models/mappers.d.ts                
    [npmPack] npm notice 11.8kB src/models/mappers.ts                  
    [npmPack] npm notice 1.1kB  esm/operations/operations.d.ts         
    [npmPack] npm notice 2.3kB  src/operations/operations.ts           
    [npmPack] npm notice 195B   esm/models/operationsMappers.d.ts      
    [npmPack] npm notice 473B   src/models/operationsMappers.ts        
    [npmPack] npm notice 480B   esm/models/parameters.d.ts             
    [npmPack] npm notice 1.8kB  src/models/parameters.ts               
    [npmPack] npm notice 1.1kB  LICENSE.txt                            
    [npmPack] npm notice === Tarball Details === 
    [npmPack] npm notice name:          @azure/arm-azurestackhci                
    [npmPack] npm notice version:       1.0.0                                   
    [npmPack] npm notice filename:      azure-arm-azurestackhci-1.0.0.tgz       
    [npmPack] npm notice package size:  40.9 kB                                 
    [npmPack] npm notice unpacked size: 299.9 kB                                
    [npmPack] npm notice shasum:        234685506d269d2e53d2a623ada7a3473323bf0f
    [npmPack] npm notice integrity:     sha512-xi2YMv/Nic3NE[...]fluL1Ag0B5xMQ==
    [npmPack] npm notice total files:   59                                      
    [npmPack] npm notice 
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 24 Sep 2020 10:27:50 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0402:0232:1D37EFF:308E672:5F6C74A6","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 9, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from efce41d with merge commit bc52763. SDK Automation 13.0.17.20200918.2
  • ️✔️preview/azurestackhci/mgmt/2020-03-01-preview [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 24 Sep 2020 10:30:44 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0401:7147:1B297DA:4607D7C:5F6C7554","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 9, 2020

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from efce41d with merge commit bc52763. SDK Automation 13.0.17.20200918.2
  • ️✔️azure-mgmt-azurestackhci [View full logs]  [Release SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-azurestackhci
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-azurestackhci
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 24 Sep 2020 10:29:48 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"07C1:47C4:EB69F5B:1196E2EB:5F6C751B","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 16.626% size of original (original: 9485 chars, delta: 1577 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model Cluster has a new parameter last_billing_timestamp
    [ChangeLog]   - Model Cluster has a new parameter registration_timestamp
    [ChangeLog]   - Model Cluster has a new parameter last_sync_timestamp

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 9, 2020

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 9, 2020

azure-resource-manager-schemas - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from efce41d with merge commit bc52763. Schema Automation 13.0.17.20200918.2
    [azurestackhci][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    [azurestackhci][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    [azurestackhci][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
  • ️✔️azurestackhci [View full logs]  [Release Schema Changes]
      [after_scripts|node] PostProcessor finished successfully.
      [after_scripts|node]   5731 passing (1m)
      AzureResourceSchema has no registered package commands.
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Thu, 24 Sep 2020 10:34:03 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0401:39AD:6EC6CB6:B60EC8C:5F6C761B","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 9, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @mbialecka
    Copy link
    Contributor Author

    I think it's a false "breaking change", as I updated "operations" operation to follow guidelines and reflect the actual state.

    @mbialecka
    Copy link
    Contributor Author

    @qianwens Can you help?

    @mbialecka
    Copy link
    Contributor Author

    @qianwens ping

    @qianwens qianwens added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 24, 2020
    @qianwens qianwens merged commit bc52763 into Azure:master Sep 24, 2020
    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Sep 24, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    nitegupt pushed a commit to nitegupt/azure-rest-api-specs that referenced this pull request Sep 25, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants