Add firewall policy premium feature properties #10780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
️✔️ |
ghost
added
the
customer-reported
|
Thank you for your contribution adgrieve! We will review the pull request and get back to you soon. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python
- Breaking Change detected in SDK
|
azure-sdk-for-net
|
azure-sdk-for-js
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go
|
This was referenced Sep 14, 2020
gersner
reviewed
Sep 15, 2020
| "$ref": "#/definitions/FirewallPolicyCertificateAuthority", | ||
| "description": "The CA used for intermediate CA generation." | ||
| }, | ||
| "excludedDomains": { |
There was a problem hiding this comment.
@adgrieve please remove, we moved Cx exclusion to P1
gersner
reviewed
Sep 15, 2020
| }, | ||
| "protocol": { | ||
| "type": "string", | ||
| "$ref": "#/definitions/FirewallPolicyIntrusionSystemBypassTrafficProtocol", |
There was a problem hiding this comment.
Should this be FirewallPolicyIntrusionSystemDetectionBypassTrafficProtocol?
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2
- Breaking Change detected in SDK
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@adgrieve, could you take a look at the model validation error? Seems in the example, there is an additional property of keyVaultSecretId. |
lirenhe
added
the
Reviewed-ChangesRequested
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@MikhailTryakhov what is the expected release date of this branch? |
|
@adgrieve, the PR looks good to me, is it ready to merge? |
lirenhe
approved these changes
Sep 21, 2020
lirenhe
pushed a commit
that referenced
this pull request
Nov 3, 2020
* Adds base for updating Microsoft.Network from version stable/2020-06-01 to version 2020-07-01 * Updates readme * Updates API version in new specs and examples * Minor fix in flowLog URI + updated examples for connection monitor (#10524) * Minor fix in flowLog URI + updated examples for connection monitor * Reseted the change in networkWtacher spec, updated examples * fix * Update LB and PIP with new global load balancing properties (#10529) * updading LB and PIP with new properties necessary for global loadbalancing as well as new appropriate examples * Ran prettier and fixed syntax in loadbalancer.json * added 07/01 tags to python readme * Adding express route port authorization apis (#10491) * Adding express route port authorization apis * adding left out changes for prev commit * adding left out changes for prev commit * removing name as its handled by upper class * fixing model validation * making port auth key read only * making enum unique * making authorizations child resource only * part of last commit * fixing last commit * fixing last commit * removing child resource authorizations from parent port request and response * update link context to type dictionary (#10624) * [Merge from master] Add InboundSecurityRule, virtualRouterPeerAdvertisedRoute and virtualRouterPeerLearnedRoute (#10736) * Add virtual hub bgp connections subresources virtualRouterPeerAdvertisedRoute and virtualRouterPeerLearnedRoute with POST opertion * Add examples * Change name of operationid * change output of advertised route * Add PUT InboundSecurityRules for NVA * merge * Add examples * merge * merge * change output of advertised route * Add type "Local gateway" to virtualNetworkGateway (#10802) * Add virtual hub bgp connections subresources virtualRouterPeerAdvertisedRoute and virtualRouterPeerLearnedRoute with POST opertion * Add examples * Change name of operationid * change output of advertised route * Add PUT InboundSecurityRules for NVA * merge * Add examples * merge * merge * change output of advertised route * Add type local to virtualNetworkGateway * fix bug * fix bug * fix typo * fix bug and add requirements * Add Enum * fix bug * Added Sku Tier property to public ip address prefix (#10831) * Removed object from nat gateway create or update response july release (#10834) * Removed object from NatGateway CreateOrUpdate Response * fixed syntax * Removing response body from example * ran prettier * Add firewall policy premium feature properties (#10780) * Add firewall policy premium feature properties * CR * add examples * Add transportSecurity examples * remove redundant class * fix examples * Added format to integers (#10912) * Added format to integers * Updated 07-01 networkWatcher swagger with formats for integer properties * Revert "Added format to integers" This reverts commit 6588b61. * Add expressRouteGatewayBypass for enabling FastPath to vWan Firewall hub (#10963) * Add expressRouteGatewayBypass flag for enabling FastPath to vWan Firewall * Updated the target version to July release Co-authored-by: Sachet Hegde <sahegd@microsoft.com> * Add translatedFqdn field for Policy Nat Rule (#11012) * Add Firewall Policy sku tier (#10929) * Add firewall policy premium feature properties * CR * add examples * Add transportSecurity examples * remove redundant class * fix examples * Add firewall policy sku tier * fix validation * added extended location to 5 entities. (#11000) * added extended location to 5 entities. * Added period. Co-authored-by: Mirza Sikander <mirsik@microsoft.com> * Added 'migrate' query parameter in PutConnectionMonitor (#10980) * Update ipGroup swagger to include firewallPolicies (#11051) * fix ipGroup swagger to include firewallPolicies * Prettier * Change transit flag for VR from enableVirtualRouterRoutePropogation to allowBranchToBranchTraffic (#11015) * Add InboundSecurityRule, virtualRouterPeerAdvertisedRoute and virtualRouterPeerLearnedRoute (#11185) * Add virtual hub bgp connections subresources virtualRouterPeerAdvertisedRoute and virtualRouterPeerLearnedRoute with POST opertion * Add examples * Change name of operationid * change output of advertised route * Add PUT InboundSecurityRules for NVA * merge * Add examples * merge * merge * change output of advertised route * Add type local to virtualNetworkGateway * fix bug * fix bug * fix typo * fix bug and add requirements * Add Enum * fix bug * Add InboundSecurityRule, virtualRouterPeerAdvertisedRoute and virtualRouterPeerLearnedRoute * prettier * Adding Route Preference property into VpnGateway and P2SGateway (#11119) * commit1 * Fixes Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * FirewallPolicy Application Rule with WebCategories (#11049) * FirewallPolicy Application Rule with WebCategories * azureWebCategories * validated models/examples * fix json * Remove redundant files * prettier * Fix PR comments * Fixed file name * Fixing error * Spell Check fix * Changed operationId/Tags * "x-ms-azure-resource": true * Revert ""x-ms-azure-resource": true" This reverts commit e360800. * Network july release - Feature: Address space update in peered vNets (#11090) * Adding new fields in PutvNetPeering to support address space update in peered vNets Added the new fields and the examples to support the address space update in peered vNets. * Fixing spell checks * Update custom-words.txt * Adding the feature to sync the address space on peering * Using the new example file added * Reverting the new file as it's mot working * Fixing a prettier error Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com> * Support for Default/Initiator/Responder Connection Mode for Virtual Network Gateway Connections (#11201) * Initiator/Reponder Connection Mode Support * Prettier Fix Co-authored-by: Abhishek Shah <shabhis@microsoft.com> * Add type "Local gateway" to virtualNetworkGateway to 2020-07-01 (#11231) * Add virtual hub bgp connections subresources virtualRouterPeerAdvertisedRoute and virtualRouterPeerLearnedRoute with POST opertion * Add examples * Change name of operationid * change output of advertised route * Add PUT InboundSecurityRules for NVA * merge * Add examples * merge * merge * change output of advertised route * Add type local to virtualNetworkGateway * fix bug * fix bug * fix typo * fix bug and add requirements * Add Enum * fix bug * Add InboundSecurityRule, virtualRouterPeerAdvertisedRoute and virtualRouterPeerLearnedRoute * prettier * Add to 0701 * Update virtualNetworkGateway.json Change description to match others * Revert "Update virtualNetworkGateway.json" This reverts commit a4b72d4. * Change description * change names * change name to match * match * change definition * change reference * change ref * delete from 0601 * Removed ReadOnly from extendedLocation for virtual network gateway (#11274) * Add virtual hub bgp connections subresources virtualRouterPeerAdvertisedRoute and virtualRouterPeerLearnedRoute with POST opertion * Add examples * Change name of operationid * change output of advertised route * Add PUT InboundSecurityRules for NVA * merge * Add examples * merge * merge * change output of advertised route * Add type local to virtualNetworkGateway * fix bug * fix bug * fix typo * fix bug and add requirements * Add Enum * fix bug * Add InboundSecurityRule, virtualRouterPeerAdvertisedRoute and virtualRouterPeerLearnedRoute * prettier * Add to 0701 * Update virtualNetworkGateway.json Change description to match others * Revert "Update virtualNetworkGateway.json" This reverts commit a4b72d4. * Change description * change names * change name to match * match * change definition * change reference * change ref * delete from 0601 * Delete read only from extended location * merge from azure * Revert "merge from azure" This reverts commit fbdf7d6. * adding nextLink property to Service Tag definition (#11177) * adding nextLink property to Service Tag definition * updated value of nextLink example for service tag * Revert "Adding express route port authorization apis (#10491)" (#10944) This reverts commit 29a80fe. Co-authored-by: utbarn <66377251+utbarn@users.noreply.github.com> * {VirtualWan} {HubRouteTables} : Fix parameter type in network-july-release branch (#11280) * update 2020-07-01 folder also * fix the type of the parameter * update one more missed fix * updated examples (#11406) * Connection Mode type fix (#11470) Co-authored-by: Abhishek Shah <shabhis@microsoft.com> * Fixed pythod.md file Co-authored-by: irrogozh <irrogozh@microsoft.com> Co-authored-by: Kayden Wilkinson <69224099+Kawilki-M@users.noreply.github.com> Co-authored-by: utbarn <66377251+utbarn@users.noreply.github.com> Co-authored-by: junyezhu <38572086+junyezhu@users.noreply.github.com> Co-authored-by: litchiyangMSFT <64560090+litchiyangMSFT@users.noreply.github.com> Co-authored-by: adgrieve <62692874+adgrieve@users.noreply.github.com> Co-authored-by: Sachet Hegde <hegde.sachet@gmail.com> Co-authored-by: Sachet Hegde <sahegd@microsoft.com> Co-authored-by: tejasshah7 <49326906+tejasshah7@users.noreply.github.com> Co-authored-by: Mirza Sikander <mirza.h.sikander@gmail.com> Co-authored-by: Mirza Sikander <mirsik@microsoft.com> Co-authored-by: ssripadham <sudharsan_sb@hotmail.com> Co-authored-by: naveenchekuri <nachekur@microsoft.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com> Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com> Co-authored-by: Abhishek Shah <shah.abhi7860@gmail.com> Co-authored-by: Abhishek Shah <shabhis@microsoft.com> Co-authored-by: guptas14 <71726901+guptas14@users.noreply.github.com> Co-authored-by: utbarn-ms <66377251+utbarn-ms@users.noreply.github.com> Co-authored-by: Ritvika Reddy Nagula <rinagula@microsoft.com> Co-authored-by: Ritvika Reddy Nagula <ritvikareddy18@gmail.com>
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
* Adds base for updating Microsoft.Network from version stable/2020-06-01 to version 2020-07-01 * Updates readme * Updates API version in new specs and examples * Minor fix in flowLog URI + updated examples for connection monitor (Azure#10524) * Minor fix in flowLog URI + updated examples for connection monitor * Reseted the change in networkWtacher spec, updated examples * fix * Update LB and PIP with new global load balancing properties (Azure#10529) * updading LB and PIP with new properties necessary for global loadbalancing as well as new appropriate examples * Ran prettier and fixed syntax in loadbalancer.json * added 07/01 tags to python readme * Adding express route port authorization apis (Azure#10491) * Adding express route port authorization apis * adding left out changes for prev commit * adding left out changes for prev commit * removing name as its handled by upper class * fixing model validation * making port auth key read only * making enum unique * making authorizations child resource only * part of last commit * fixing last commit * fixing last commit * removing child resource authorizations from parent port request and response * update link context to type dictionary (Azure#10624) * [Merge from master] Add InboundSecurityRule, virtualRouterPeerAdvertisedRoute and virtualRouterPeerLearnedRoute (Azure#10736) * Add virtual hub bgp connections subresources virtualRouterPeerAdvertisedRoute and virtualRouterPeerLearnedRoute with POST opertion * Add examples * Change name of operationid * change output of advertised route * Add PUT InboundSecurityRules for NVA * merge * Add examples * merge * merge * change output of advertised route * Add type "Local gateway" to virtualNetworkGateway (Azure#10802) * Add virtual hub bgp connections subresources virtualRouterPeerAdvertisedRoute and virtualRouterPeerLearnedRoute with POST opertion * Add examples * Change name of operationid * change output of advertised route * Add PUT InboundSecurityRules for NVA * merge * Add examples * merge * merge * change output of advertised route * Add type local to virtualNetworkGateway * fix bug * fix bug * fix typo * fix bug and add requirements * Add Enum * fix bug * Added Sku Tier property to public ip address prefix (Azure#10831) * Removed object from nat gateway create or update response july release (Azure#10834) * Removed object from NatGateway CreateOrUpdate Response * fixed syntax * Removing response body from example * ran prettier * Add firewall policy premium feature properties (Azure#10780) * Add firewall policy premium feature properties * CR * add examples * Add transportSecurity examples * remove redundant class * fix examples * Added format to integers (Azure#10912) * Added format to integers * Updated 07-01 networkWatcher swagger with formats for integer properties * Revert "Added format to integers" This reverts commit 6588b61. * Add expressRouteGatewayBypass for enabling FastPath to vWan Firewall hub (Azure#10963) * Add expressRouteGatewayBypass flag for enabling FastPath to vWan Firewall * Updated the target version to July release Co-authored-by: Sachet Hegde <sahegd@microsoft.com> * Add translatedFqdn field for Policy Nat Rule (Azure#11012) * Add Firewall Policy sku tier (Azure#10929) * Add firewall policy premium feature properties * CR * add examples * Add transportSecurity examples * remove redundant class * fix examples * Add firewall policy sku tier * fix validation * added extended location to 5 entities. (Azure#11000) * added extended location to 5 entities. * Added period. Co-authored-by: Mirza Sikander <mirsik@microsoft.com> * Added 'migrate' query parameter in PutConnectionMonitor (Azure#10980) * Update ipGroup swagger to include firewallPolicies (Azure#11051) * fix ipGroup swagger to include firewallPolicies * Prettier * Change transit flag for VR from enableVirtualRouterRoutePropogation to allowBranchToBranchTraffic (Azure#11015) * Add InboundSecurityRule, virtualRouterPeerAdvertisedRoute and virtualRouterPeerLearnedRoute (Azure#11185) * Add virtual hub bgp connections subresources virtualRouterPeerAdvertisedRoute and virtualRouterPeerLearnedRoute with POST opertion * Add examples * Change name of operationid * change output of advertised route * Add PUT InboundSecurityRules for NVA * merge * Add examples * merge * merge * change output of advertised route * Add type local to virtualNetworkGateway * fix bug * fix bug * fix typo * fix bug and add requirements * Add Enum * fix bug * Add InboundSecurityRule, virtualRouterPeerAdvertisedRoute and virtualRouterPeerLearnedRoute * prettier * Adding Route Preference property into VpnGateway and P2SGateway (Azure#11119) * commit1 * Fixes Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * FirewallPolicy Application Rule with WebCategories (Azure#11049) * FirewallPolicy Application Rule with WebCategories * azureWebCategories * validated models/examples * fix json * Remove redundant files * prettier * Fix PR comments * Fixed file name * Fixing error * Spell Check fix * Changed operationId/Tags * "x-ms-azure-resource": true * Revert ""x-ms-azure-resource": true" This reverts commit e360800. * Network july release - Feature: Address space update in peered vNets (Azure#11090) * Adding new fields in PutvNetPeering to support address space update in peered vNets Added the new fields and the examples to support the address space update in peered vNets. * Fixing spell checks * Update custom-words.txt * Adding the feature to sync the address space on peering * Using the new example file added * Reverting the new file as it's mot working * Fixing a prettier error Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com> * Support for Default/Initiator/Responder Connection Mode for Virtual Network Gateway Connections (Azure#11201) * Initiator/Reponder Connection Mode Support * Prettier Fix Co-authored-by: Abhishek Shah <shabhis@microsoft.com> * Add type "Local gateway" to virtualNetworkGateway to 2020-07-01 (Azure#11231) * Add virtual hub bgp connections subresources virtualRouterPeerAdvertisedRoute and virtualRouterPeerLearnedRoute with POST opertion * Add examples * Change name of operationid * change output of advertised route * Add PUT InboundSecurityRules for NVA * merge * Add examples * merge * merge * change output of advertised route * Add type local to virtualNetworkGateway * fix bug * fix bug * fix typo * fix bug and add requirements * Add Enum * fix bug * Add InboundSecurityRule, virtualRouterPeerAdvertisedRoute and virtualRouterPeerLearnedRoute * prettier * Add to 0701 * Update virtualNetworkGateway.json Change description to match others * Revert "Update virtualNetworkGateway.json" This reverts commit a4b72d4. * Change description * change names * change name to match * match * change definition * change reference * change ref * delete from 0601 * Removed ReadOnly from extendedLocation for virtual network gateway (Azure#11274) * Add virtual hub bgp connections subresources virtualRouterPeerAdvertisedRoute and virtualRouterPeerLearnedRoute with POST opertion * Add examples * Change name of operationid * change output of advertised route * Add PUT InboundSecurityRules for NVA * merge * Add examples * merge * merge * change output of advertised route * Add type local to virtualNetworkGateway * fix bug * fix bug * fix typo * fix bug and add requirements * Add Enum * fix bug * Add InboundSecurityRule, virtualRouterPeerAdvertisedRoute and virtualRouterPeerLearnedRoute * prettier * Add to 0701 * Update virtualNetworkGateway.json Change description to match others * Revert "Update virtualNetworkGateway.json" This reverts commit a4b72d4. * Change description * change names * change name to match * match * change definition * change reference * change ref * delete from 0601 * Delete read only from extended location * merge from azure * Revert "merge from azure" This reverts commit fbdf7d6. * adding nextLink property to Service Tag definition (Azure#11177) * adding nextLink property to Service Tag definition * updated value of nextLink example for service tag * Revert "Adding express route port authorization apis (Azure#10491)" (Azure#10944) This reverts commit 29a80fe. Co-authored-by: utbarn <66377251+utbarn@users.noreply.github.com> * {VirtualWan} {HubRouteTables} : Fix parameter type in network-july-release branch (Azure#11280) * update 2020-07-01 folder also * fix the type of the parameter * update one more missed fix * updated examples (Azure#11406) * Connection Mode type fix (Azure#11470) Co-authored-by: Abhishek Shah <shabhis@microsoft.com> * Fixed pythod.md file Co-authored-by: irrogozh <irrogozh@microsoft.com> Co-authored-by: Kayden Wilkinson <69224099+Kawilki-M@users.noreply.github.com> Co-authored-by: utbarn <66377251+utbarn@users.noreply.github.com> Co-authored-by: junyezhu <38572086+junyezhu@users.noreply.github.com> Co-authored-by: litchiyangMSFT <64560090+litchiyangMSFT@users.noreply.github.com> Co-authored-by: adgrieve <62692874+adgrieve@users.noreply.github.com> Co-authored-by: Sachet Hegde <hegde.sachet@gmail.com> Co-authored-by: Sachet Hegde <sahegd@microsoft.com> Co-authored-by: tejasshah7 <49326906+tejasshah7@users.noreply.github.com> Co-authored-by: Mirza Sikander <mirza.h.sikander@gmail.com> Co-authored-by: Mirza Sikander <mirsik@microsoft.com> Co-authored-by: ssripadham <sudharsan_sb@hotmail.com> Co-authored-by: naveenchekuri <nachekur@microsoft.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com> Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com> Co-authored-by: Abhishek Shah <shah.abhi7860@gmail.com> Co-authored-by: Abhishek Shah <shabhis@microsoft.com> Co-authored-by: guptas14 <71726901+guptas14@users.noreply.github.com> Co-authored-by: utbarn-ms <66377251+utbarn-ms@users.noreply.github.com> Co-authored-by: Ritvika Reddy Nagula <rinagula@microsoft.com> Co-authored-by: Ritvika Reddy Nagula <ritvikareddy18@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.