Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FRv2.1-preview.2 update #10805

Merged
merged 32 commits into from
Jan 12, 2021
Merged

FRv2.1-preview.2 update #10805

merged 32 commits into from
Jan 12, 2021

Conversation

ramparab
Copy link
Contributor

@ramparab ramparab commented Sep 16, 2020

FRv2.1-preview.2 update

  • Adding new [pre-built] Invoice API
  • Adding support for image/bmp content-type for /analyze APIs (except custom/analyze)
  • Adding support for query parameter: pages to /layout/analyze API
  • Adding support for bounding box for tables
  • Adding support for text line appearance (handwritten)

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 16, 2020

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️LintDiff: 4 Warnings warning [Detail]

Rule Message
⚠️ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options. Property name: state
New: FormRecognizer/preview/v2.1-preview.2/FormRecognizer.json#L1785
⚠️ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options. Property name: valueSelectionMark
New: FormRecognizer/preview/v2.1-preview.2/FormRecognizer.json#L1998
⚠️ R3017 - GuidUsage Guid used in model definition 'TrainResult' for property 'modelId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
New: FormRecognizer/preview/v2.1-preview.2/FormRecognizer.json#L1174
⚠️ R3017 - GuidUsage Guid used in model definition 'DocumentResult' for property 'modelId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
New: FormRecognizer/preview/v2.1-preview.2/FormRecognizer.json#L1913
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 16, 2020

Azure CLI Extension Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 16, 2020

azure-sdk-for-java

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 97ae149 with merge commit 8b9de7eb0d19172f2a4e80f86305d8d82e210e11. SDK Automation 13.0.17.20200918.2
    Failed to find any changed packages. Please check the changed file list.
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/FormRecognizerClient.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/implementation/FormRecognizerClientImpl.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/implementation/package-info.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/AnalyzeLayoutAsyncHeaders.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/AnalyzeOperationResult.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/AnalyzeReceiptAsyncHeaders.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/AnalyzeResult.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/AnalyzeWithCustomModelHeaders.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/CopyAuthorizationResult.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/CopyCustomModelHeaders.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/CopyOperationResult.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/CopyRequest.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/CopyResult.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/DataTable.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/DataTableCell.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/DocumentResult.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/ErrorInformation.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/ErrorResponse.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/ErrorResponseException.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/FieldValue.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/FieldValueType.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/FormFieldsReport.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/GenerateModelCopyAuthorizationHeaders.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/KeyValueElement.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/KeyValuePair.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/KeysResult.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/Language.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/LengthUnit.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/Model.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/ModelInfo.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/ModelStatus.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/ModelsModel.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/ModelsSummary.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/OperationStatus.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/PageImpl.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/PageResult.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/ReadResult.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/SourcePath.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/TextLine.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/TextWord.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/TrainCustomModelAsyncHeaders.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/TrainRequest.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/TrainResult.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/TrainSourceFilter.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/TrainStatus.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/TrainingDocumentInfo.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/models/package-info.java
    /z/work/azure-sdk-for-java/cognitiveservices/data-plane/vision/formrecognizer/src/main/java/com/microsoft/azure/cognitiveservices/formrecognizer/package-info.java

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 16, 2020

azure-sdk-for-net

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 16, 2020

azure-sdk-for-go

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 16, 2020

azure-resource-manager-schemas

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 16, 2020

azure-sdk-for-python

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 97ae149 with merge commit 8b9de7eb0d19172f2a4e80f86305d8d82e210e11. SDK Automation 13.0.17.20200918.2
  • ️✔️azure-cognitiveservices-formrecognizer [View full logs]  [Preview SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-cognitiveservices-formrecognizer
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-cognitiveservices-formrecognizer
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Traceback (most recent call last):
    [ChangeLog]   File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    [ChangeLog]     "__main__", mod_spec)
    [ChangeLog]   File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
    [ChangeLog]     exec(code, run_globals)
    [ChangeLog]   File "/z/work/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/change_log.py", line 200, in 
    [ChangeLog]     change_log = build_change_log(old_report, new_report)
    [ChangeLog]   File "/z/work/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/change_log.py", line 147, in build_change_log
    [ChangeLog]     change_log.operation(diff_line)
    [ChangeLog]   File "/z/work/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/change_log.py", line 38, in operation
    [ChangeLog]     _, operation_name, *remaining_path = path
    [ChangeLog] ValueError: not enough values to unpack (expected at least 2, got 1)
    [ChangeLog] Size of delta 99.536% size of original (original: 15955 chars, delta: 15881 chars)

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 16, 2020

azure-sdk-for-js

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 16, 2020

azure-sdk-for-python-track2

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 16, 2020

Trenton Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maririos
Copy link
Member

@ramparab do you have an ETA of when this PR is going to be merged?

}
}
},
"Language": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems Japanese ("ja") should be included for this preview: https://docs.microsoft.com/en-us/azure/cognitive-services/form-recognizer/language-support

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this. @ramparab can you please fix this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramparab I think this is the last thing to be resolved before this PR can be approved and merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@maririos
Copy link
Member

maririos commented Dec 2, 2020

@ramparab now that the service finished the deployment of 2.1-preview.2 and the SDKs are out too, do you have an ETA of when this PR is going to be ready and merged?
I ask because in the SDKs we have a local copy of it, but our guidance is to point our SDKs to the swagger in this repo to maintain only one source of truth

@lmazuel lmazuel assigned kristapratico and unassigned lmazuel Dec 12, 2020
@ghost
Copy link

ghost commented Dec 27, 2020

Hi, @ramparab. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants