Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.DigitalTwins to add version stable/2020-12-01 #10996

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
2f4e352
Adds base for updating Microsoft.DigitalTwins from version stable/202…
sjiherzig Sep 29, 2020
dedbd0d
Updates readme
sjiherzig Sep 29, 2020
433dbe6
Updates API version in new specs and examples
sjiherzig Sep 29, 2020
e54e392
Update swagger spec
sjiherzig Sep 29, 2020
313db7e
Modify SDK build configs
sjiherzig Sep 29, 2020
16b23cd
Fix example filename reference
sjiherzig Sep 29, 2020
8d7e4f6
Rename example file
sjiherzig Sep 29, 2020
ca2997d
Fix validation errors
sjiherzig Sep 29, 2020
56402dc
Updated examples
sjiherzig Sep 29, 2020
4fbe23e
Revert change to behavior of async op
sjiherzig Sep 29, 2020
6c55850
Modify discriminators
sjiherzig Sep 30, 2020
a00e5e7
Enable two discriminators
sjiherzig Sep 30, 2020
0b941df
Fix delete endpoint example
sjiherzig Sep 30, 2020
fe04d04
Attempted fix with discriminator
sjiherzig Sep 30, 2020
a05d78c
Added westus2, change discriminator enum type name
sjiherzig Oct 1, 2020
abfc788
Decouple allOf from properties
sjiherzig Oct 1, 2020
ab777fb
Bugfixes
sjiherzig Oct 1, 2020
4074d14
Modify response to fix validation errors
sjiherzig Oct 6, 2020
8e82828
Fix examples
sjiherzig Oct 6, 2020
41acb42
Change private link type names to be smaller
sjiherzig Oct 7, 2020
386c64d
Fix validation errors in private links
sjiherzig Oct 8, 2020
f2bb31b
Fix validation error related to private links
sjiherzig Oct 9, 2020
c02fac7
Reference private link example
sjiherzig Oct 9, 2020
b7aeb1e
Add public network access
sjiherzig Oct 15, 2020
26a4784
Align with GA swagger
sjiherzig Oct 15, 2020
779b8e6
Update private links / private endpoints
sjiherzig Nov 3, 2020
04afddd
Fix example to use actual response status code
sjiherzig Nov 3, 2020
e1f157b
Remove unused example
sjiherzig Nov 3, 2020
ff45c62
Unmark private endpoint connection to be an azure resource
sjiherzig Nov 3, 2020
5cbf616
Add type and name to private endpoint connection resource
sjiherzig Nov 3, 2020
b4d6713
Mark id as read-only
sjiherzig Nov 3, 2020
b36a43a
Fix return types for endpoint connections
sjiherzig Nov 3, 2020
8897475
Align return of DELETE
sjiherzig Nov 3, 2020
198c463
Fix validation errors
sjiherzig Nov 3, 2020
bc9c8d5
Fix version tag in python.md; remove body from DELETE endpoint connec…
sjiherzig Nov 4, 2020
949c548
Synchronize swagger with 2020-10-31 version
sjiherzig Nov 4, 2020
06cfc0b
Increase resource group name max length to 90 characters
sjiherzig Nov 5, 2020
e2d1430
Make publicNetworkAccess nullable
sjiherzig Nov 9, 2020
c593315
Add publicNetworkAccess flag to PATCH request
sjiherzig Nov 10, 2020
2fd20ba
Fixed typo
sjiherzig Nov 10, 2020
8e5f099
Fix placing of example for endpoints
sjiherzig Nov 10, 2020
043fe70
Update operation ids
sjiherzig Nov 11, 2020
416d57a
Added suppression message
sjiherzig Dec 14, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"parameters": {
"subscriptionId": "50016170-c839-41ba-a724-51e9df440b9e",
"location": "WestUS2",
"api-version": "2020-12-01",
"digitalTwinsInstanceCheckName": {
"name": "myadtinstance",
"type": "Microsoft.DigitalTwins/digitalTwinsInstances"
}
},
"responses": {
"200": {
"body": {
"nameAvailable": false,
"message": "Name 'myadtinstance' is already taken. Please specify a different name",
"reason": "AlreadyExists"
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
{
"parameters": {
"subscriptionId": "50016170-c839-41ba-a724-51e9df440b9e",
"resourceGroupName": "resRg",
"resourceName": "myDigitalTwinsService",
"api-version": "2020-12-01"
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/50016170-c839-41ba-a724-51e9df440b9e/resourcegroups/resRg/providers/Microsoft.DigitalTwins/digitalTwinsInstances/myDigitalTwinsService",
"location": "westus2",
"type": "Microsoft.DigitalTwins/digitalTwinsInstances",
"name": "myDigitalTwinsService",
"identity": {
"type": "SystemAssigned",
"principalId": "544215a9-21d8-4fb5-8094-8efbcc311dd0",
"tenantId": "544215a9-21d8-4fb5-8094-8efbcc311dd0"
},
"properties": {
"createdTime": "2019-11-19T12:55:05.229Z",
"lastUpdatedTime": "2019-12-06T12:21:58.610Z",
"provisioningState": "Failed",
"hostName": "https://myDigitalTwinsService.api.wus2.ss.azuredigitaltwins-test.net"
}
}
},
"202": {
"body": {
"id": "/subscriptions/50016170-c839-41ba-a724-51e9df440b9e/resourcegroups/resRg/providers/Microsoft.DigitalTwins/digitalTwinsInstances/myDigitalTwinsService",
"location": "westus2",
"type": "Microsoft.DigitalTwins/digitalTwinsInstances",
"name": "myDigitalTwinsService",
"identity": {
"type": "SystemAssigned",
"principalId": "544215a9-21d8-4fb5-8094-8efbcc311dd0",
"tenantId": "544215a9-21d8-4fb5-8094-8efbcc311dd0"
},
"properties": {
"createdTime": "2019-11-19T12:55:05.229Z",
"lastUpdatedTime": "2019-12-06T12:21:58.610Z",
"provisioningState": "Deleting",
"hostName": "https://myDigitalTwinsService.api.wus2.ss.azuredigitaltwins-test.net"
}
}
},
"204": {}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
{
"parameters": {
"subscriptionId": "50016170-c839-41ba-a724-51e9df440b9e",
"resourceGroupName": "resRg",
"resourceName": "myDigitalTwinsService",
"api-version": "2020-12-01"
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/50016170-c839-41ba-a724-51e9df440b9e/resourcegroups/resRg/providers/Microsoft.DigitalTwins/digitalTwinsInstances/myDigitalTwinsService",
"location": "westus2",
"type": "Microsoft.DigitalTwins/digitalTwinsInstances",
"name": "myDigitalTwinsService",
"properties": {
"createdTime": "2019-11-19T12:55:05.229Z",
"lastUpdatedTime": "2019-12-06T12:21:58.610Z",
"provisioningState": "Failed",
"hostName": "https://myDigitalTwinsService.api.wus2.ss.azuredigitaltwins-test.net"
}
}
},
"202": {
"body": {
"id": "/subscriptions/50016170-c839-41ba-a724-51e9df440b9e/resourcegroups/resRg/providers/Microsoft.DigitalTwins/digitalTwinsInstances/myDigitalTwinsService",
"location": "westus2",
"type": "Microsoft.DigitalTwins/digitalTwinsInstances",
"name": "myDigitalTwinsService",
"properties": {
"createdTime": "2019-11-19T12:55:05.229Z",
"lastUpdatedTime": "2019-12-06T12:21:58.610Z",
"provisioningState": "Deleting",
"hostName": "https://myDigitalTwinsService.api.wus2.ss.azuredigitaltwins-test.net"
}
}
},
"204": {}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
{
"parameters": {
"subscriptionId": "50016170-c839-41ba-a724-51e9df440b9e",
"resourceGroupName": "resRg",
"resourceName": "myDigitalTwinsService",
"endpointName": "myendpoint",
"api-version": "2020-12-01"
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/50016170-c839-41ba-a724-51e9df440b9e/resourcegroups/resRg/providers/Microsoft.DigitalTwins/digitalTwinsInstances/myDigitalTwinsService/endpoints/myServiceBus",
"type": "Microsoft.DigitalTwins/digitalTwinsInstances/endpoints",
"name": "myendpoint",
"properties": {
"endpointType": "ServiceBus",
"authenticationType": "KeyBased",
"provisioningState": "Failed",
"endpointUri": "sb://mysb.servicebus.windows.net/",
"entityPath": "mysbtopic",
"createdTime": "2019-11-19T01:10:34.350Z"
}
}
},
"202": {
"body": {
"id": "/subscriptions/50016170-c839-41ba-a724-51e9df440b9e/resourcegroups/resRg/providers/Microsoft.DigitalTwins/digitalTwinsInstances/myDigitalTwinsService/endpoints/myServiceBus",
"type": "Microsoft.DigitalTwins/digitalTwinsInstances/endpoints",
"name": "myendpoint",
"properties": {
"endpointType": "ServiceBus",
"authenticationType": "IdentityBased",
"provisioningState": "Deleting",
"endpointUri": "sb://mysb.servicebus.windows.net/",
"entityPath": "mysbtopic",
"createdTime": "2019-11-19T01:10:34.350Z"
}
}
},
"204": {}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
{
"parameters": {
"subscriptionId": "50016170-c839-41ba-a724-51e9df440b9e",
"resourceGroupName": "resRg",
"resourceName": "myDigitalTwinsService",
"endpointName": "myendpoint",
"api-version": "2020-12-01"
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/50016170-c839-41ba-a724-51e9df440b9e/resourcegroups/resRg/providers/Microsoft.DigitalTwins/digitalTwinsInstances/myDigitalTwinsService/endpoints/myServiceBus",
"type": "Microsoft.DigitalTwins/digitalTwinsInstances/endpoints",
"name": "myendpoint",
"properties": {
"authenticationType": "KeyBased",
"endpointType": "ServiceBus",
"provisioningState": "Failed",
"primaryConnectionString": "Endpoint=sb://***/;SharedAccessKeyName=***;SharedAccessKey=***;EntityPath=***",
"secondaryConnectionString": "Endpoint=sb://***/;SharedAccessKeyName=***;SharedAccessKey=***;EntityPath=***",
"createdTime": "2019-11-19T01:10:34.350Z"
}
}
},
"202": {
"body": {
"id": "/subscriptions/50016170-c839-41ba-a724-51e9df440b9e/resourcegroups/resRg/providers/Microsoft.DigitalTwins/digitalTwinsInstances/myDigitalTwinsService/endpoints/myServiceBus",
"type": "Microsoft.DigitalTwins/digitalTwinsInstances/endpoints",
"name": "myendpoint",
"properties": {
"authenticationType": "KeyBased",
"endpointType": "ServiceBus",
"provisioningState": "Deleting",
"primaryConnectionString": "Endpoint=sb://***/;SharedAccessKeyName=***;SharedAccessKey=***;EntityPath=***",
"secondaryConnectionString": "Endpoint=sb://***/;SharedAccessKeyName=***;SharedAccessKey=***;EntityPath=***",
"createdTime": "2019-11-19T01:10:34.350Z"
}
}
},
"204": {}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{
"parameters": {
"subscriptionId": "50016170-c839-41ba-a724-51e9df440b9e",
"resourceGroupName": "resRg",
"resourceName": "myDigitalTwinsService",
"endpointName": "myServiceBus",
"api-version": "2020-12-01"
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/50016170-c839-41ba-a724-51e9df440b9e/resourcegroups/resRg/providers/Microsoft.DigitalTwins/digitalTwinsInstances/myDigitalTwinsService/endpoints/myServiceBus",
"type": "Microsoft.DigitalTwins/digitalTwinsInstances/endpoints",
"name": "myServiceBus",
"properties": {
"endpointType": "ServiceBus",
"authenticationType": "IdentityBased",
"provisioningState": "Succeeded",
"endpointUri": "sb://mysb.servicebus.windows.net/",
"entityPath": "mysbtopic",
"createdTime": "2019-11-19T01:10:34.350Z"
}
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{
"parameters": {
"subscriptionId": "50016170-c839-41ba-a724-51e9df440b9e",
"resourceGroupName": "resRg",
"resourceName": "myDigitalTwinsService",
"endpointName": "myServiceBus",
"api-version": "2020-12-01"
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/50016170-c839-41ba-a724-51e9df440b9e/resourcegroups/resRg/providers/Microsoft.DigitalTwins/digitalTwinsInstances/myDigitalTwinsService/endpoints/myServiceBus",
"type": "Microsoft.DigitalTwins/digitalTwinsInstances/endpoints",
"name": "myServiceBus",
"properties": {
"endpointType": "ServiceBus",
"authenticationType": "KeyBased",
"provisioningState": "Succeeded",
"primaryConnectionString": "Endpoint=sb://***/;SharedAccessKeyName=***;SharedAccessKey=***;EntityPath=***",
"secondaryConnectionString": "Endpoint=sb://***/;SharedAccessKeyName=***;SharedAccessKey=***;EntityPath=***",
"createdTime": "2019-11-19T01:10:34.350Z"
}
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
{
"parameters": {
"subscriptionId": "50016170-c839-41ba-a724-51e9df440b9e",
"resourceGroupName": "resRg",
"resourceName": "myDigitalTwinsService",
"api-version": "2020-12-01",
"endpointName": "myServiceBus",
"endpointDescription": {
"properties": {
"endpointType": "ServiceBus",
"authenticationType": "IdentityBased",
"endpointUri": "sb://mysb.servicebus.windows.net/",
"entityPath": "mysbtopic"
}
}
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/50016170-c839-41ba-a724-51e9df440b9e/resourcegroups/resRg/providers/Microsoft.DigitalTwins/digitalTwinsInstances/myDigitalTwinsService/endpoints/myServiceBus",
"type": "Microsoft.DigitalTwins/digitalTwinsInstances/endpoints",
"name": "myServiceBus",
"properties": {
"endpointType": "ServiceBus",
"provisioningState": "Provisioning",
"authenticationType": "IdentityBased",
"endpointUri": "sb://mysb.servicebus.windows.net/",
"entityPath": "mysbtopic",
"createdTime": "2019-11-19T01:10:34.350Z"
}
}
},
"201": {
"body": {
"id": "/subscriptions/50016170-c839-41ba-a724-51e9df440b9e/resourcegroups/resRg/providers/Microsoft.DigitalTwins/digitalTwinsInstances/myDigitalTwinsService/endpoints/myServiceBus",
"type": "Microsoft.DigitalTwins/digitalTwinsInstances/endpoints",
"name": "myServiceBus",
"properties": {
"endpointType": "ServiceBus",
"provisioningState": "Provisioning",
"authenticationType": "IdentityBased",
"endpointUri": "sb://mysb.servicebus.windows.net/",
"entityPath": "mysbtopic",
"createdTime": "2019-11-19T01:10:34.350Z"
}
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
{
"parameters": {
"subscriptionId": "50016170-c839-41ba-a724-51e9df440b9e",
"resourceGroupName": "resRg",
"resourceName": "myDigitalTwinsService",
"api-version": "2020-12-01",
"endpointName": "myServiceBus",
"endpointDescription": {
"properties": {
"endpointType": "ServiceBus",
"authenticationType": "KeyBased",
"primaryConnectionString": "Endpoint=sb://mysb.servicebus.windows.net/;SharedAccessKeyName=RootManageSharedAccessKey;SharedAccessKey=xyzxyzoX4=;EntityPath=abcabc",
"secondaryConnectionString": "Endpoint=sb://mysb.servicebus.windows.net/;SharedAccessKeyName=RootManageSharedAccessKey;SharedAccessKey=xyzxyzoX4=;EntityPath=abcabc"
}
}
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/50016170-c839-41ba-a724-51e9df440b9e/resourcegroups/resRg/providers/Microsoft.DigitalTwins/digitalTwinsInstances/myDigitalTwinsService/endpoints/myServiceBus",
"type": "Microsoft.DigitalTwins/digitalTwinsInstances/endpoints",
"name": "myServiceBus",
"properties": {
"endpointType": "ServiceBus",
"authenticationType": "KeyBased",
"provisioningState": "Succeeded",
"primaryConnectionString": "Endpoint=sb://***/;SharedAccessKeyName=***;SharedAccessKey=***;EntityPath=***",
"secondaryConnectionString": "Endpoint=sb://***/;SharedAccessKeyName=***;SharedAccessKey=***;EntityPath=***",
"createdTime": "2019-11-19T01:10:34.350Z"
}
}
},
"201": {
"body": {
"id": "/subscriptions/50016170-c839-41ba-a724-51e9df440b9e/resourcegroups/resRg/providers/Microsoft.DigitalTwins/digitalTwinsInstances/myDigitalTwinsService/endpoints/myServiceBus",
"type": "Microsoft.DigitalTwins/digitalTwinsInstances/endpoints",
"name": "myServiceBus",
"properties": {
"endpointType": "ServiceBus",
"authenticationType": "KeyBased",
"provisioningState": "Provisioning",
"primaryConnectionString": "",
"secondaryConnectionString": "",
"createdTime": "2019-11-19T01:10:34.350Z"
}
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
{
"parameters": {
"subscriptionId": "50016170-c839-41ba-a724-51e9df440b9e",
"resourceGroupName": "resRg",
"resourceName": "myDigitalTwinsService",
"api-version": "2020-12-01"
},
"responses": {
"200": {
"body": {
"value": [
{
"id": "/subscriptions/50016170-c839-41ba-a724-51e9df440b9e/resourcegroups/resRg/providers/Microsoft.DigitalTwins/digitalTwinsInstances/myDigitalTwinsService/endpoints/myServiceBus",
"type": "Microsoft.DigitalTwins/digitalTwinsInstances/endpoints",
"name": "myServiceBus",
"properties": {
"endpointType": "ServiceBus",
"authenticationType": "IdentityBased",
"provisioningState": "Succeeded",
"endpointUri": "sb://mysb.servicebus.windows.net/",
"entityPath": "mysbtopic",
"createdTime": "2019-11-19T01:10:34.350Z"
}
},
{
"id": "/subscriptions/50016170-c839-41ba-a724-51e9df440b9e/resourcegroups/resRg/providers/Microsoft.DigitalTwins/digitalTwinsInstances/myDigitalTwinsService/endpoints/myServiceBus",
"type": "Microsoft.DigitalTwins/digitalTwinsInstances/endpoints",
"name": "myServiceBus",
"properties": {
"endpointType": "EventHub",
"authenticationType": "KeyBased",
"connectionStringPrimaryKey": "************",
"connectionStringSecondaryKey": "************",
"provisioningState": "Succeeded",
"createdTime": "2019-11-19T01:10:34.350Z"
}
}
]
}
}
}
}
Loading