{VirtualWan} {HubRouteTables} : Fix parameter type #10998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
❌ |
| Rule | Message |
|---|---|
|
The new version has a different type 'string' than the previous one ''. New: Microsoft.Network/stable/2020-06-01/virtualWan.json#L7249:9 Old: Microsoft.Network/stable/2020-06-01/virtualWan.json#L7249:9 |
|
The new version has a different type 'string' than the previous one ''. New: Microsoft.Network/stable/2020-06-01/virtualWan.json#L6131:11 Old: Microsoft.Network/stable/2020-06-01/virtualWan.json#L6131:11 |
|
The new version has a different type 'string' than the previous one ''. New: Microsoft.Network/stable/2020-06-01/virtualWan.json#L6123:11 Old: Microsoft.Network/stable/2020-06-01/virtualWan.json#L6123:11 |
|
The new version is missing a property found in the old version. Was 'tags' renamed or removed? Old: Microsoft.Network/stable/2020-06-01/network.json#L141:7 |
|
The new version is missing a property found in the old version. Was 'id' renamed or removed? Old: Microsoft.Network/stable/2020-06-01/network.json#L172:7 |
|
The new version is missing a property found in the old version. Was 'id' renamed or removed? Old: Microsoft.Network/stable/2020-06-01/network.json#L172:7 |
|
The new version is missing a property found in the old version. Was 'id' renamed or removed? Old: Microsoft.Network/stable/2020-06-01/network.json#L141:7 |
|
The new version is missing a property found in the old version. Was 'name' renamed or removed? Old: Microsoft.Network/stable/2020-06-01/network.json#L141:7 |
|
The new version is missing a property found in the old version. Was 'type' renamed or removed? Old: Microsoft.Network/stable/2020-06-01/network.json#L141:7 |
|
The new version is missing a property found in the old version. Was 'location' renamed or removed? Old: Microsoft.Network/stable/2020-06-01/network.json#L141:7 |
️️✔️LintDiff [Detail]
️✔️Validation passes for LintDiff.
️️✔️Avocado [Detail]
️✔️Validation passes for Avocado.
️️✔️ModelValidation [Detail]
️✔️Validation passes for ModelValidation.
️️✔️SemanticValidation [Detail]
️✔️Validation passes for SemanticValidation.
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-js
|
azure-resource-manager-schemas
|
azure-sdk-for-python
|
azure-sdk-for-go
|
azure-sdk-for-net
|
azure-sdk-for-python-track2
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Sep 30, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This change done for 2020-05-01 contains one more additional change for VirtualHubEffectiveRouteEffectiveRouteList- Please make sure that it gets to any forward versions .. in case it has branched out to a network-july / network-august etc. and comes back into master. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
allenjzhang
added
WaitForARMFeedback
|
This is a breaking change on a stable version of API. Per new guidelines, it is not allowed. |
allenjzhang
added
the
Reviewed-ChangesRequested
|
@allenjzhang : when the new folder for 06-01 was created a PR which included these fixes was missed and now our PS cmdlets are broken. this is not a new breaking change that is being introduced but rather just manually adding back the missed changes. #9839 - this was the original PR which fixed the api versions 04-01 and 05-01 and was checked in to the master branch. |
|
Marking ARM approved based on the PR #9839 and the changes are same. |
chiragg4u
added
ARMSignedOff
|
Thank you very much, we are actually broken without these changes. @chiragg4u Do you who can help merge this in ? |
allenjzhang
reviewed
Oct 11, 2020
|
Allen,
Didn't Chirag already approve it? Also, please note that this shouldn't
qualify as a breaking change. The current swagger and powershell are broken
for Virtual Wan route table commands and the change is trying to fix it.
The older 05-01 api version already has the change, but 06-01 api version
is broken because the change was not correctly carried over to the 06-01
swagger folder. We don't quite understand how it landed up in that state,
probably a question you might be able to help answer.
Request you to merge the change ASAP. This is blocking some of the
powershell deployments.
Thanks,
Shyam
…On Sun, Oct 11, 2020 at 3:15 PM Allen Zhang ***@***.***> wrote:
***@***.**** commented on this pull request.
*SDKs have been released*. These constitute both swagger and SDK breaking
change. You would need *Breaking change board* to sign off on this.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#10998 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APLC6Q5XK4WKQWTOVSXR3ETSKIU7PANCNFSM4R7P62BA>
.
|
allenjzhang
added
the
Approved-BreakingChange
allenjzhang
approved these changes
Oct 12, 2020
|
Thanks for the explanation. There is now a lot of focus been put on breaking changes that cause customer pain points. Hence the increased scrutiny. |
|
@shyamshd @allenjzhang thank you very much ! |
This was referenced Oct 13, 2020
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.