Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compute] Update readme.python.md #11003

Merged
merged 2 commits into from
Oct 9, 2020
Merged

[Compute] Update readme.python.md #11003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e164fcc
add 2020-09-30 to python readme
Sep 30, 2020
266f449
Make HyperVGen modelAsString in sharedGallery.json
Oct 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...fication/compute/resource-manager/Microsoft.Compute/preview/2020-09-30/sharedGallery.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@
],
"x-ms-enum": {
"name": "HyperVGeneration",
"modelAsString": false
"modelAsString": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will cause enum value type in SDK changed from enum to string. It should be a breaking change for some language. could you pls share why change this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gallery.json and sharedGallery.json should reuse the same HyperVGeneration object. sharedGallery.json swagger refers to a new feature under development that currently has no customers so I don't believe breaking changes is important at this point for that work.

}
},
"features": {
Expand Down
15 changes: 15 additions & 0 deletions specification/compute/resource-manager/readme.python.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ Generate all API versions currently shipped for this package

```yaml $(multiapi) && !$(track2)
batch:
- tag: package-2020-09-30-only
- tag: package-2020-06-30-only
- tag: package-2020-06-01-only
- tag: package-2020-05-01-only
Expand All @@ -67,6 +68,7 @@ batch:
```yaml $(multiapi) && $(track2)
clear-output-folder: true
batch:
- tag: package-2020-09-30-only
- tag: package-2020-06-30-only
- tag: package-2020-06-01-only
- tag: package-2020-05-01-only
Expand Down Expand Up @@ -94,6 +96,19 @@ clear-output-folder: false
perform-load: false
```

### Tag: package-2020-09-30-only and python

These settings apply only when `--tag=package-2020-09-30-only --python` is specified on the command line.
Please also specify `--python-sdks-folder=<path to the root directory of your azure-sdk-for-python clone>`.

``` yaml $(tag) == 'package-2020-09-30-only'
namespace: azure.mgmt.compute.v2020_09_30
output-folder: $(python-sdks-folder)/compute/azure-mgmt-compute/azure/mgmt/compute/v2020_09_30
python:
namespace: azure.mgmt.compute.v2020_09_30
output-folder: $(python-sdks-folder)/compute/azure-mgmt-compute/azure/mgmt/compute/v2020_09_30
```

### Tag: package-2020-06-30-only and python

These settings apply only when `--tag=package-2020-06-30-only --python` is specified on the command line.
Expand Down