Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.ResourceGraph to add version preview/2020-04-01-preview #11070

Merged
merged 16 commits into from
Jan 24, 2021
Merged

[Hub Generated] Review request for Microsoft.ResourceGraph to add version preview/2020-04-01-preview #11070

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
1254f45
Add missing subscriptionId and resourceGroup
Yobretaw Sep 28, 2020
c8b1632
Update 2020-04-01-preview
Yobretaw Oct 5, 2020
e2b8693
Split 2020-04-01-preview
Oct 7, 2020
52e1adc
Merge branch 'patch-1' into dev-resourcegraph-Microsoft.ResourceGraph…
Oct 7, 2020
cc35b3d
Reverting changes for subscriptionId/resourceGroup; Fix casing for et…
Oct 14, 2020
10dada2
Adding missing ResourcesHistory API to swagger
Nov 18, 2020
7ba5e89
Fix API definition; Add an example
Nov 18, 2020
64a43ad
Fix multiple issues
Nov 30, 2020
b715ff6
Fix linter/model issues
Nov 30, 2020
6824bd5
Fix etag casing more places
Nov 30, 2020
ef6e448
Fix ErrorResponse modeling in resourcechanges.json and resourcehistor…
Dec 15, 2020
42c6436
Add default response for Operations API
Dec 15, 2020
87c3af1
Revert renaming of PropertyChangeType
Jan 5, 2021
5bfd7fb
Add changeType to swagger
Jan 5, 2021
7e59684
Revert "Add changeType to swagger"
Jan 5, 2021
3deaa28
Fix swagger for resourcesHistory
Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...graph/resource-manager/Microsoft.ResourceGraph/preview/2018-09-01-preview/graphquery.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,16 @@
"readOnly": true,
"description": "Azure resource name. This is GUID value. The display name should be assigned within properties field."
},
"subscriptionId": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand the change here. This "Resource" definition was more or less aligned with standard "TrackedResource" definition. But now you are adding subscription ID and resource group here, it is messing up this base definition. I would suggest this to go on to the specific query definition.

Also in terms of the name GraphQueryResource, if feels more like XXXQuery rather a XXXResource. Anyway, I guess that boat has sailed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually you are correct.. We are returning extra fields in the RP. Let me revert this change and fix our RP side.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted changes for subscriptionId/resourceGroup. Also fixed a casing issue for etag field.

"type": "string",
"readOnly": true,
"description": "The Id of the subscription to which the resource belongs."
},
"resourceGroup": {
"type": "string",
"readOnly": true,
"description": "The name of the resource group this resource belongs to."
},
"location": {
"type": "string",
"readOnly": false,
Expand Down
10 changes: 10 additions & 0 deletions ...graph/resource-manager/Microsoft.ResourceGraph/preview/2020-04-01-preview/graphquery.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,16 @@
"readOnly": true,
"description": "Azure resource name. This is GUID value. The display name should be assigned within properties field."
},
"subscriptionId": {
"type": "string",
"readOnly": true,
"description": "The Id of the subscription to which the resource belongs."
},
"resourceGroup": {
"type": "string",
"readOnly": true,
"description": "The name of the resource group this resource belongs to."
},
"location": {
"type": "string",
"readOnly": true,
Expand Down
Loading