Add enableCrossZoneUpgrade and prioritizeUnhealthyInstances properties to RollingUpgradePolicy for VMSS #11184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 13, 2020 14:46
…d prioritizeUnhealthyInstances
kimberlyyipc
requested review from
dkulkarni-ms,
grizzlytheodore,
haagha,
hyonholee,
madewithsmiles,
MS-syh2qs and
Sandido
as code owners
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableCrossZoneUpgrade New: Microsoft.Compute/stable/2020-12-01/compute.json#L9576 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: prioritizeUnhealthyInstances New: Microsoft.Compute/stable/2020-12-01/compute.json#L9580 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2020-12-01 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 31 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.1)
- original: preview/2016-04-30-preview/compute.json <---> new: stable/2020-12-01/compute.json
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 23 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.1)
- original: stable/2020-06-01/compute.json <---> new: stable/2020-12-01/compute.json
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java
|
azure-sdk-for-net
|
azure-sdk-for-js
|
azure-sdk-for-go
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas
|
azure-sdk-for-python-track2
- Breaking Change detected in SDK
|
|
The PR for these changes are still in review and I will provide update when our changes are merged to CRP |
This was referenced Oct 14, 2020
|
No commit pushedDate could be found for PR 11184 in repo Azure/azure-rest-api-specs |
ajjha-az
reviewed
Nov 10, 2020
specification/compute/resource-manager/Microsoft.Compute/stable/2020-12-01/compute.json
Outdated
Show resolved
Hide resolved
ajjha-az
reviewed
Nov 10, 2020
specification/compute/resource-manager/Microsoft.Compute/stable/2020-12-01/compute.json
Outdated
Show resolved
Hide resolved
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Nov 11, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
These changes have been reviewed as not breaking. |
Sandido
approved these changes
Nov 19, 2020
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sandido
removed
the
DoNotMerge
|
@fengzhou-msft Hi, can you please take a look at my changes again? Also, how can I go about resolving the SDK azure-sdk-for-go and SDK azure-sdk-for-net failures in the pipeline? |
|
The Go SDK error is a known issue, you can ignore it now. The .NET SDK error is test project build failure which is expected now. Safe to ignore. |
fengzhou-msft
approved these changes
Nov 23, 2020
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on PR review process.
Note: These changes have been reviewed as not breaking