-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apimanagement - 2020-06-01-preview version release #11196
Conversation
…19-12-01 to version 2020-06-01-preview
* apim in azs * fix prettier check
* add support for PATCH returning 200 OK * CI fixes prettier fix CI fixes part 2 * Password no longer a mandatory property when uploading Certificates * add missing x-ms-odata extension for filter support
* Oauth server secrets contract * fix azureMonitor enum
* API Management Service Deleted Services Resource * Path fix * Lint + custom-words fixes * Location URI parameter for deletedservices Resource * GET for deletedservices by service name * Remove resourceGroupName from resource path * fixes * schema for purge operation * perttier applied * 204 response code added Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com>
* OperationNameFormat property added to Diagnostic contract * add azuremonitor to update contract Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com>
…esponse contract (#10331) * Change Network Status response contract * Update examples for network status contract
* update namedvalue contract for keyvault * add examples * separate out create contract * common create contract * fix examples
* Data Masking settings for Diagnostic * Move dataMasking under HttpMessageDiagnostic Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com>
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-js - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
@solankisamir , please fix the model validation failures that is about the secret annotated as |
Please see PR #11227 which fixes the issue. This api-version is a new api-version and no customers are using it. The contract was designed specifically for listing secrets. |
Looks good to me, this PR can be merged after PR#11227 is merged. |
…igned to List secrets on POST operation (#11227) * secret ok in POST operation * fix prettier
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@raych1 feel free to merge this. We will the example in the master branch |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@raych1 please merge if things look good to you! |
/azp run automation - sdk |
Azure Pipelines successfully started running 1 pipeline(s). |
@raych1 feel free to merge it. We will fix the .NET sdk issues with breaking changes in the SDK as this is a new api-version. |
OK. |
* Adds base for updating Microsoft.ApiManagement from version stable/2019-12-01 to version 2020-06-01-preview * Updates readme * Updates API version in new specs and examples * Add support in API Management for Availability Zones (Azure#10284) * apim in azs * fix prettier check * PATCH should return 200 OK (Azure#10328) * add support for PATCH returning 200 OK * CI fixes prettier fix CI fixes part 2 * Password no longer a mandatory property when uploading Certificates * add missing x-ms-odata extension for filter support * +gatewayhostnameconfiguration protocol changes (Azure#10292) * [2020-06-01-preview] Update Oauth Server secrets Contract (Azure#10602) * Oauth server secrets contract * fix azureMonitor enum * API Management Service Deleted Services Resource (Azure#10607) * API Management Service Deleted Services Resource * Path fix * Lint + custom-words fixes * Location URI parameter for deletedservices Resource * GET for deletedservices by service name * Remove resourceGroupName from resource path * fixes * schema for purge operation * perttier applied * 204 response code added Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com> * OperationNameFormat property added to Diagnostic contract (Azure#10641) * OperationNameFormat property added to Diagnostic contract * add azuremonitor to update contract Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com> * [Microsoft.ApiManagement][2020-06-01-preview] Change Network Status response contract (Azure#10331) * Change Network Status response contract * Update examples for network status contract * identityClientId support (Azure#10776) * [2020-06-01-preview] Update namedvalue contract for keyvault (Azure#10604) * update namedvalue contract for keyvault * add examples * separate out create contract * common create contract * fix examples * Data Masking settings for Diagnostic (Azure#11033) * Data Masking settings for Diagnostic * Move dataMasking under HttpMessageDiagnostic Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com> * Add isolated skutype (Azure#11029) * cache entity (Azure#11098) * [2020-06-01-preview] update certificate contract for KeyVault (Azure#11097) * The contract `AuthorizationServerSecretsContract` is specifically designed to List secrets on POST operation (Azure#11227) * secret ok in POST operation * fix prettier * fix example (Azure#11249) Co-authored-by: maksimkim <maksim.kim@gmail.com> Co-authored-by: promoisha <feoktistovgg@gmail.com> Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com> Co-authored-by: RupengLiu <rliu1211@terpmail.umd.edu> Co-authored-by: JJ <jijohn@microsoft.com> Co-authored-by: Kacie <35987382+KacieKK@users.noreply.github.com>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Merging the branch to master, as all the changes are in. Please refer to individual sign-off here
https://github.com/Azure/azure-rest-api-specs/pulls?q=is%3Apr+label%3A2020-06-01-preview+is%3Aclosed
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.