-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Quantum to add version preview/2019-11-04-preview #11259
Conversation
Swagger Validation Report
|
Azure Pipelines successfully started running 1 pipeline(s). |
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python
- Breaking Change detected in SDK
|
azure-sdk-for-python-track2
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas
|
azure-sdk-for-net
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js
|
azure-sdk-for-java
|
azure-sdk-for-go
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Hi, @anpaz Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
@anpaz please review failing CI checks that are marked Required. |
specification/quantum/data-plane/Microsoft.Quantum/preview/2019-11-04-preview/quantum.json
Outdated
Show resolved
Hide resolved
specification/quantum/data-plane/Microsoft.Quantum/preview/2019-11-04-preview/quantum.json
Outdated
Show resolved
Hide resolved
specification/quantum/data-plane/Microsoft.Quantum/preview/2019-11-04-preview/quantum.json
Outdated
Show resolved
Hide resolved
specification/quantum/data-plane/Microsoft.Quantum/preview/2019-11-04-preview/quantum.json
Show resolved
Hide resolved
specification/quantum/data-plane/Microsoft.Quantum/preview/2019-11-04-preview/quantum.json
Outdated
Show resolved
Hide resolved
specification/quantum/data-plane/Microsoft.Quantum/preview/2019-11-04-preview/quantum.json
Show resolved
Hide resolved
specification/quantum/data-plane/Microsoft.Quantum/preview/2019-11-04-preview/quantum.json
Outdated
Show resolved
Hide resolved
specification/quantum/data-plane/Microsoft.Quantum/preview/2019-11-04-preview/quantum.json
Show resolved
Hide resolved
specification/quantum/data-plane/Microsoft.Quantum/preview/2019-11-04-preview/quantum.json
Show resolved
Hide resolved
specification/quantum/data-plane/Microsoft.Quantum/preview/2019-11-04-preview/quantum.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a syntax perspective, looks sane to me
"description": "The creation time of the job." | ||
}, | ||
"beginExecutionTime": { | ||
"type": "string", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"format": "date-time"
. Applies to all properties that represent date-time values.
"description": "The blob container SAS uri, the container is used to host job data." | ||
}, | ||
"inputDataUri": { | ||
"type": "string", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"format": "uri"
. Applies to all properties that represent URIs.
"metadata": { | ||
"type": "object", | ||
"additionalProperties": { | ||
"type": "string" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means that the metadata values can only be of type string (i.e. not numbers etc.). I assume that is intentional.
} | ||
} | ||
}, | ||
"jobDetails": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would strongly suggest that you call this model "Job". It is what you get if you do a GET on the job path after all.
While this is not impacting the REST API, but it would affect generated models and documentation etc.
A couple of general comments:
|
"$ref": "#/definitions/JobDetails" | ||
} | ||
}, | ||
"count": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that this is the total number of items across all pages?
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.