Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Quantum to add version preview/2019-11-04-preview #11259

Merged
merged 30 commits into from
Jan 7, 2021

Conversation

anpaz
Copy link
Contributor

@anpaz anpaz commented Oct 17, 2020

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 17, 2020

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 17, 2020

Trenton Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 17, 2020

azure-sdk-for-python

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 7af481b with merge commit b7dcc0850876070a9ac46bcdafa262722a44586c. SDK Automation 13.0.17.20200918.2
  • ⚠️azure-mgmt-kubernetesconfiguration [View full logs]  [Preview SDK Changes] Breaking Change Detected
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-kubernetesconfiguration
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-kubernetesconfiguration
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [ChangeLog] Size of delta 36.382% size of original (original: 9032 chars, delta: 3286 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model SourceControlConfiguration has a new parameter configuration_protected_settings
    [ChangeLog]   - Model SourceControlConfiguration has a new parameter system_data
    [ChangeLog]   - Model SourceControlConfiguration has a new parameter ssh_known_hosts_contents
    [ChangeLog]   - Model Resource has a new parameter system_data
    [ChangeLog]   - Model ProxyResource has a new parameter system_data
    [ChangeLog] 
    [ChangeLog] **Breaking changes**
    [ChangeLog] 
    [ChangeLog]   - Model ErrorDefinition has a new signature

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 17, 2020

azure-sdk-for-python-track2

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 17, 2020

azure-resource-manager-schemas

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 7af481b with merge commit b7dcc0850876070a9ac46bcdafa262722a44586c. Schema Automation 13.0.17.20200918.2
    [kubernetesconfiguration][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    [kubernetesconfiguration][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    [kubernetesconfiguration][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
  • ️✔️kubernetesconfiguration [View full logs]  [Preview Schema Changes]
      [after_scripts|node] PostProcessor finished successfully.
      [after_scripts|node]   5794 passing (1m)
      AzureResourceSchema has no registered package commands.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 17, 2020

    azure-sdk-for-net

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 17, 2020

    azure-sdk-for-js

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 7af481b with merge commit b7dcc0850876070a9ac46bcdafa262722a44586c. SDK Automation 13.0.17.20200918.2
    • ️✔️@azure/arm-kubernetesconfiguration [View full logs]  [Preview SDK Changes]
      [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
      [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
      [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
      [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
      [npmPack] loaded rollup.config.js with warnings
      [npmPack] (!) Unused external imports
      [npmPack] default imported from external module 'rollup' but never used
      [npmPack] 
      [npmPack] ./esm/sourceControlConfigurationClient.js → ./dist/arm-kubernetesconfiguration.js...
      [npmPack] created ./dist/arm-kubernetesconfiguration.js in 190ms
      [npmPack] npm notice 
      [npmPack] npm notice package: @azure/arm-kubernetesconfiguration@2.0.0
      [npmPack] npm notice === Tarball Contents === 
      [npmPack] npm notice 31.9kB dist/arm-kubernetesconfiguration.js                   
      [npmPack] npm notice 11.1kB dist/arm-kubernetesconfiguration.min.js               
      [npmPack] npm notice 263B   esm/models/index.js                                   
      [npmPack] npm notice 343B   esm/operations/index.js                               
      [npmPack] npm notice 11.8kB esm/models/mappers.js                                 
      [npmPack] npm notice 1.4kB  esm/operations/operations.js                          
      [npmPack] npm notice 403B   esm/models/operationsMappers.js                       
      [npmPack] npm notice 1.8kB  esm/models/parameters.js                              
      [npmPack] npm notice 942B   rollup.config.js                                      
      [npmPack] npm notice 1.7kB  esm/sourceControlConfigurationClient.js               
      [npmPack] npm notice 2.1kB  esm/sourceControlConfigurationClientContext.js        
      [npmPack] npm notice 6.7kB  esm/operations/sourceControlConfigurations.js         
      [npmPack] npm notice 499B   esm/models/sourceControlConfigurationsMappers.js      
      [npmPack] npm notice 1.7kB  package.json                                          
      [npmPack] npm notice 457B   tsconfig.json                                         
      [npmPack] npm notice 78.1kB dist/arm-kubernetesconfiguration.js.map               
      [npmPack] npm notice 10.2kB dist/arm-kubernetesconfiguration.min.js.map           
      [npmPack] npm notice 4.5kB  esm/models/index.d.ts.map                             
      [npmPack] npm notice 160B   esm/operations/index.d.ts.map                         
      [npmPack] npm notice 126B   esm/models/index.js.map                               
      [npmPack] npm notice 174B   esm/operations/index.js.map                           
      [npmPack] npm notice 777B   esm/models/mappers.d.ts.map                           
      [npmPack] npm notice 6.6kB  esm/models/mappers.js.map                             
      [npmPack] npm notice 663B   esm/operations/operations.d.ts.map                    
      [npmPack] npm notice 832B   esm/operations/operations.js.map                      
      [npmPack] npm notice 208B   esm/models/operationsMappers.d.ts.map                 
      [npmPack] npm notice 221B   esm/models/operationsMappers.js.map                   
      [npmPack] npm notice 496B   esm/models/parameters.d.ts.map                        
      [npmPack] npm notice 1.3kB  esm/models/parameters.js.map                          
      [npmPack] npm notice 629B   esm/sourceControlConfigurationClient.d.ts.map         
      [npmPack] npm notice 772B   esm/sourceControlConfigurationClient.js.map           
      [npmPack] npm notice 436B   esm/sourceControlConfigurationClientContext.d.ts.map  
      [npmPack] npm notice 1.0kB  esm/sourceControlConfigurationClientContext.js.map    
      [npmPack] npm notice 3.3kB  esm/operations/sourceControlConfigurations.d.ts.map   
      [npmPack] npm notice 3.4kB  esm/operations/sourceControlConfigurations.js.map     
      [npmPack] npm notice 305B   esm/models/sourceControlConfigurationsMappers.d.ts.map
      [npmPack] npm notice 318B   esm/models/sourceControlConfigurationsMappers.js.map  
      [npmPack] npm notice 4.1kB  README.md                                             
      [npmPack] npm notice 13.5kB esm/models/index.d.ts                                 
      [npmPack] npm notice 112B   esm/operations/index.d.ts                             
      [npmPack] npm notice 13.1kB src/models/index.ts                                   
      [npmPack] npm notice 311B   src/operations/index.ts                               
      [npmPack] npm notice 938B   esm/models/mappers.d.ts                               
      [npmPack] npm notice 9.6kB  src/models/mappers.ts                                 
      [npmPack] npm notice 1.2kB  esm/operations/operations.d.ts                        
      [npmPack] npm notice 2.3kB  src/operations/operations.ts                          
      [npmPack] npm notice 175B   esm/models/operationsMappers.d.ts                     
      [npmPack] npm notice 365B   src/models/operationsMappers.ts                       
      [npmPack] npm notice 568B   esm/models/parameters.d.ts                            
      [npmPack] npm notice 1.8kB  src/models/parameters.ts                              
      [npmPack] npm notice 1.2kB  esm/sourceControlConfigurationClient.d.ts             
      [npmPack] npm notice 1.6kB  src/sourceControlConfigurationClient.ts               
      [npmPack] npm notice 779B   esm/sourceControlConfigurationClientContext.d.ts      
      [npmPack] npm notice 1.7kB  src/sourceControlConfigurationClientContext.ts        
      [npmPack] npm notice 13.8kB esm/operations/sourceControlConfigurations.d.ts       
      [npmPack] npm notice 19.9kB src/operations/sourceControlConfigurations.ts         
      [npmPack] npm notice 271B   esm/models/sourceControlConfigurationsMappers.d.ts    
      [npmPack] npm notice 456B   src/models/sourceControlConfigurationsMappers.ts      
      [npmPack] npm notice 1.1kB  LICENSE.txt                                           
      [npmPack] npm notice === Tarball Details === 
      [npmPack] npm notice name:          @azure/arm-kubernetesconfiguration         
      [npmPack] npm notice version:       2.0.0                                      
      [npmPack] npm notice filename:      azure-arm-kubernetesconfiguration-2.0.0.tgz
      [npmPack] npm notice package size:  38.4 kB                                    
      [npmPack] npm notice unpacked size: 276.3 kB                                   
      [npmPack] npm notice shasum:        ed521ec0f991e9ec48555822a1ebd2552e100b7b   
      [npmPack] npm notice integrity:     sha512-6Oufna/6CIR2n[...]LCXWduOYtkPnA==   
      [npmPack] npm notice total files:   59                                         
      [npmPack] npm notice 

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 17, 2020

    azure-sdk-for-java

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 7af481b with merge commit b7dcc0850876070a9ac46bcdafa262722a44586c. SDK Automation 13.0.17.20200918.2
    • ⚠️sdk/kubernetesconfiguration/mgmt-v2019_11_01_preview [View full logs]  [Preview SDK Changes]
        [mvn] [ERROR] COMPILATION ERROR : 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/kubernetesconfiguration/mgmt-v2019_11_01_preview/src/main/java/com/microsoft/azure/management/kubernetesconfiguration/v2019_11_01_preview/implementation/SourceControlConfigurationImpl.java:[44,32] cannot find symbol
        [mvn]   symbol:   method fromString(java.lang.String)
        [mvn]   location: class java.lang.String
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/kubernetesconfiguration/mgmt-v2019_11_01_preview/src/main/java/com/microsoft/azure/management/kubernetesconfiguration/v2019_11_01_preview/implementation/SourceControlConfigurationImpl.java:[46,42] cannot find symbol
        [mvn]   symbol:   method fromString(java.lang.String)
        [mvn]   location: class java.lang.String
        [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-kubernetesconfiguration: Compilation failure: Compilation failure: 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/kubernetesconfiguration/mgmt-v2019_11_01_preview/src/main/java/com/microsoft/azure/management/kubernetesconfiguration/v2019_11_01_preview/implementation/SourceControlConfigurationImpl.java:[44,32] cannot find symbol
        [mvn] [ERROR]   symbol:   method fromString(java.lang.String)
        [mvn] [ERROR]   location: class java.lang.String
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/kubernetesconfiguration/mgmt-v2019_11_01_preview/src/main/java/com/microsoft/azure/management/kubernetesconfiguration/v2019_11_01_preview/implementation/SourceControlConfigurationImpl.java:[46,42] cannot find symbol
        [mvn] [ERROR]   symbol:   method fromString(java.lang.String)
        [mvn] [ERROR]   location: class java.lang.String
        [mvn] [ERROR] -> [Help 1]
        [mvn] [ERROR] 
        [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
        [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
        [mvn] [ERROR] 
        [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
        [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Oct 17, 2020

      azure-sdk-for-go

      failed [Logs] [Expand Details]
      • Generate from 7af481b with merge commit b7dcc0850876070a9ac46bcdafa262722a44586c. SDK Automation 13.0.17.20200918.2
        [AutoRest] FATAL: System.InvalidOperationException: namespace can only contains lower case letters, numbers and underscore
        [AutoRest]    at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 58
        [AutoRest] --- End of stack trace from previous location where exception was thrown ---
        [AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
        [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
        [AutoRest]    at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
        [AutoRest] --- End of stack trace from previous location where exception was thrown ---
        [AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
        [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
        [AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
        [AutoRest]    at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
        [AutoRest] FATAL: go/generate - FAILED
        [AutoRest] FATAL: Error: Plugin go reported failure.
        [AutoRest]   Error: Plugin go reported failure.
        Failed to run autorest.
        Error: /z/node_modules/.bin/autorest --use=@microsoft.azure/autorest.go@~2.1.157 --go --verbose --multiapi --use-onever --preview-chk --version=V2 --go-sdk-folder=/z/work/src/github.com/Azure/azure-sdk-for-go /z/work/azure-rest-api-specs/specification/quantum/data-plane/readme.md FATAL: System.InvalidOperationException: namespace can only contains lower case letters, numbers and underscore
           at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 58
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
           at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
           at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
           at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
        FATAL: go/generate - FAILED
        FATAL: Error: Plugin go reported failure.
          Error: Plugin go reported failure.
        , {} 
      • ⚠️preview/kubernetesconfiguration/mgmt/2019-11-01-preview [View full logs
        No file is changed.

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Oct 17, 2020

      Azure CLI Extension Generation

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @openapi-workflow-bot
      Copy link

      Hi, @anpaz Thanks for your PR. I am workflow bot for review process. Here are some small tips.

    • Please ensure to do self-check against checklists in first PR comment.
    • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
    • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

      @tjprescott
      Copy link
      Member

      @anpaz please review failing CI checks that are marked Required.

      Copy link
      Member

      @lmazuel lmazuel left a comment

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      From a syntax perspective, looks sane to me

      "description": "The creation time of the job."
      },
      "beginExecutionTime": {
      "type": "string",
      Copy link
      Member

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      "format": "date-time". Applies to all properties that represent date-time values.

      "description": "The blob container SAS uri, the container is used to host job data."
      },
      "inputDataUri": {
      "type": "string",
      Copy link
      Member

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      "format": "uri". Applies to all properties that represent URIs.

      "metadata": {
      "type": "object",
      "additionalProperties": {
      "type": "string"
      Copy link
      Member

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      This means that the metadata values can only be of type string (i.e. not numbers etc.). I assume that is intentional.

      }
      }
      },
      "jobDetails": {
      Copy link
      Member

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      I would strongly suggest that you call this model "Job". It is what you get if you do a GET on the job path after all.
      While this is not impacting the REST API, but it would affect generated models and documentation etc.

      @johanste
      Copy link
      Member

      johanste commented Jan 7, 2021

      A couple of general comments:

      • there seem to be some format specifiers for URLs, Guids and date times. Please do a pass and ensure that all string types (on the wire) have the appropriate format applied.
      • please make sure that your service only uses millisecond precision for date-time values unless it is absolutely imperative to have higher precision (this is rare). This allows for maximum interoperability across programming languages.

      "$ref": "#/definitions/JobDetails"
      }
      },
      "count": {
      Copy link
      Member

      Choose a reason for hiding this comment

      The reason will be displayed to describe this comment to others. Learn more.

      I assume that this is the total number of items across all pages?

      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Projects
      None yet
      Development

      Successfully merging this pull request may close these issues.

      4 participants