[Hub Generated] Review request for Microsoft.Quantum to add version preview/2019-11-04-preview #11266

anpaz · 2020-10-19T01:46:34Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-10-19T01:46:37Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 2 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- quantum/resource-manager/readme.md tag:package-2019-11-04-preview
Linted configuring files (Based on target branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- quantum/resource-manager/readme.md tag:default

Rule	Message
⚠️ R4006 - DeprecatedXmsCodeGenerationSetting	The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation. New: Microsoft.Quantum/preview/2019-11-04-preview/quantum.json#L6
⚠️ R4024 - PreviewVersionOverOneYear	The API version:2019-11-04-preview having been in a preview state over one year , please move it to GA or retire. New: Microsoft.Quantum/preview/2019-11-04-preview/quantum.json#L5

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-10-19T01:46:51Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-10-19T01:48:13Z

azure-sdk-for-python

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 35c2de7 with merge commit 63faa2fb44246756d1d1c27fa21e4c4fdb83c5b1. SDK Automation 13.0.17.20200918.2

Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-python/sdk/azure-mgmt/quantum/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/quantum/_configuration.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/quantum/_quantum_management_client.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/quantum/models/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/quantum/models/_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/quantum/models/_models_py3.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/quantum/models/_paged_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/quantum/models/_quantum_management_client_enums.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/quantum/operations/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/quantum/operations/_offerings_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/quantum/operations/_workspaces_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/quantum/version.py

openapi-sdkautomation · 2020-10-19T01:48:14Z

azure-sdk-for-js

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 35c2de7 with merge commit 63faa2fb44246756d1d1c27fa21e4c4fdb83c5b1. SDK Automation 13.0.17.20200918.2
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-10-19T01:48:17Z

azure-sdk-for-go

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 35c2de7 with merge commit 63faa2fb44246756d1d1c27fa21e4c4fdb83c5b1. SDK Automation 13.0.17.20200918.2
️✔️preview/quantum/mgmt/2019-11-04-preview [View full logs] [Preview SDK Changes]
- preview.quantum.mgmt.2019-11-04-preview.zip

openapi-sdkautomation · 2020-10-19T01:48:17Z

azure-sdk-for-net

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-10-19T01:48:18Z

azure-resource-manager-schemas

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-10-19T01:48:19Z

azure-sdk-for-java

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 35c2de7 with merge commit 63faa2fb44246756d1d1c27fa21e4c4fdb83c5b1. SDK Automation 13.0.17.20200918.2
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-10-19T01:48:21Z

Trenton Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-10-19T01:48:26Z

Azure CLI Extension Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-workflow-bot · 2020-10-19T19:11:47Z

Hi, @anpaz Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2020-10-19T19:12:07Z

Hi, @anpaz your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @${PRAssignee}

...ification/quantum/resource-manager/Microsoft.Quantum/preview/2019-11-04-preview/quantum.json

chiragg4u · 2020-11-03T05:13:24Z

Please remove the draft flag if you would like to get the review started.

chiragg4u · 2020-11-03T05:15:45Z

While adding new version the recommendation is to copy the existing version into new directory structure for first commit and then push new changes for easy review. Please create new branch with this recommendation for faster review.
In case this is a new RP please schedule meeting with ARM API review board, if the review meeting was done please share the review notes with the ARM api review board for reviewing.

j5lim · 2021-01-12T21:05:28Z

...ification/quantum/resource-manager/Microsoft.Quantum/preview/2019-11-04-preview/quantum.json

+      "type": "object",
+      "description": "The resource proxy definition object for quantum workspace.",
+      "properties": {
+        "id": {


Workspace looks like a tracked resource type. It must support PATCH to patch tags at least.
https://armwiki.azurewebsites.net/api_contracts/guidelines/rpc.html#rpc007-resource-types-must-support-patch-for-tags

j5lim

Approving from ARM side.

j5lim · 2021-01-13T20:24:45Z

...ification/quantum/resource-manager/Microsoft.Quantum/preview/2019-11-04-preview/quantum.json

+    "QuantumWorkspace": {
+      "type": "object",
+      "description": "The resource proxy definition object for quantum workspace.",
+      "properties": {


Adding SystemData (a new top level property for system metadata) is recommended. But it is not a blocker.

https://armwiki.azurewebsites.net/rpaas/systemdata.html

masenol · 2021-01-13T20:36:54Z

@njuCZ Could you help in merging this PR? Thanks in advance.

masenol · 2021-01-15T19:13:37Z

/azp run unifiedPipeline

azure-pipelines · 2021-01-15T19:13:43Z

Commenter does not have sufficient privileges for PR 11266 in repo Azure/azure-rest-api-specs

masenol · 2021-01-15T19:19:30Z

/azp run unifiedPipeline

azure-pipelines · 2021-01-15T19:19:35Z

Commenter does not have sufficient privileges for PR 11266 in repo Azure/azure-rest-api-specs

masenol · 2021-01-15T19:38:04Z

/azp run unifiedPipeline

azure-pipelines · 2021-01-15T19:38:22Z

Commenter does not have sufficient privileges for PR 11266 in repo Azure/azure-rest-api-specs

…review/2019-11-04-preview (Azure#11266) * New Readme Config File * New Go Language Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New Ruby Language Readme Config File * New Swagger Spec File * New Swagger Example Spec File * New Swagger for Azure Quantum RP * Adding MSI fields * Incorporating ARM feedback (Azure#1) * Picking up changes from RPSaaS. * -ruby * go * clean up readme config * -java * preview path * python version * incorporate feedback * read-only * ids * prettier * removing patch * addressing feedback * prettier fix * removing tags - coming from TrackedResource * un-referencing trackedresource * adding patch, referring to the common-type tracked resource * prettier fix * Adds suppression to readme * Adds suppression to readme Co-authored-by: Adele Bai <adbai@microsoft.com> Co-authored-by: Mahmut Burak Senol <masenol@microsoft.com> Co-authored-by: masenol <54191670+masenol@users.noreply.github.com>

* Incorporating feedback from ARM review * whitespace * azure-validator=true * fixing delete examples * fixing operations schema. * r4023 * prettier * readmes * preview folder * -ruby * python version * incorporating feedback.

anpaz added 9 commits October 18, 2020 18:43

New Readme Config File

8c47305

New Go Language Readme Config File

c189491

New Typescript Language Readme Config File

11f24e1

New Python Language Readme Config File

25bfde1

New C# Language Readme Config File

b4dd02c

New Ruby Language Readme Config File

6aaff00

New Swagger Spec File

b9e72f9

New Swagger Example Spec File

ea78b3f

New Swagger for Azure Quantum RP

4b650cb

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 19, 2020

ricardo-espinoza reviewed Oct 20, 2020

View reviewed changes

...ification/quantum/resource-manager/Microsoft.Quantum/preview/2019-11-04-preview/quantum.json Show resolved Hide resolved

fearthecowboy reviewed Nov 2, 2020

View reviewed changes

...ification/quantum/resource-manager/Microsoft.Quantum/preview/2019-11-04-preview/quantum.json Outdated Show resolved Hide resolved

fearthecowboy reviewed Nov 2, 2020

View reviewed changes

...ification/quantum/resource-manager/Microsoft.Quantum/preview/2019-11-04-preview/quantum.json Outdated Show resolved Hide resolved

fearthecowboy reviewed Nov 2, 2020

View reviewed changes

...ification/quantum/resource-manager/Microsoft.Quantum/preview/2019-11-04-preview/quantum.json Outdated Show resolved Hide resolved

fearthecowboy reviewed Nov 2, 2020

View reviewed changes

...ification/quantum/resource-manager/Microsoft.Quantum/preview/2019-11-04-preview/quantum.json Outdated Show resolved Hide resolved

Adding MSI fields

35c2de7

removing tags - coming from TrackedResource

48fbef7

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Jan 11, 2021

un-referencing trackedresource

d5dc61c

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Jan 12, 2021

j5lim self-requested a review January 12, 2021 18:50

j5lim requested changes Jan 12, 2021

View reviewed changes

j5lim added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jan 12, 2021

masenol added 2 commits January 13, 2021 12:01

adding patch, referring to the common-type tracked resource

a33b387

prettier fix

7c86b61

j5lim approved these changes Jan 13, 2021

View reviewed changes

masenol added 2 commits January 15, 2021 11:33

Adds suppression to readme

8d17c75

Adds suppression to readme

a9a9e27

njuCZ approved these changes Jan 18, 2021

View reviewed changes

njuCZ merged commit 65e3640 into Azure:master Jan 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Quantum to add version preview/2019-11-04-preview #11266

[Hub Generated] Review request for Microsoft.Quantum to add version preview/2019-11-04-preview #11266

anpaz commented Oct 19, 2020 •

edited

Loading

openapi-pipeline-app bot commented Oct 19, 2020 •

edited

Loading

azure-pipelines bot commented Oct 19, 2020

openapi-sdkautomation bot commented Oct 19, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 19, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 19, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 19, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 19, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 19, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 19, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 19, 2020 •

edited

Loading

openapi-workflow-bot bot commented Oct 19, 2020

openapi-workflow-bot bot commented Oct 19, 2020

chiragg4u commented Nov 3, 2020

chiragg4u commented Nov 3, 2020

j5lim Jan 12, 2021

j5lim left a comment

j5lim Jan 13, 2021

masenol commented Jan 13, 2021

masenol commented Jan 15, 2021

azure-pipelines bot commented Jan 15, 2021

masenol commented Jan 15, 2021

azure-pipelines bot commented Jan 15, 2021

masenol commented Jan 15, 2021

azure-pipelines bot commented Jan 15, 2021

[Hub Generated] Review request for Microsoft.Quantum to add version preview/2019-11-04-preview #11266

[Hub Generated] Review request for Microsoft.Quantum to add version preview/2019-11-04-preview #11266

Conversation

anpaz commented Oct 19, 2020 • edited Loading

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Oct 19, 2020 • edited Loading

Swagger Validation Report

azure-pipelines bot commented Oct 19, 2020

openapi-sdkautomation bot commented Oct 19, 2020 • edited Loading

azure-sdk-for-python

openapi-sdkautomation bot commented Oct 19, 2020 • edited Loading

azure-sdk-for-js

openapi-sdkautomation bot commented Oct 19, 2020 • edited Loading

azure-sdk-for-go

openapi-sdkautomation bot commented Oct 19, 2020 • edited Loading

azure-sdk-for-net

openapi-sdkautomation bot commented Oct 19, 2020 • edited Loading

azure-resource-manager-schemas

openapi-sdkautomation bot commented Oct 19, 2020 • edited Loading

azure-sdk-for-java

openapi-sdkautomation bot commented Oct 19, 2020 • edited Loading

Trenton Generation

openapi-sdkautomation bot commented Oct 19, 2020 • edited Loading

Azure CLI Extension Generation

openapi-workflow-bot bot commented Oct 19, 2020

openapi-workflow-bot bot commented Oct 19, 2020

chiragg4u commented Nov 3, 2020

chiragg4u commented Nov 3, 2020

j5lim Jan 12, 2021

Choose a reason for hiding this comment

j5lim left a comment

Choose a reason for hiding this comment

j5lim Jan 13, 2021

Choose a reason for hiding this comment

masenol commented Jan 13, 2021

masenol commented Jan 15, 2021

azure-pipelines bot commented Jan 15, 2021

masenol commented Jan 15, 2021

azure-pipelines bot commented Jan 15, 2021

masenol commented Jan 15, 2021

azure-pipelines bot commented Jan 15, 2021

anpaz commented Oct 19, 2020 •

edited

Loading

openapi-pipeline-app bot commented Oct 19, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 19, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 19, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 19, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 19, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 19, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 19, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 19, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 19, 2020 •

edited

Loading