Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.DataLakeAnalytics to add version preview/2015-10-01-preview #11289

Merged
merged 59 commits into from
Jan 11, 2021
Merged

[Hub Generated] Review request for Microsoft.DataLakeAnalytics to add version preview/2015-10-01-preview #11289

merged 59 commits into from
Jan 11, 2021

Conversation

sravan251
Copy link

@sravan251 sravan251 commented Oct 20, 2020 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 20, 2020 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️LintDiff succeeded [Detail] [Expand] 
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 20, 2020 •
edited
Loading

azure-sdk-for-java

❌ failed [Logs] [Expand Details]
  • ❌ Generate from ccebbbc with merge commit 7b556a8071a23a6a9168f739856d36e5a3e33e9f. SDK Automation 13.0.17.20200918.2 
    [AutoRest] FATAL: System.ArgumentException: An item with the same key has already been added. Key: accounts
[AutoRest]    at System.ThrowHelper.ThrowAddingDuplicateWithKeyArgumentException(Object key)
[AutoRest]    at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
[AutoRest]    at System.Collections.Generic.Dictionary`2.Add(TKey key, TValue value)
[AutoRest]    at AutoRest.Java.Azure.Fluent.Model.SegmentFluentMethodGroups.Add(SegmentFluentMethodGroupList list) in /home/vsts/work/1/s/src/azurefluent/Model/FluentCommon/FluentMethodGroup/SegmentFluentMethodGroup/SegmentFluentMethodGroups.cs:line 66
[AutoRest]    at AutoRest.Java.Azure.Fluent.Model.SegmentFluentMethodGroups.InnerMethodGroupToSegmentFluentMethodGroups(CodeModelJvaf codeModel) in /home/vsts/work/1/s/src/azurefluent/Model/FluentCommon/FluentMethodGroup/SegmentFluentMethodGroup/SegmentFluentMethodGroups.cs:line 79
[AutoRest]    at AutoRest.Java.Azure.Fluent.CodeGeneratorJvaf.d__6.MoveNext() in /home/vsts/work/1/s/src/azurefluent/CodeGeneratorJvaf.cs:line 55
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at AutoRest.Java.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 114
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
[AutoRest]    at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
[AutoRest] FATAL: java/generate - FAILED
[AutoRest] FATAL: Error: Plugin java reported failure.
[AutoRest] Failure during batch task - {"tag":"package-2015-10-preview"} -- Error: Plugin java reported failure..
[AutoRest]   Error: Plugin java reported failure.
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --version=V2 --java --verbose --multiapi --use=@microsoft.azure/autorest.java@preview --azure-libraries-for-java-folder=/z/work/azure-sdk-for-java /z/work/azure-rest-api-specs/specification/datalake-analytics/resource-manager/readme.md FATAL: System.ArgumentException: An item with the same key has already been added. Key: accounts
   at System.ThrowHelper.ThrowAddingDuplicateWithKeyArgumentException(Object key)
   at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
   at System.Collections.Generic.Dictionary`2.Add(TKey key, TValue value)
   at AutoRest.Java.Azure.Fluent.Model.SegmentFluentMethodGroups.Add(SegmentFluentMethodGroupList list) in /home/vsts/work/1/s/src/azurefluent/Model/FluentCommon/FluentMethodGroup/SegmentFluentMethodGroup/SegmentFluentMethodGroups.cs:line 66
   at AutoRest.Java.Azure.Fluent.Model.SegmentFluentMethodGroups.InnerMethodGroupToSegmentFluentMethodGroups(CodeModelJvaf codeModel) in /home/vsts/work/1/s/src/azurefluent/Model/FluentCommon/FluentMethodGroup/SegmentFluentMethodGroup/SegmentFluentMethodGroups.cs:line 79
   at AutoRest.Java.Azure.Fluent.CodeGeneratorJvaf.d__6.MoveNext() in /home/vsts/work/1/s/src/azurefluent/CodeGeneratorJvaf.cs:line 55
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Java.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 114
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
FATAL: java/generate - FAILED
FATAL: Error: Plugin java reported failure.
Failure during batch task - {"tag":"package-2015-10-preview"} -- Error: Plugin java reported failure..
  Error: Plugin java reported failure.
, {} 
Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 20, 2020 •
edited
Loading

Azure CLI Extension Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 20, 2020 •
edited
Loading

azure-sdk-for-js

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 20, 2020 •
edited
Loading

azure-sdk-for-go

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 20, 2020 •
edited
Loading

azure-sdk-for-net

❌ failed [Logs] [Expand Details]
  • ❌ Generate from ccebbbc with merge commit 7b556a8071a23a6a9168f739856d36e5a3e33e9f. SDK Automation 13.0.17.20200918.2 
    [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
  • ❌Microsoft.Azure.Management.DataLake.Analytics [View full logs]  [Preview SDK Changes] 
      Failed to create the package Microsoft.Azure.Management.DataLake.Analytics.
Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=datalake-analytics /v:n /p:SkipTests=true , {}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 20, 2020 •
    edited
    Loading

    azure-sdk-for-python

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from ccebbbc with merge commit 7b556a8071a23a6a9168f739856d36e5a3e33e9f. SDK Automation 13.0.17.20200918.2
    • ️✔️azure-mgmt-datalake-analytics [View full logs]  [Preview SDK Changes] 
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-datalake-analytics
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-datalake-analytics
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 6.354% size of original (original: 110297 chars, delta: 7008 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model DataLakeAnalyticsAccount has a new parameter hive_metastores
[ChangeLog]   - Model DataLakeAnalyticsAccount has a new parameter virtual_network_rules
[ChangeLog]   - Model DataLakeAnalyticsAccount has a new parameter debug_data_access_level
[ChangeLog]   - Model Operation has a new parameter properties

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 20, 2020 •
    edited
    Loading

    Trenton Generation

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 20, 2020 •
    edited
    Loading

    azure-resource-manager-schemas

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from ccebbbc with merge commit 7b556a8071a23a6a9168f739856d36e5a3e33e9f. Schema Automation 13.0.17.20200918.2 
      [datalake-analytics][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
[datalake-analytics][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
[datalake-analytics][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    • ⚠️datalake-analytics [View full logs]  [Preview Schema Changes] 
        [after_scripts|node] PostProcessor finished successfully.
[after_scripts|node]   5787 passing (1m)
[after_scripts|node]   3 failing
AzureResourceSchema has no registered package commands.

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Oct 20, 2020 •
      edited
      Loading

      azure-sdk-for-python-track2

      No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      This was referenced Oct 21, 2020
      Open
      Open
      Open
      Open
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Oct 21, 2020
      Open
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @PhoenixHe-NV
      Copy link
      Contributor

      /azp run

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 2 pipeline(s).

      @openapi-workflow-bot
      Copy link

      Hi @sravan251, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

      TaskHow to fixPrioritySupport (Microsoft alias)
      AvocadoFix-AvocadoHighruowan
      Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
      Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
      LintDiffFix-LintDiffhighjianyxi, ruoxuan
       If you need further help, please feedback via swagger feedback."

      @ArcturusZhang
      Copy link
      Member

      /azp run

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 2 pipeline(s).

      @openapi-workflow-bot
      Copy link

      Hi @sravan251, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

      TaskHow to fixPrioritySupport (Microsoft alias)
      AvocadoFix-AvocadoHighruowan
      Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
      Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
      LintDiffFix-LintDiffhighjianyxi, ruoxuan
       If you need further help, please feedback via swagger feedback."

      @ArcturusZhang
      Copy link
      Member

      /azp run

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 2 pipeline(s).

      @openapi-workflow-bot
      Copy link

      Hi @sravan251, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

      TaskHow to fixPrioritySupport (Microsoft alias)
      AvocadoFix-AvocadoHighruowan
      Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
      Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
      LintDiffFix-LintDiffhighjianyxi, ruoxuan
       If you need further help, please feedback via swagger feedback."

      @openapi-workflow-bot
      Copy link

      Hi @sravan251, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
      Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
      If you want to know the production traffic statistic, please see ARM Traffic statistic.
      If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

      @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 8, 2021
      @akning-ms akning-ms merged commit c1132ed into Azure:master Jan 11, 2021
      This was referenced Jan 11, 2021
      Merged
      Closed
      Closed
      Closed
      ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Jan 11, 2021
      [ReleasePR datalake-analytics] [Hub Generated] Review request for Mic…
      8ac8a7d 
      …rosoft.DataLakeAnalytics to add version preview/2015-10-01-preview (#1455)

Create to sync Azure/azure-rest-api-specs#11289
[ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/master...AzureSDKAutomation:sdkAuto/datalake-analytics?expand=1)
      @ruowan
      Copy link
      Member

      ruowan commented Jan 11, 2021

      /azp run

      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Reviewers

      @akning-ms akning-ms akning-ms left review comments

      @JeffreyRichter JeffreyRichter JeffreyRichter approved these changes

      @njuCZ njuCZ njuCZ approved these changes

      @majastrz majastrz majastrz approved these changes

      Assignees

      @njuCZ njuCZ

      Labels
      Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
      Projects
      None yet
      Milestone
      No milestone
      Development

      Successfully merging this pull request may close these issues.
      9 participants
      @sravan251 @majastrz @njuCZ @akning-ms @PhoenixHe-NV @ArcturusZhang @ruowan @JeffreyRichter @sravanthupili