[Storage] Add isNfsV3Enabled in account properties #11382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version has a new property 'isNfsV3Enabled' in response that was not found in the old version. New: Microsoft.Storage/preview/2020-08-01-preview/storage.json#L2797:7 Old: Microsoft.Storage/preview/2020-08-01-preview/storage.json#L2789:7 |
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
|
Hi, @zfchen95 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @zfchen95 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @Juliehzl |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The property is already in this API version. Update the swagger to align with server |
azure-sdk-for-go
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java
|
azure-sdk-for-net
|
azure-sdk-for-js
|
azure-sdk-for-python
- Breaking Change detected in SDK
|
azure-sdk-for-python-track2
- Breaking Change detected in SDK
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas
|
This was referenced Oct 26, 2020
This was referenced Oct 26, 2020
|
@zfchen95, any update? |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 11382 in repo Azure/azure-rest-api-specs |
|
Hi @zfchen95, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Fixed |
|
@zfchen95 |
Juliehzl
reviewed
Feb 2, 2021
| "isNfsV3Enabled": { | ||
| "type": "boolean", | ||
| "x-ms-client-name": "EnableNfsV3", | ||
| "description": "NFS 3.0 protocol support enabled if sets to true." |
There was a problem hiding this comment.
we could disable it with false value, right?
There was a problem hiding this comment.
No. This is immutable. Similar to isHnsEnabled.
Hi Wei, isNfsv3Enabled is only available for blob storage. Please refer to the example NfsV3AccountCreate.json. |
blueww
reviewed
Feb 3, 2021
| "isNfsV3Enabled": { | ||
| "type": "boolean", | ||
| "x-ms-client-name": "EnableNfsV3", | ||
| "description": "NFS 3.0 protocol support enabled if sets to true." |
There was a problem hiding this comment.
Per my test, "EnableNfsV3" can only be set to true, when create account with following parameters.
If they are necessary, please add the limitation to the description of the parameter, to make user easily to use the parameter.
- isHnsEnabled = trure
- supportsHttpsTrafficOnly = false
- create account with networkAcls.virtualNetworkRules (the rule need be in same location with the account)
- I test with following 2 combinations, both work: BlockblobStorage+Premium_LRS; StorageV2+Standard_LRS
25 tasks
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Hi, @zfchen95. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
added
the
|
close because it is already included in #12807 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.