-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Authorization to add version stable/2020-09-01 #11391
[Hub Generated] Review request for Microsoft.Authorization to add version stable/2020-09-01 #11391
Conversation
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-python-track2 - Release
|
azure-resource-manager-schemas - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Hi, @feruilob your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @${PRAssignee} |
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
Azure Pipelines successfully started running 1 pipeline(s). |
…tps://github.com/feruilob/azure-rest-api-specs into dev-resources-Microsoft.Authorization-2020-09-01
Azure Pipelines successfully started running 1 pipeline(s). |
...urce-manager/Microsoft.Authorization/stable/2020-09-01/examples/listDataPolicyManifests.json
Outdated
Show resolved
Hide resolved
Azure Pipelines successfully started running 1 pipeline(s). |
...esources/resource-manager/Microsoft.Authorization/stable/2020-09-01/dataPolicyManifests.json
Show resolved
Hide resolved
Added a couple of comments. Please take a look. |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed off from ARM side. You still need to fix the linter failures, though.
Azure Pipelines successfully started running 1 pipeline(s). |
@raych1 It looks like all required checks are passing and I have ARM signoff. Can we merge? |
There's a known issue for SDK pythonT2. |
…sion stable/2020-09-01 (Azure#11391) * Adds base for updating Microsoft.Authorization from version stable/2020-03-01 to version 2020-09-01 * Updates readme * Updates API version in new specs and examples * Adding Swagger spec for DataPolicyManifests * Bring back files from previous version for validation * Revert order in which definitions appear in swagger spec for DataPolicyManifests * Fixing array of class * Fix identation and version * Fix properties in example and bad title * Remove description from items * Fix bug in array of DataManifestCustomResourceFunctionDefinition * Fixing invalid namespaces type * Fixed bug in array for alias paths * Add dataPolicyManifest to readme * Adding data policy manifests operation endpoint * Revert "Adding data policy manifests operation endpoint" This reverts commit 59fe703. * Adds suppression to readme * Remove files from previous versions * Adds suppression to readme * Adds suppression to readme * Add sample response for getting data policy manifests with namespace filter * Removing paging and adding 404 response * Fixing resource types and namespaces * Addressing comments in PR * Adding 404 response code to example * Removing schema from 404 response (couldn't find any similar example) * Adds suppression to readme * Fix comma typo * Adds suppression to readme * Committing changes done by prettier * Change effect for audit effect * Readding x-ms-pageable * Removing 404 response * Put nextLink in the correct place in the definition
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.