Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding API to support generating access token for ApplicationInsights Profiler #11393

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
1ef788f
Adds base for updating Microsoft.Insights from version preview/2020-1…
xiaomi7732 Oct 26, 2020
59a72dc
Updates readme
xiaomi7732 Oct 26, 2020
a87f41b
Updates API version in new specs and examples
xiaomi7732 Oct 26, 2020
a2e265d
Update readme to pointing to profilerToken_API.json
xiaomi7732 Oct 26, 2020
46ff319
Update operations list
xiaomi7732 Oct 26, 2020
9728c35
Add profiler token getter
xiaomi7732 Oct 26, 2020
80581bb
Wire up the defintions
xiaomi7732 Oct 26, 2020
36333f7
Fix error: additonal property of liveToken
xiaomi7732 Oct 26, 2020
2b71dca
Append post action
xiaomi7732 Oct 26, 2020
7d52827
Update api-version for example
xiaomi7732 Oct 26, 2020
e54255e
Fix some small issues
xiaomi7732 Oct 27, 2020
2b26c84
Update readme for the resolving autorest check issue
xiaomi7732 Oct 28, 2020
37c1aeb
From profilertoken to profilerToken
xiaomi7732 Oct 28, 2020
78aa0c5
Ran prettier
xiaomi7732 Oct 28, 2020
0497a60
Appending back missing readme for 2020-10 tag
xiaomi7732 Oct 30, 2020
025ac73
Fix some mistakes
xiaomi7732 Oct 30, 2020
fc1cf17
Use common error response
xiaomi7732 Oct 31, 2020
f33bbfe
Tag secret with x-ms-secret
xiaomi7732 Nov 5, 2020
2c5d0e7
Remove list operations
xiaomi7732 Nov 6, 2020
490b8b8
Clean up packages
xiaomi7732 Nov 6, 2020
41024e9
Making 2 post operations for token
xiaomi7732 Nov 6, 2020
55daced
Remove unused operations_list.json example
xiaomi7732 Nov 6, 2020
a69e830
Align with official master
xiaomi7732 Nov 6, 2020
89c9927
Resolve conflicts
xiaomi7732 Nov 6, 2020
4ae6576
Add x-ms-secret for the token
xiaomi7732 Nov 6, 2020
f1169d5
Update error response schema ref
xiaomi7732 Nov 6, 2020
26ea7f5
Update operation ids
xiaomi7732 Nov 6, 2020
614c135
Remove unused error response
xiaomi7732 Nov 10, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,144 @@
{
"swagger": "2.0",
"info": {
"title": "ApplicationInsightsManagementClient",
"description": "Azure Application Insights client for application insights diagnostic services token.",
"version": "2020-10-26-preview"
},
"host": "management.azure.com",
"schemes": [
"https"
],
"consumes": [
"application/json"
],
"produces": [
"application/json"
],
"security": [
{
"azure_auth": [
"user_impersonation"
]
}
],
"securityDefinitions": {
"azure_auth": {
"type": "oauth2",
"authorizationUrl": "https://login.microsoftonline.com/common/oauth2/authorize",
"flow": "implicit",
"description": "Azure Active Directory OAuth2 Flow.",
"scopes": {
"user_impersonation": "impersonate your user account"
}
}
},
"paths": {
"/{resourceUri}/providers/Microsoft.Insights/generateDiagnosticServiceReadOnlyToken": {
"post": {
"tags": [
"generateDiagnosticServiceReadOnlyToken"
],
"operationId": "GenerateDiagnosticServiceReadOnlyToken",
"description": "**Gets an read-only access token for application insights diagnostic service data.**",
"parameters": [
{
"$ref": "#/parameters/ResourceUriParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ApiVersionParameter"
}
],
"responses": {
"default": {
"description": "Error response describing why the operation failed .",
"schema": {
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
}
},
"200": {
"description": "Successful response containing the application insights diagnostic services token.",
"schema": {
"$ref": "#/definitions/DiagnosticServicesTokenResponse"
},
"examples": {
"application/json": {
"token": "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiaWF0IjoxNTE2MjM5MDIyfQ.SflKxwRJSMeKKF2QT4fwpMeJf36POk6yJV_adQssw5c"
}
}
}
},
"x-ms-examples": {
"Get diagnostic services token for resource": {
"$ref": "./examples/DiagnosticServicesTokenPost.json"
}
}
}
},
"/{resourceUri}/providers/Microsoft.Insights/generateDiagnosticServiceReadWriteToken": {
"post": {
xiaomi7732 marked this conversation as resolved.
Show resolved Hide resolved
"tags": [
"generateDiagnosticServiceReadWriteToken"
],
"operationId": "GenerateDiagnosticServiceReadWriteToken",
"description": "**Gets an read-write access token for application insights diagnostic service data.**",
"parameters": [
{
"$ref": "#/parameters/ResourceUriParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ApiVersionParameter"
}
],
"responses": {
"default": {
"description": "Error response describing why the operation failed .",
"schema": {
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse"
}
},
"200": {
"description": "Successful response containing the application insights diagnostic services token.",
"schema": {
"$ref": "#/definitions/DiagnosticServicesTokenResponse"
},
"examples": {
"application/json": {
"token": "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiaWF0IjoxNTE2MjM5MDIyfQ.SflKxwRJSMeKKF2QT4fwpMeJf36POk6yJV_adQssw5c"
}
}
}
},
"x-ms-examples": {
"Get diagnostic services token for resource": {
"$ref": "./examples/DiagnosticServicesTokenPost.json"
}
}
}
}
},
"definitions": {
"DiagnosticServicesTokenResponse": {
"type": "object",
"properties": {
"token": {
xiaomi7732 marked this conversation as resolved.
Show resolved Hide resolved
"x-ms-secret": true,
"type": "string",
"description": "JWT token for accessing application insights diagnostic service data."
}
},
"description": "The response to a diagnostic services token query."
}
},
"parameters": {
"ResourceUriParameter": {
"name": "resourceUri",
"in": "path",
"required": true,
"type": "string",
"description": "The identifier of the resource.",
"x-ms-parameter-location": "method",
"x-ms-skip-url-encoding": true
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"parameters": {
"resourceUri": "subscriptions/df602c9c-7aa0-407d-a6fb-eb20c8bd1192/resourceGroups/FabrikamFiberApp/providers/microsoft.insights/components/CustomAvailabilityTest/providers/Microsoft.Insights/diagnosticServicesToken",
"api-version": "2020-10-26-preview"
},
"responses": {
"200": {
"body": {
"token": "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiaWF0IjoxNTE2MjM5MDIyfQ.SflKxwRJSMeKKF2QT4fwpMeJf36POk6yJV_adQssw5c"
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,17 @@ batch:

Please also specify `--azureresourceschema-folder=<path to the root directory of your azure-resource-manager-schemas clone>`.

### Tag: schema-insights-2020-10-26-preview and azureresourceschema

``` yaml $(tag) == 'schema-insights-2020-10-26-preview' && $(azureresourceschema)
output-folder: $(azureresourceschema-folder)/schemas

# all the input files in this apiVersion
input-file:
- Microsoft.Insights/preview/2020-10-26-preview/diagnosticServicesToken_API.json

```

### Tag: schema-insights-2020-06-02-preview and azureresourceschema

``` yaml $(tag) == 'schema-insights-2020-06-02-preview' && $(azureresourceschema)
Expand Down
16 changes: 15 additions & 1 deletion specification/applicationinsights/resource-manager/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,20 @@ directive:
reason: 'get workbook list by subscription is not supported'
- suppress: OperationsAPIImplementation
reason: 'Previously implemented operation apis are using an incorrect RP case format which I cannot change.'
- suppress: SECRET_PROPERTY
from: diagnosticServicesToken_API.json
where:
- $.definitions.DiagnosticServicesTokenResponse.properties.token
reason: 'Secrets are OK to return in a POST response.'
```

### Tag: package-preview-2020-10-26-only

These settings apply only when `--tag=package-preview-2020-10-26-only` is specified on the command line.

``` yaml $(tag) == 'package-preview-2020-10-26-only'
input-file:
- Microsoft.Insights/preview/2020-10-26-preview/diagnosticServicesToken_API.json
```

### Tag: package-2020-10-20
Expand Down Expand Up @@ -479,4 +493,4 @@ input-file:

## AzureResourceSchema

See configuration in [readme.azureresourceschema.md](./readme.azureresourceschema.md)
See configuration in [readme.azureresourceschema.md](./readme.azureresourceschema.md)