Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added event grid filters read APIs for Microsoft.AppConfiguration. #11451

Closed

Conversation

jimmyca15
Copy link
Member

The Microsoft.AppConfiguration supports sending to events to event grid. Thus we implement the standard /eventGridFilters API. These have been called out as undocumented by live validation.

Autorest validation results in no errors.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 29, 2020

Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail] [Expand]

Rule Message
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.AppConfiguration/preview/2020-07-01-preview/appconfiguration.json#L1017:5
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.AppConfiguration/preview/2020-07-01-preview/appconfiguration.json#L1069:5
️⚠️~[Staging] LintDiff: 2 Warnings warning [Detail] [Expand]

Rule Message
⚠️ R4009 - RequiredSystemDataInNewApiVersions The response of operation:'EventGridFilters_ListByConfigurationStore' is defined without 'systemData'. Consider adding the systemData to the response.
New: Microsoft.AppConfiguration/preview/2020-07-01-preview/appconfiguration.json#L1018
⚠️ R4009 - RequiredSystemDataInNewApiVersions The response of operation:'EventGridFilters_Get' is defined without 'systemData'. Consider adding the systemData to the response.
New: Microsoft.AppConfiguration/preview/2020-07-01-preview/appconfiguration.json#L1070
️️✔️~[Staging] Avocado succeeded [Detail]
Validation passes for Avocado.
️️✔️~[Staging] ModelValidation succeeded [Detail]
Validation passes for ModelValidation.
️️✔️~[Staging] SemanticValidation succeeded [Detail]
Validation passes for SemanticValidation.
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 29, 2020

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 7b8802b with merge commit db8f7ece883abefc7099bd3ddfe5690cf62e3625. SDK Automation 13.0.17.20200918.2
  • ️✔️@azure/arm-appconfiguration [View full logs]  [Preview SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/appConfigurationManagementClient.js → ./dist/arm-appconfiguration.js...
    [npmPack] created ./dist/arm-appconfiguration.js in 372ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/arm-appconfiguration@1.3.0
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 1.9kB   esm/appConfigurationManagementClient.js              
    [npmPack] npm notice 2.5kB   esm/appConfigurationManagementClientContext.js       
    [npmPack] npm notice 105.7kB dist/arm-appconfiguration.js                         
    [npmPack] npm notice 36.1kB  dist/arm-appconfiguration.min.js                     
    [npmPack] npm notice 15.6kB  esm/operations/configurationStores.js                
    [npmPack] npm notice 768B    esm/models/configurationStoresMappers.js             
    [npmPack] npm notice 4.0kB   esm/operations/eventGridFilters.js                   
    [npmPack] npm notice 675B    esm/models/eventGridFiltersMappers.js                
    [npmPack] npm notice 263B    esm/models/index.js                                  
    [npmPack] npm notice 486B    esm/operations/index.js                              
    [npmPack] npm notice 7.4kB   esm/operations/keyValues.js                          
    [npmPack] npm notice 661B    esm/models/keyValuesMappers.js                       
    [npmPack] npm notice 35.9kB  esm/models/mappers.js                                
    [npmPack] npm notice 3.4kB   esm/operations/operations.js                         
    [npmPack] npm notice 576B    esm/models/operationsMappers.js                      
    [npmPack] npm notice 2.8kB   esm/models/parameters.js                             
    [npmPack] npm notice 9.8kB   esm/operations/privateEndpointConnections.js         
    [npmPack] npm notice 695B    esm/models/privateEndpointConnectionsMappers.js      
    [npmPack] npm notice 4.0kB   esm/operations/privateLinkResources.js               
    [npmPack] npm notice 402B    esm/models/privateLinkResourcesMappers.js            
    [npmPack] npm notice 928B    rollup.config.js                                     
    [npmPack] npm notice 1.7kB   package.json                                         
    [npmPack] npm notice 457B    tsconfig.json                                        
    [npmPack] npm notice 834B    esm/appConfigurationManagementClient.d.ts.map        
    [npmPack] npm notice 1.0kB   esm/appConfigurationManagementClient.js.map          
    [npmPack] npm notice 530B    esm/appConfigurationManagementClientContext.d.ts.map 
    [npmPack] npm notice 1.4kB   esm/appConfigurationManagementClientContext.js.map   
    [npmPack] npm notice 225.9kB dist/arm-appconfiguration.js.map                     
    [npmPack] npm notice 30.8kB  dist/arm-appconfiguration.min.js.map                 
    [npmPack] npm notice 4.6kB   esm/operations/configurationStores.d.ts.map          
    [npmPack] npm notice 8.0kB   esm/operations/configurationStores.js.map            
    [npmPack] npm notice 453B    esm/models/configurationStoresMappers.d.ts.map       
    [npmPack] npm notice 466B    esm/models/configurationStoresMappers.js.map         
    [npmPack] npm notice 1.7kB   esm/operations/eventGridFilters.d.ts.map             
    [npmPack] npm notice 2.3kB   esm/operations/eventGridFilters.js.map               
    [npmPack] npm notice 398B    esm/models/eventGridFiltersMappers.d.ts.map          
    [npmPack] npm notice 411B    esm/models/eventGridFiltersMappers.js.map            
    [npmPack] npm notice 15.4kB  esm/models/index.d.ts.map                            
    [npmPack] npm notice 250B    esm/operations/index.d.ts.map                        
    [npmPack] npm notice 126B    esm/models/index.js.map                              
    [npmPack] npm notice 264B    esm/operations/index.js.map                          
    [npmPack] npm notice 2.5kB   esm/operations/keyValues.d.ts.map                    
    [npmPack] npm notice 3.9kB   esm/operations/keyValues.js.map                      
    [npmPack] npm notice 384B    esm/models/keyValuesMappers.d.ts.map                 
    [npmPack] npm notice 397B    esm/models/keyValuesMappers.js.map                   
    [npmPack] npm notice 2.0kB   esm/models/mappers.d.ts.map                          
    [npmPack] npm notice 20.2kB  esm/models/mappers.js.map                            
    [npmPack] npm notice 1.5kB   esm/operations/operations.d.ts.map                   
    [npmPack] npm notice 2.1kB   esm/operations/operations.js.map                     
    [npmPack] npm notice 316B    esm/models/operationsMappers.d.ts.map                
    [npmPack] npm notice 329B    esm/models/operationsMappers.js.map                  
    [npmPack] npm notice 684B    esm/models/parameters.d.ts.map                       
    [npmPack] npm notice 2.1kB   esm/models/parameters.js.map                         
    [npmPack] npm notice 2.5kB   esm/operations/privateEndpointConnections.d.ts.map   
    [npmPack] npm notice 4.3kB   esm/operations/privateEndpointConnections.js.map     
    [npmPack] npm notice 418B    esm/models/privateEndpointConnectionsMappers.d.ts.map
    [npmPack] npm notice 431B    esm/models/privateEndpointConnectionsMappers.js.map  
    [npmPack] npm notice 1.7kB   esm/operations/privateLinkResources.d.ts.map         
    [npmPack] npm notice 2.3kB   esm/operations/privateLinkResources.js.map           
    [npmPack] npm notice 235B    esm/models/privateLinkResourcesMappers.d.ts.map      
    [npmPack] npm notice 248B    esm/models/privateLinkResourcesMappers.js.map        
    [npmPack] npm notice 3.4kB   README.md                                            
    [npmPack] npm notice 1.4kB   esm/appConfigurationManagementClient.d.ts            
    [npmPack] npm notice 2.1kB   src/appConfigurationManagementClient.ts              
    [npmPack] npm notice 848B    esm/appConfigurationManagementClientContext.d.ts     
    [npmPack] npm notice 2.3kB   src/appConfigurationManagementClientContext.ts       
    [npmPack] npm notice 13.8kB  esm/operations/configurationStores.d.ts              
    [npmPack] npm notice 26.1kB  src/operations/configurationStores.ts                
    [npmPack] npm notice 540B    esm/models/configurationStoresMappers.d.ts           
    [npmPack] npm notice 761B    src/models/configurationStoresMappers.ts             
    [npmPack] npm notice 4.8kB   esm/operations/eventGridFilters.d.ts                 
    [npmPack] npm notice 8.7kB   src/operations/eventGridFilters.ts                   
    [npmPack] npm notice 447B    esm/models/eventGridFiltersMappers.d.ts              
    [npmPack] npm notice 663B    src/models/eventGridFiltersMappers.ts                
    [npmPack] npm notice 46.1kB  esm/models/index.d.ts                                
    [npmPack] npm notice 255B    esm/operations/index.d.ts                            
    [npmPack] npm notice 44.1kB  src/models/index.ts                                  
    [npmPack] npm notice 454B    src/operations/index.ts                              
    [npmPack] npm notice 7.9kB   esm/operations/keyValues.d.ts                        
    [npmPack] npm notice 13.9kB  src/operations/keyValues.ts                          
    [npmPack] npm notice 433B    esm/models/keyValuesMappers.d.ts                     
    [npmPack] npm notice 656B    src/models/keyValuesMappers.ts                       
    [npmPack] npm notice 2.7kB   esm/models/mappers.d.ts                              
    [npmPack] npm notice 28.4kB  src/models/mappers.ts                                
    [npmPack] npm notice 3.5kB   esm/operations/operations.d.ts                       
    [npmPack] npm notice 6.8kB   src/operations/operations.ts                         
    [npmPack] npm notice 348B    esm/models/operationsMappers.d.ts                    

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 29, 2020

azure-resource-manager-schemas

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 7b8802b with merge commit db8f7ece883abefc7099bd3ddfe5690cf62e3625. Schema Automation 13.0.17.20200918.2
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 29, 2020

azure-sdk-for-python

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 7b8802b with merge commit db8f7ece883abefc7099bd3ddfe5690cf62e3625. SDK Automation 13.0.17.20200918.2
  • ⚠️azure-mgmt-appconfiguration [View full logs]  [Preview SDK Changes] Breaking Change Detected
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-appconfiguration
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-appconfiguration
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    [breaking_change_setup] You must give at least one requirement to install (see "pip help install")
    [ChangeLog] Size of delta 38.091% size of original (original: 24334 chars, delta: 9269 chars)
    [ChangeLog] **Features**
    [ChangeLog] 
    [ChangeLog]   - Model KeyValue has a new parameter type
    [ChangeLog]   - Model KeyValue has a new parameter id
    [ChangeLog]   - Model KeyValue has a new parameter name
    [ChangeLog]   - Model OperationDefinition has a new parameter is_data_action
    [ChangeLog]   - Model OperationDefinition has a new parameter properties
    [ChangeLog]   - Model OperationDefinition has a new parameter origin
    [ChangeLog]   - Added operation group KeyValuesOperations
    [ChangeLog]   - Added operation group EventGridFiltersOperations
    [ChangeLog] 
    [ChangeLog] **Breaking changes**
    [ChangeLog] 
    [ChangeLog]   - Model ConfigurationStoreUpdateParameters no longer has parameter public_network_access
    [ChangeLog]   - Removed operation ConfigurationStoresOperations.list_key_value

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 29, 2020

Azure CLI Extension Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 29, 2020

Trenton Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 29, 2020

azure-sdk-for-go

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 29, 2020

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 7b8802b with merge commit db8f7ece883abefc7099bd3ddfe5690cf62e3625. SDK Automation 13.0.17.20200918.2
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.AppConfiguration [View full logs]  [Preview SDK Changes]
      No Artifact Generated.

    @PhoenixHe-NV
    Copy link
    Contributor

    @jimmyca15 Please fix the model validation error

    @PhoenixHe-NV PhoenixHe-NV added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Nov 2, 2020
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 2, 2020

    Swagger Generation Artifacts

    ️️✔️~[Staging] ApiDocPreview succeeded [Detail]
     Please click here to preview with your @microsoft account. 
    Posted by Swagger Pipeline | How to fix these errors?

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 2, 2020

    azure-sdk-for-python-track2

    - Breaking Change detected in SDK

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 7b8802b with merge commit db8f7ece883abefc7099bd3ddfe5690cf62e3625. SDK Automation 13.0.17.20200918.2
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
    • ⚠️azure-mgmt-appconfiguration [View full logs]  [Preview SDK Changes] Breaking Change Detected
      [build_conf_init]   Cache entry deserialization failed, entry ignored
      [build_conf_init]   Cache entry deserialization failed, entry ignored
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-appconfiguration
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-appconfiguration
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 37.316% size of original (original: 24855 chars, delta: 9275 chars)
      [ChangeLog] **Features**
      [ChangeLog] 
      [ChangeLog]   - Model OperationDefinition has a new parameter is_data_action
      [ChangeLog]   - Model OperationDefinition has a new parameter origin
      [ChangeLog]   - Model OperationDefinition has a new parameter properties
      [ChangeLog]   - Model KeyValue has a new parameter name
      [ChangeLog]   - Model KeyValue has a new parameter id
      [ChangeLog]   - Model KeyValue has a new parameter type
      [ChangeLog]   - Added operation group EventGridFiltersOperations
      [ChangeLog]   - Added operation group KeyValuesOperations
      [ChangeLog] 
      [ChangeLog] **Breaking changes**
      [ChangeLog] 
      [ChangeLog]   - Model ConfigurationStoreUpdateParameters no longer has parameter public_network_access
      [ChangeLog]   - Removed operation ConfigurationStoresOperations.list_key_value

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @jimmyca15
    Copy link
    Member Author

    @PhoenixHe-msft fixed.

    @jimmyca15
    Copy link
    Member Author

    @PhoenixHe-msft I'm thinking this should be good to merge now. Is anything else needed?

    @jimmyca15
    Copy link
    Member Author

    Swagger live validation is going to exclude this operation so we don't need to document it.

    @jimmyca15 jimmyca15 closed this Nov 5, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    CI-BreakingChange-Python Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants