-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new api changes for hostpool for start vm on connect feature #11487
Conversation
You don't have permission to trigger SDK Automation. |
Swagger Validation Report
|
Rule | Message |
---|---|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: startVMOnConnect New: Microsoft.DesktopVirtualization/preview/2020-11-02-preview/desktopvirtualization.json#L2527 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: startVMOnConnect New: Microsoft.DesktopVirtualization/preview/2020-11-02-preview/desktopvirtualization.json#L2661 |
️️✔️
~[Staging] Avocado succeeded [Detail]
Validation passes for Avocado.
️️✔️
~[Staging] ModelValidation succeeded [Detail]
Validation passes for ModelValidation.
️️✔️
~[Staging] SemanticValidation succeeded [Detail]
Validation passes for SemanticValidation.
Swagger Generation Artifacts
|
Thank you for your contribution Goxu92! We will review the pull request and get back to you soon. |
Hi, @Goxu92 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Hi, @Goxu92 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @fengzhou-msft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when adding a new api-version please make the first commit in the new folder the file from the existing apiversion folder as is. The second commit should then contain the diff over the existing apiversion.
{ | ||
"swagger": "2.0", | ||
"info": { | ||
"version": "2020-10-19-preview", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be 2020-11-02-preview?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you updated in the last commit :)
I will do this next time sorry for the trouble 1st time working on this branch :) noted ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@fengzhou-msft can you finish the pull request with initiating merge ? :) |
/azp run automation - sdk |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-python - Release
|
azure-resource-manager-schemas - Release
|
Azure CLI Extension Generation - Release
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.