Draft PR for PostgreSQLHSC #11526
Merged
Draft PR for PostgreSQLHSC #11526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change publicIpRequested boolean with publicNetworkAccess enum
Change serverGroups to ServerGroupsv2 in path and id
Swagger Validation Report
|
Swagger Generation Artifacts
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java
|
azure-sdk-for-go
|
azure-sdk-for-js
|
azure-sdk-for-net
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python
|
azure-resource-manager-schemas
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
/azp run unifiedPipeline |
|
@enescakir Is your PR is not ready yet? If so, please add DoNotMerge label. And I'll ask ARM review again after your PR is ready. Thanks |
furkansahin
commented
Dec 10, 2020
| @@ -17,6 +17,7 @@ | |||
| "enableZfs": false, | |||
| "postgresqlVersion": "12", | |||
| "citusVersion": "9.5", | |||
| "availabilityZone": "1", | |||
There was a problem hiding this comment.
Let's add the standbyAvailabilityZone too.
|
@ChenTanyi We are ready now, you can ask ARM review. |
ChenTanyi
added
WaitForARMFeedback
|
@j5lim There are lots of API changes after your |
j5lim
approved these changes
Dec 11, 2020
j5lim
added
ARMSignedOff
ChenTanyi
approved these changes
Dec 14, 2020
ChenTanyi
added
the
Approved-OkToMerge
|
@enescakir Please let me know when it ready to merge. |
|
@ChenTanyi it's ready to merge. |
This was referenced Dec 14, 2020
Closed
dabenhamMic
pushed a commit
to dabenhamMic/azure-rest-api-specs
that referenced
this pull request
Dec 14, 2020
* New Readme Config File * New Go Language Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New Ruby Language Readme Config File * New Swagger Spec File * New Swagger Example Spec File * initial swagger * common-types path fix * definition reference fix * Change publicIpRequested boolean with publicNetworkAccess enum * Change serverGroups to ServerGroupsv2 in path and id * Add responses to examples * Add missing location property to examples * Add missing locations to requests * Remove required name * Fix server group update * Convert some enums to boolean and renamings * Fix typo * Fix role properties problem * Add Citus to custom words * Run json prettier * Change responce for put server group * Fix role empty properties * Add state to server group * Update readmes * Add resourceProviderType to server group * Add sourceLocation to server group PITR * Change backup retention minutes to days * Fix linter errors * Add EarliestRestoreTime to server group * Fix semantic * Add Meru to custom words * Proviver name to pascal case * Add format for integers * Add 204 to delete * Add server group list endpoints * Fix listing operations * Change servers operation id * Remove haState from server role group * Add missing state to ServerState * Refactor configuration API * Add missing readOnly properties * Move ServerGroupConfig.defaultValue to ServerRoleGroupConfig * Rename serverRoleGroupConfigurationValues to serverRoleGroupConfigurations * Rename java namespace * Add systemData to all resources * Fix CheckNameAvailability warning * Run prettier * Add "fullyQualifiedDomainName" to server * Remove update from createMode * Remove createMode discriminator * Update ServerGet example * Add citusVersion to ServerGroupServer * Update descriptions for zfs and mx * Separate server group update properties * Add MMW to server group * Update sdk READMEs for namespaces * Refactor booleans with "enable..." prefix * Rename version with postgresqlVersion * Change vnetInjArgs to delegatedSubnetArguments * Add enableShardsOnCoordinator to server group * Add availability zone to server group and server group server * Add standbyAvailabilityZone to examples Co-authored-by: Enes Cakir <enes@cakir.web.tr>
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
* New Readme Config File * New Go Language Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New Ruby Language Readme Config File * New Swagger Spec File * New Swagger Example Spec File * initial swagger * common-types path fix * definition reference fix * Change publicIpRequested boolean with publicNetworkAccess enum * Change serverGroups to ServerGroupsv2 in path and id * Add responses to examples * Add missing location property to examples * Add missing locations to requests * Remove required name * Fix server group update * Convert some enums to boolean and renamings * Fix typo * Fix role properties problem * Add Citus to custom words * Run json prettier * Change responce for put server group * Fix role empty properties * Add state to server group * Update readmes * Add resourceProviderType to server group * Add sourceLocation to server group PITR * Change backup retention minutes to days * Fix linter errors * Add EarliestRestoreTime to server group * Fix semantic * Add Meru to custom words * Proviver name to pascal case * Add format for integers * Add 204 to delete * Add server group list endpoints * Fix listing operations * Change servers operation id * Remove haState from server role group * Add missing state to ServerState * Refactor configuration API * Add missing readOnly properties * Move ServerGroupConfig.defaultValue to ServerRoleGroupConfig * Rename serverRoleGroupConfigurationValues to serverRoleGroupConfigurations * Rename java namespace * Add systemData to all resources * Fix CheckNameAvailability warning * Run prettier * Add "fullyQualifiedDomainName" to server * Remove update from createMode * Remove createMode discriminator * Update ServerGet example * Add citusVersion to ServerGroupServer * Update descriptions for zfs and mx * Separate server group update properties * Add MMW to server group * Update sdk READMEs for namespaces * Refactor booleans with "enable..." prefix * Rename version with postgresqlVersion * Change vnetInjArgs to delegatedSubnetArguments * Add enableShardsOnCoordinator to server group * Add availability zone to server group and server group server * Add standbyAvailabilityZone to examples Co-authored-by: Enes Cakir <enes@cakir.web.tr>
|
/azp run |
This was referenced Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.