Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[acr] generate acr sdk whitespace change #11592

Closed
wants to merge 1 commit into from
Closed

[acr] generate acr sdk whitespace change #11592

wants to merge 1 commit into from

Conversation

adewaleo
Copy link
Contributor

@adewaleo adewaleo commented Nov 9, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Nov 9, 2020 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] 
There are no breaking changes.

️️✔️~[Staging] LintDiff succeeded [Detail] 
Validation passes for LintDiff.

️⚠️~[Staging] Avocado: 1 Warnings warning [Detail] [Expand]
Rule Message
⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/containerregistry/resource-manager/readme.md
tag: specification/containerregistry/resource-manager/readme.md#tag-package-2019-12-preview
️️✔️~[Staging] ModelValidation succeeded [Detail] 
Validation passes for ModelValidation.
️️✔️~[Staging] SemanticValidation succeeded [Detail] 
Validation passes for SemanticValidation.
️️✔️~[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] 
There are no breaking changes.
️️✔️~[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] 
There are no breaking changes.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Nov 9, 2020 •
edited
Loading

Swagger Generation Artifacts

️️✔️~[Staging] ApiDocPreview succeeded [Detail] 
 Please click here to preview with your @microsoft account.
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@adewaleo adewaleo changed the title [gen-sdk] whitespace change [acr] generate acr sdk whitespace change Nov 9, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Nov 9, 2020 •
edited
Loading

Azure CLI Extension Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Nov 9, 2020 •
edited
Loading

azure-sdk-for-go

❌ failed [Logs] [Expand Details]
  • ❌ Generate from 8870d66 with merge commit 7937a69e59017da0fa848e88286c9b0ca50ded09. SDK Automation 13.0.17.20200918.2 
    [AutoRest] FATAL: System.InvalidOperationException: output-folder /z/work/src/github.com/Azure/azure-sdk-for-go/services/containerregistry/mgmt/2019-06-01-preview/containerregistry of tag package-2019-06-preview must be under a preview subdirectory for a preview swagger set. Please refer the sample for readme.go.md file here https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/code-gen/configure-go-sdk.md for more information
[AutoRest]    at AutoRest.Go.CodeGeneratorGo.PreviewCheck(String folder) in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 183
[AutoRest]    at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 60
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
[AutoRest]    at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
[AutoRest] FATAL: go/generate - FAILED
[AutoRest] FATAL: Error: Plugin go reported failure.
[AutoRest] Failure during batch task - {"tag":"package-2019-06-preview"} -- Error: Plugin go reported failure..
[AutoRest]   Error: Plugin go reported failure.
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --use=@microsoft.azure/autorest.go@~2.1.157 --go --verbose --multiapi --use-onever --preview-chk --version=V2 --go-sdk-folder=/z/work/src/github.com/Azure/azure-sdk-for-go /z/work/azure-rest-api-specs/specification/containerregistry/resource-manager/readme.md FATAL: System.InvalidOperationException: output-folder /z/work/src/github.com/Azure/azure-sdk-for-go/services/containerregistry/mgmt/2019-06-01-preview/containerregistry of tag package-2019-06-preview must be under a preview subdirectory for a preview swagger set. Please refer the sample for readme.go.md file here https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/code-gen/configure-go-sdk.md for more information
   at AutoRest.Go.CodeGeneratorGo.PreviewCheck(String folder) in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 183
   at AutoRest.Go.CodeGeneratorGo.d__7.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 60
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Go.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
Failure during batch task - {"tag":"package-2019-06-preview"} -- Error: Plugin go reported failure..
  Error: Plugin go reported failure.
, {} 
Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Nov 9, 2020 •
edited
Loading

azure-sdk-for-java

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Nov 9, 2020 •
edited
Loading

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 8870d66 with merge commit 7937a69e59017da0fa848e88286c9b0ca50ded09. SDK Automation 13.0.17.20200918.2
  • ️✔️@azure/arm-containerregistry [View full logs]  [Preview SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/containerRegistryManagementClient.js → ./dist/arm-containerregistry.js...
[npmPack] created ./dist/arm-containerregistry.js in 731ms
[npmPack] npm notice 
[npmPack] npm notice package: @azure/arm-containerregistry@8.0.0
[npmPack] npm notice === Tarball Contents === 
[npmPack] npm notice 12.3kB  esm/operations/agentPools.js                         
[npmPack] npm notice 1.8kB   esm/models/agentPoolsMappers.js                      
[npmPack] npm notice 408.7kB dist/arm-containerregistry.js                        
[npmPack] npm notice 144.5kB dist/arm-containerregistry.min.js                    
[npmPack] npm notice 2.4kB   esm/containerRegistryManagementClient.js             
[npmPack] npm notice 2.5kB   esm/containerRegistryManagementClientContext.js      
[npmPack] npm notice 8.9kB   esm/operations/exportPipelines.js                    
[npmPack] npm notice 1.8kB   esm/models/exportPipelinesMappers.js                 
[npmPack] npm notice 8.9kB   esm/operations/importPipelines.js                    
[npmPack] npm notice 1.8kB   esm/models/importPipelinesMappers.js                 
[npmPack] npm notice 263B    esm/models/index.js                                  
[npmPack] npm notice 696B    esm/operations/index.js                              
[npmPack] npm notice 146.7kB esm/models/mappers.js                                
[npmPack] npm notice 2.2kB   esm/operations/operations.js                         
[npmPack] npm notice 490B    esm/models/operationsMappers.js                      
[npmPack] npm notice 6.5kB   esm/models/parameters.js                             
[npmPack] npm notice 8.7kB   esm/operations/pipelineRuns.js                       
[npmPack] npm notice 1.7kB   esm/models/pipelineRunsMappers.js                    
[npmPack] npm notice 9.7kB   esm/operations/privateEndpointConnections.js         
[npmPack] npm notice 1.8kB   esm/models/privateEndpointConnectionsMappers.js      
[npmPack] npm notice 26.4kB  esm/operations/registries.js                         
[npmPack] npm notice 2.2kB   esm/models/registriesMappers.js                      
[npmPack] npm notice 11.4kB  esm/operations/replications.js                       
[npmPack] npm notice 1.8kB   esm/models/replicationsMappers.js                    
[npmPack] npm notice 931B    rollup.config.js                                     
[npmPack] npm notice 9.1kB   esm/operations/runs.js                               
[npmPack] npm notice 1.8kB   esm/models/runsMappers.js                            
[npmPack] npm notice 11.2kB  esm/operations/scopeMaps.js                          
[npmPack] npm notice 1.8kB   esm/models/scopeMapsMappers.js                       
[npmPack] npm notice 12.0kB  esm/operations/taskRuns.js                           
[npmPack] npm notice 1.8kB   esm/models/taskRunsMappers.js                        
[npmPack] npm notice 12.0kB  esm/operations/tasks.js                              
[npmPack] npm notice 2.1kB   esm/models/tasksMappers.js                           
[npmPack] npm notice 10.9kB  esm/operations/tokens.js                             
[npmPack] npm notice 1.8kB   esm/models/tokensMappers.js                          
[npmPack] npm notice 15.2kB  esm/operations/webhooks.js                           
[npmPack] npm notice 1.9kB   esm/models/webhooksMappers.js                        
[npmPack] npm notice 1.8kB   package.json                                         
[npmPack] npm notice 457B    tsconfig.json                                        
[npmPack] npm notice 3.3kB   esm/operations/agentPools.d.ts.map                   
[npmPack] npm notice 5.9kB   esm/operations/agentPools.js.map                     
[npmPack] npm notice 1.1kB   esm/models/agentPoolsMappers.d.ts.map                
[npmPack] npm notice 1.1kB   esm/models/agentPoolsMappers.js.map                  
[npmPack] npm notice 725.5kB dist/arm-containerregistry.js.map                    
[npmPack] npm notice 105.0kB dist/arm-containerregistry.min.js.map                
[npmPack] npm notice 1.1kB   esm/containerRegistryManagementClient.d.ts.map       
[npmPack] npm notice 1.6kB   esm/containerRegistryManagementClient.js.map         
[npmPack] npm notice 501B    esm/containerRegistryManagementClientContext.d.ts.map
[npmPack] npm notice 1.4kB   esm/containerRegistryManagementClientContext.js.map  
[npmPack] npm notice 2.4kB   esm/operations/exportPipelines.d.ts.map              
[npmPack] npm notice 4.2kB   esm/operations/exportPipelines.js.map                
[npmPack] npm notice 1.1kB   esm/models/exportPipelinesMappers.d.ts.map           
[npmPack] npm notice 1.1kB   esm/models/exportPipelinesMappers.js.map             
[npmPack] npm notice 2.4kB   esm/operations/importPipelines.d.ts.map              
[npmPack] npm notice 4.2kB   esm/operations/importPipelines.js.map                
[npmPack] npm notice 1.1kB   esm/models/importPipelinesMappers.d.ts.map           
[npmPack] npm notice 1.1kB   esm/models/importPipelinesMappers.js.map             
[npmPack] npm notice 53.9kB  esm/models/index.d.ts.map                            
[npmPack] npm notice 420B    esm/operations/index.d.ts.map                        
[npmPack] npm notice 126B    esm/models/index.js.map                              
[npmPack] npm notice 434B    esm/operations/index.js.map                          
[npmPack] npm notice 7.3kB   esm/models/mappers.d.ts.map                          
[npmPack] npm notice 82.2kB  esm/models/mappers.js.map                            
[npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map                   
[npmPack] npm notice 1.4kB   esm/operations/operations.js.map                     
[npmPack] npm notice 254B    esm/models/operationsMappers.d.ts.map                
[npmPack] npm notice 267B    esm/models/operationsMappers.js.map                  
[npmPack] npm notice 1.2kB   esm/models/parameters.d.ts.map                       
[npmPack] npm notice 4.9kB   esm/models/parameters.js.map                         
[npmPack] npm notice 2.4kB   esm/operations/pipelineRuns.d.ts.map                 
[npmPack] npm notice 4.2kB   esm/operations/pipelineRuns.js.map                   
[npmPack] npm notice 1.1kB   esm/models/pipelineRunsMappers.d.ts.map              
[npmPack] npm notice 1.1kB   esm/models/pipelineRunsMappers.js.map                
[npmPack] npm notice 2.5kB   esm/operations/privateEndpointConnections.d.ts.map   
[npmPack] npm notice 4.3kB   esm/operations/privateEndpointConnections.js.map     
[npmPack] npm notice 1.1kB   esm/models/privateEndpointConnectionsMappers.d.ts.map
[npmPack] npm notice 1.1kB   esm/models/privateEndpointConnectionsMappers.js.map  
[npmPack] npm notice 7.4kB   esm/operations/registries.d.ts.map                   
[npmPack] npm notice 13.2kB  esm/operations/registries.js.map                     
[npmPack] npm notice 1.3kB   esm/models/registriesMappers.d.ts.map                
[npmPack] npm notice 1.3kB   esm/models/registriesMappers.js.map                  
[npmPack] npm notice 2.8kB   esm/operations/replications.d.ts.map                 
[npmPack] npm notice 5.3kB   esm/operations/replications.js.map                   
[npmPack] npm notice 1.1kB   esm/models/replicationsMappers.d.ts.map              
[npmPack] npm notice 1.1kB   esm/models/replicationsMappers.js.map                
[npmPack] npm notice 2.9kB   esm/operations/runs.d.ts.map                         
[npmPack] npm notice 4.9kB   esm/operations/runs.js.map

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Nov 9, 2020 •
edited
Loading

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Nov 9, 2020 •
edited
Loading

azure-sdk-for-python

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 8870d66 with merge commit 7937a69e59017da0fa848e88286c9b0ca50ded09. SDK Automation 13.0.17.20200918.2 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Nov 9, 2020 •
edited
Loading

azure-sdk-for-python-track2

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Nov 9, 2020 •
edited
Loading

azure-resource-manager-schemas

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 8870d66 with merge commit 7937a69e59017da0fa848e88286c9b0ca50ded09. Schema Automation 13.0.17.20200918.2 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Nov 9, 2020 •
edited
Loading

Trenton Generation

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

This was referenced Nov 9, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@adewaleo adewaleo closed this Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fengzhou-msft fengzhou-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adewaleo @fengzhou-msft