Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.KeyVault to add version stable/2019-09-01 #11607

Merged
merged 9 commits into from
Jan 12, 2021
Merged

[Hub Generated] Review request for Microsoft.KeyVault to add version stable/2019-09-01 #11607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c17088c
Add missing response error codes in keyvault 2019-09-01
jiacheng-L Nov 9, 2020
557326d
Fix copy/paste error
jiacheng-L Nov 9, 2020
a7dbe97
Fix missing properties definition in KeyVault 2019-09-01
jiacheng-L Nov 9, 2020
cdecb28
Remove x-ms-pageable to fix Go SDK Generation issue
jiacheng-L Nov 10, 2020
7c65784
Revert "Remove x-ms-pageable to fix Go SDK Generation issue"
jiacheng-L Nov 11, 2020
cef4fbf
Remove error response schema as it would change the current result type
jiacheng-L Nov 11, 2020
4fbe2ec
Address comment to change the error code to default
jiacheng-L Dec 4, 2020
2dc3e9f
Update description
jiacheng-L Dec 7, 2020
3316dfb
Add back the response code
jiacheng-L Jan 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions .../keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/createVault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@
"enabledForDeployment": true,
"enabledForDiskEncryption": true,
"enabledForTemplateDeployment": true,
"vaultUri": "https://sample-vault.vault.azure.net"
"vaultUri": "https://sample-vault.vault.azure.net",
"provisioningState": "Succeeded"
}
}
},
Expand Down Expand Up @@ -211,7 +212,26 @@
"enabledForDeployment": true,
"enabledForDiskEncryption": true,
"enabledForTemplateDeployment": true,
"vaultUri": "https://sample-vault.vault.azure.net"
"vaultUri": "https://sample-vault.vault.azure.net",
"provisioningState": "Succeeded"
}
}
},
"400": {
"headers": {},
"body": {
"error": {
"code": "",
"message": ""
}
}
},
"409": {
"headers": {},
"body": {
"error": {
"code": "",
"message": ""
}
}
}
Expand Down
18 changes: 18 additions & 0 deletions ...rce-manager/Microsoft.KeyVault/stable/2019-09-01/examples/createVaultWithNetworkAcls.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,24 @@
"vaultUri": "https://sample-vault.vault.azure.net"
}
}
},
"400": {
"headers": {},
"body": {
"error": {
"code": "",
"message": ""
}
}
},
"409": {
"headers": {},
"body": {
"error": {
"code": "",
"message": ""
}
}
}
}
}
9 changes: 9 additions & 0 deletions .../keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/deleteVault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,15 @@
},
"204": {
"headers": {}
},
"400": {
"headers": {},
"body": {
"error": {
"code": "",
"message": ""
}
}
}
}
}
3 changes: 2 additions & 1 deletion ...vault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/getDeletedVault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
"location": "westus",
"tags": {},
"deletionDate": "2017-01-01T00:00:59Z",
"scheduledPurgeDate": "2017-04-01T00:00:59Z"
"scheduledPurgeDate": "2017-04-01T00:00:59Z",
"purgeProtectionEnabled": true
}
}
}
Expand Down
6 changes: 5 additions & 1 deletion ...e-manager/Microsoft.KeyVault/stable/2019-09-01/examples/getPrivateEndpointConnection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/sample-group/providers/Microsoft.KeyVault/vaults/sample-vault/privateEndpointConnections/sample-pec",
"name": "sample-pec",
"type": "Microsoft.KeyVault/vaults/privateEndpointConnections",
"etag": "",
"properties": {
"provisioningState": "Succeeded",
"privateEndpoint": {
Expand All @@ -20,10 +21,13 @@
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "This was automatically approved by user1234@contoso.com",
"actionRequired": "None"
"actionsRequired": "None"
}
}
}
},
"204": {
"headers": {}
}
}
}
3 changes: 2 additions & 1 deletion ...ion/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/getVault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@
"enabledForDeployment": true,
"enabledForDiskEncryption": true,
"enabledForTemplateDeployment": true,
"vaultUri": "https://sample-vault.vault.azure.net"
"vaultUri": "https://sample-vault.vault.azure.net",
"provisioningState": "Succeeded"
}
}
}
Expand Down
3 changes: 2 additions & 1 deletion ...ult/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/listDeletedVaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
"location": "westus",
"tags": {},
"deletionDate": "2017-01-01T00:00:59Z",
"scheduledPurgeDate": "2017-04-01T00:00:59Z"
"scheduledPurgeDate": "2017-04-01T00:00:59Z",
"purgeProtectionEnabled": true
}
}
],
Expand Down
68 changes: 46 additions & 22 deletions ...yvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/listOperations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
"resource": "Key Vault",
"operation": "View Key Vault",
"description": "View the properties of a key vault"
}
},
"isDataAction": false
},
{
"name": "Microsoft.KeyVault/vaults/write",
Expand All @@ -22,7 +23,8 @@
"resource": "Key Vault",
"operation": "Update Key Vault",
"description": "Create a new key vault or update the properties of an existing key vault"
}
},
"isDataAction": false
},
{
"name": "Microsoft.KeyVault/vaults/delete",
Expand All @@ -31,7 +33,8 @@
"resource": "Key Vault",
"operation": "Delete Key Vault",
"description": "Delete a key vault"
}
},
"isDataAction": false
},
{
"name": "Microsoft.KeyVault/vaults/deploy/action",
Expand All @@ -40,7 +43,8 @@
"resource": "Key Vault",
"operation": "Use Vault for Azure Deployments",
"description": "Enables access to secrets in a key vault when deploying Azure resources"
}
},
"isDataAction": false
},
{
"name": "Microsoft.KeyVault/vaults/secrets/read",
Expand All @@ -49,7 +53,8 @@
"resource": "Secret",
"operation": "View Secret Properties",
"description": "View the properties of a secret, but not its value"
}
},
"isDataAction": false
},
{
"name": "Microsoft.KeyVault/vaults/secrets/write",
Expand All @@ -58,7 +63,8 @@
"resource": "Secret",
"operation": "Update Secret",
"description": "Create a new secret or update the value of an existing secret"
}
},
"isDataAction": false
},
{
"name": "Microsoft.KeyVault/vaults/accessPolicies/write",
Expand All @@ -67,7 +73,8 @@
"resource": "Access Policy",
"operation": "Update Access Policy",
"description": "Update an existing access policy by merging or replacing, or add a new access policy to a vault."
}
},
"isDataAction": false
},
{
"origin": "system",
Expand All @@ -78,6 +85,7 @@
"operation": "Read log definition",
"description": "Gets the available logs for a key vault"
},
"isDataAction": false,
"properties": {
"serviceSpecification": {
"logSpecifications": [
Expand All @@ -98,7 +106,8 @@
"resource": "Key Vault Diagnostic Settings",
"operation": "Read diagnostic setting",
"description": "Gets the diagnostic setting for the resource"
}
},
"isDataAction": false
},
{
"origin": "system",
Expand All @@ -108,7 +117,8 @@
"resource": "Key Vault Diagnostic Settings",
"operation": "Write diagnostic setting",
"description": "Creates or updates the diagnostic setting for the resource"
}
},
"isDataAction": false
},
{
"name": "Microsoft.KeyVault/register/action",
Expand All @@ -117,7 +127,8 @@
"resource": "Subscription",
"operation": "Register Subscription",
"description": "Registers a subscription"
}
},
"isDataAction": false
},
{
"name": "Microsoft.KeyVault/unregister/action",
Expand All @@ -126,7 +137,8 @@
"resource": "Subscription",
"operation": "Unregister Subscription",
"description": "Unregisters a subscription"
}
},
"isDataAction": false
},
{
"name": "Microsoft.KeyVault/operations/read",
Expand All @@ -135,7 +147,8 @@
"resource": "Operations",
"operation": "Available Key Vault Operations",
"description": "Lists operations available on Microsoft.KeyVault resource provider"
}
},
"isDataAction": false
},
{
"name": "Microsoft.KeyVault/checkNameAvailability/read",
Expand All @@ -144,7 +157,8 @@
"resource": "Name Availability",
"operation": "Check Name Availability",
"description": "Checks that a key vault name is valid and is not in use"
}
},
"isDataAction": false
},
{
"name": "Microsoft.KeyVault/deletedVaults/read",
Expand All @@ -153,7 +167,8 @@
"resource": "Soft Deleted Key Vault",
"operation": "View Soft Deleted Vaults",
"description": "View the properties of soft deleted key vaults"
}
},
"isDataAction": false
},
{
"name": "Microsoft.KeyVault/locations/deletedVaults/read",
Expand All @@ -162,7 +177,8 @@
"resource": "Soft Deleted Key Vault",
"operation": "View Soft Deleted Key Vault",
"description": "View the properties of a soft deleted key vault"
}
},
"isDataAction": false
},
{
"name": "Microsoft.KeyVault/locations/deletedVaults/purge/action",
Expand All @@ -171,7 +187,8 @@
"resource": "Soft Deleted Key Vault",
"operation": "Purge Soft Deleted Key Vault",
"description": "Purge a soft deleted key vault"
}
},
"isDataAction": false
},
{
"name": "Microsoft.KeyVault/locations/operationResults/read",
Expand All @@ -180,7 +197,8 @@
"resource": "Long Run Operation Result",
"operation": "Check Operation Result",
"description": "Check the result of a long run operation"
}
},
"isDataAction": false
},
{
"name": "Microsoft.KeyVault/hsmPools/read",
Expand All @@ -189,7 +207,8 @@
"resource": "HSM pool",
"operation": "View HSM pool",
"description": "View the properties of an HSM pool"
}
},
"isDataAction": false
},
{
"name": "Microsoft.KeyVault/hsmPools/write",
Expand All @@ -198,7 +217,8 @@
"resource": "HSM pool",
"operation": "Create or Update HSM pool",
"description": "Create a new HSM pool of update the properties of an existing HSM pool"
}
},
"isDataAction": false
},
{
"name": "Microsoft.KeyVault/hsmPools/delete",
Expand All @@ -207,7 +227,8 @@
"resource": "HSM pool",
"operation": "Delete HSM pool",
"description": "Delete an HSM pool"
}
},
"isDataAction": false
},
{
"name": "Microsoft.KeyVault/hsmPools/joinVault/action",
Expand All @@ -216,7 +237,8 @@
"resource": "HSM pool",
"operation": "Join KeyVault to HSM pool",
"description": "Join a key vault to an HSM pool"
}
},
"isDataAction": false
},
{
"origin": "system",
Expand All @@ -227,6 +249,7 @@
"operation": "Read metric definition",
"description": "Gets the available metrics for a key vault"
},
"isDataAction": false,
"properties": {
"serviceSpecification": {}
}
Expand All @@ -239,7 +262,8 @@
"resource": "Location",
"operation": "Modify Network ACLs containing the deleted Vitual Network or Subnet ",
"description": "Notifies Microsoft.KeyVault that a virtual network or subnet is being deleted"
}
},
"isDataAction": false
}
]
}
Expand Down
3 changes: 2 additions & 1 deletion ...ource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/listVaultByResourceGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@
"enabledForDiskEncryption": true,
"enabledForTemplateDeployment": true,
"enableSoftDelete": true,
"vaultUri": "https://sample-vault.vault.azure.net/"
"vaultUri": "https://sample-vault.vault.azure.net/",
"provisioningState": "Succeeded"
}
}
],
Expand Down
3 changes: 2 additions & 1 deletion ...source-manager/Microsoft.KeyVault/stable/2019-09-01/examples/listVaultBySubscription.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@
"enabledForDiskEncryption": true,
"enabledForTemplateDeployment": true,
"enableSoftDelete": true,
"vaultUri": "https://sample-vault.vault.azure.net/"
"vaultUri": "https://sample-vault.vault.azure.net/",
"provisioningState": "Succeeded"
}
}
],
Expand Down
Loading