Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synapse] - Add missing API version parameter #11751

Merged
merged 10 commits into from
Dec 1, 2020
+43 −29
Merged

[Synapse] - Add missing API version parameter #11751

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
59cbf2b
[Synapse] - Add missing API version parameter and pageable
Nov 19, 2020
e4ac2cb
Fix lint
Nov 19, 2020
beca277
Fix recent found issues
Nov 23, 2020
d826201
Fix lint error
Nov 23, 2020
28be444
Fix model validation errors
Nov 24, 2020
48e3f79
Remove x-ms-pageable
Nov 24, 2020
535dc36
Rename Action to RequiredAction
Nov 27, 2020
414a62c
Revert x-ms-pageable and AccessDecisions
Nov 27, 2020
b780883
Update description for AccessDecisions
Dec 1, 2020
3204e7e
Update checkAccessSynapseRbac.json
Dec 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions ...napse/data-plane/Microsoft.Synapse/preview/2020-08-01-preview/checkAccessSynapseRbac.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"tags": [
"CheckPrincipalAccess"
],
"operationId": "CheckPrincipalAccess",
"operationId": "RoleAssignments_CheckPrincipalAccess",
"description": "Check if the given principalId has access to perform list of actions at a given scope.",
"x-ms-examples": {
"Check access": {
Expand Down Expand Up @@ -141,7 +141,7 @@
"description": "List of actions.",
"type": "array",
"items": {
"$ref": "#/definitions/Action"
"$ref": "#/definitions/RequiredAction"
}
},
"scope": {
Expand All @@ -150,7 +150,7 @@
}
}
},
"Action": {
"RequiredAction": {
"description": "Action Info",
"type": "object",
"required": [
Expand All @@ -170,9 +170,15 @@
},
"CheckPrincipalAccessResponse": {
"description": "Check access response details",
"type": "array",
"items": {
"$ref": "#/definitions/CheckAccessDecision"
"type": "object",
"properties": {
"AccessDecisions": {
"description": "Check access response details",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we duplicating the description here with line 172? Seems like they are two different things.

"type": "array",
"items": {
"$ref": "#/definitions/CheckAccessDecision"
}
}
}
},
"SubjectInfo": {
Expand Down
48 changes: 25 additions & 23 deletions ...a-plane/Microsoft.Synapse/preview/2020-08-01-preview/examples/CheckAccessSynapseRbac.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,30 +25,32 @@
},
"responses": {
"200": {
"body": [
{
"accessDecision": "Allowed || NotAllowed",
"actionId": "Action 1",
"roleAssignment": {
"id": "00000000-0000-0000-0000-000000000000",
"roleDefinitionId": "00000000-0000-0000-0000-000000000000",
"principalId": "00000000-0000-0000-0000-000000000000",
"scope": "workspaces/exampleWorkspace",
"principalType": "User || Group || ServicePrincipal"
}
},
{
"accessDecision": "Allowed || NotAllowed",
"actionId": "Action 1",
"roleAssignment": {
"id": "00000000-0000-0000-0000-000000000000",
"roleDefinitionId": "00000000-0000-0000-0000-000000000000",
"principalId": "00000000-0000-0000-0000-000000000000",
"scope": "workspaces/exampleWorkspace",
"principalType": "User || Group || ServicePrincipal"
"body": {
"accessDecisions": [
{
"accessDecision": "Allowed || NotAllowed",
"actionId": "Action 1",
"roleAssignment": {
"id": "00000000-0000-0000-0000-000000000000",
"roleDefinitionId": "00000000-0000-0000-0000-000000000000",
"principalId": "00000000-0000-0000-0000-000000000000",
"scope": "workspaces/exampleWorkspace",
"principalType": "User || Group || ServicePrincipal"
}
},
{
"accessDecision": "Allowed || NotAllowed",
"actionId": "Action 1",
"roleAssignment": {
"id": "00000000-0000-0000-0000-000000000000",
"roleDefinitionId": "00000000-0000-0000-0000-000000000000",
"principalId": "00000000-0000-0000-0000-000000000000",
"scope": "workspaces/exampleWorkspace",
"principalType": "User || Group || ServicePrincipal"
}
}
}
]
]
}
},
"default": {
"body": {
Expand Down
3 changes: 3 additions & 0 deletions ...tion/synapse/data-plane/Microsoft.Synapse/preview/2020-08-01-preview/roleAssignments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,9 @@
},
{
"$ref": "#/parameters/RoleAssignmentIdParameter"
},
{
"$ref": "#/parameters/ScopeParameter"
}
],
"responses": {
Expand Down
3 changes: 3 additions & 0 deletions ...tion/synapse/data-plane/Microsoft.Synapse/preview/2020-08-01-preview/roleDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@
"text/json"
],
"parameters": [
{
"$ref": "#/parameters/ApiVersionParameter"
},
{
"$ref": "#/parameters/RoleDefinitionIdParameter"
}
Expand Down