Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SRP] Add allowSharedKeyAccess property support #11756

Merged
merged 3 commits into from
Jan 29, 2021
Merged

[SRP] Add allowSharedKeyAccess property support #11756

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16e7334
Add allowSharedKeyAccess property support
HimanshuChhabra Nov 20, 2020
4b53829
Remove x-ms-clientname as it cannot be same as property name as per n…
HimanshuChhabra Nov 20, 2020
54c2057
backfill June19 and April19 Api versions with allowsharedkeyaccess
HimanshuChhabra Jan 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...e-manager/Microsoft.Storage/preview/2020-08-01-preview/examples/StorageAccountCreate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"isHnsEnabled": true,
"allowBlobPublicAccess": false,
"minimumTlsVersion": "TLS1_2",
"allowSharedKeyAccess": true,
"routingPreference": {
"routingChoice": "MicrosoftRouting",
"publishMicrosoftEndpoints": true,
Expand Down Expand Up @@ -59,6 +60,7 @@
"isHnsEnabled": true,
"allowBlobPublicAccess": false,
"minimumTlsVersion": "TLS1_2",
"allowSharedKeyAccess": true,
"creationTime": "2017-05-24T13:25:33.4863236Z",
"primaryEndpoints": {
"web": "https://sto4445.web.core.windows.net/",
Expand Down
2 changes: 2 additions & 0 deletions ...e-manager/Microsoft.Storage/preview/2020-08-01-preview/examples/StorageAccountUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"properties": {
"allowBlobPublicAccess": false,
"minimumTlsVersion": "TLS1_2",
"allowSharedKeyAccess": true,
"networkAcls": {
"resourceAccessRules": [
{
Expand Down Expand Up @@ -50,6 +51,7 @@
"isHnsEnabled": true,
"allowBlobPublicAccess": false,
"minimumTlsVersion": "TLS1_2",
"allowSharedKeyAccess": true,
"creationTime": "2017-06-01T02:42:41.7633306Z",
"networkAcls": {
"resourceAccessRules": [
Expand Down
12 changes: 12 additions & 0 deletions ...cation/storage/resource-manager/Microsoft.Storage/preview/2020-08-01-preview/storage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2442,6 +2442,10 @@
"modelAsString": true
},
"description": "Set the minimum TLS version to be permitted on requests to storage. The default interpretation is TLS 1.0 for this property."
},
"allowSharedKeyAccess": {
"type": "boolean",
"description": "Indicates whether the storage account permits requests to be authorized with the account access key via Shared Key. If false, then all requests, including shared access signatures, must be authorized with Azure Active Directory (Azure AD). The default value is null, which is equivalent to true."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the default is true please add "default": true so consuming services know that it is a non standard default

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value is null, if it is not set the behavior is the same as when set true.

}
},
"description": "The parameters used to create the storage account."
Expand Down Expand Up @@ -2952,6 +2956,10 @@
"modelAsString": true
},
"description": "Set the minimum TLS version to be permitted on requests to storage. The default interpretation is TLS 1.0 for this property."
},
"allowSharedKeyAccess": {
"type": "boolean",
"description": "Indicates whether the storage account permits requests to be authorized with the account access key via Shared Key. If false, then all requests, including shared access signatures, must be authorized with Azure Active Directory (Azure AD). The default value is null, which is equivalent to true."
}
},
"description": "Properties of the storage account."
Expand Down Expand Up @@ -3174,6 +3182,10 @@
"modelAsString": true
},
"description": "Set the minimum TLS version to be permitted on requests to storage. The default interpretation is TLS 1.0 for this property."
},
"allowSharedKeyAccess": {
"type": "boolean",
"description": "Indicates whether the storage account permits requests to be authorized with the account access key via Shared Key. If false, then all requests, including shared access signatures, must be authorized with Azure Active Directory (Azure AD). The default value is null, which is equivalent to true."
}
},
"description": "The parameters used when updating a storage account."
Expand Down