-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.MixedReality to add version preview/2020-04-06-preview #11790
[Hub Generated] Review request for Microsoft.MixedReality to add version preview/2020-04-06-preview #11790
Conversation
Swagger Validation Report
|
Rule | Message |
---|---|
1026 - TypeChanged |
The new version has a different type 'boolean' than the previous one 'string'. New: Microsoft.MixedReality/preview/2020-04-06-preview/proxy.json#L145:9 Old: Microsoft.MixedReality/preview/2020-04-06-preview/proxy.json#L145:9 |
1041 - AddedPropertyInResponse |
The new version has a new property 'isDataAction' in response that was not found in the old version. New: Microsoft.MixedReality/preview/2020-04-06-preview/proxy.json#L162:7 Old: Microsoft.MixedReality/preview/2020-04-06-preview/proxy.json#L162:7 |
️⚠️
LintDiff: 2 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- Linted configuring files (Based on target branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
Rule | Message |
---|---|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable New: Microsoft.MixedReality/preview/2020-04-06-preview/proxy.json#L145 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction New: Microsoft.MixedReality/preview/2020-04-06-preview/proxy.json#L171 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/mixedreality/resource-manager/readme.md tag: specification/mixedreality/resource-manager/readme.md#tag-package-2020-05 |
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
Swagger Generation Artifacts
|
Hi @roytan-microsoft, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
@leni-msft These are changes to the RP swagger to match what has long been our behavior and in fact required by the ARM API. The swagger PR for an earlier version has already been approved by you. The breaking change work item is here: |
@ArcturusZhang pls check the go breaking change |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
@leni-msft it is fixed and no breaking changes detected. |
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.