[Hub Generated] Review request for Microsoft.SecurityInsights to add version preview/2019-01-01-preview #11795
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2019-01-01-preview", | ||
| "subscriptionId": "d0cfe6b2-9ac0-4464-9919-dccaee2e48c0", | ||
| "resourceGroupName": "myRg", | ||
| "workspaceName": "myWorkspace", | ||
| "operationalInsightsResourceProvider": "Microsoft.OperationalInsights", | ||
| "watchlistAlias": "highValueAsset", | ||
| "watchlistItemId": "82ba292c-dc97-4dfc-969d-d4dd9e666842", | ||
| "watchlistItem": { | ||
| "properties": { | ||
| "watchlistItem": { | ||
| "Gateway subnet": "10.0.255.224/27", | ||
| "Web Tier": "10.0.1.0/24", | ||
| "Business tier": "10.0.2.0/24", | ||
| "Data tier": "10.0.2.0/24", | ||
| "Private DMZ in": "10.0.0.0/27", | ||
| "Public DMZ out": "10.0.0.96/27" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/d0cfe6b2-9ac0-4464-9919-dccaee2e48c0/resourceGroups/myRg/providers/Microsoft.OperationalInsights/workspaces/myWorkspace/providers/Microsoft.SecurityInsights/WatchlistItem/", | ||
| "type": "Microsoft.SecurityInsights/WatchlistItem", | ||
| "properties": { | ||
| "watchlistItemType": "watchlist-item", | ||
| "watchlistItemId": "82ba292c-dc97-4dfc-969d-d4dd9e666842", | ||
| "tenantId": "4008512e-1d30-48b2-9ee2-d3612ed9d3ea", | ||
| "watchlistId": "dc04e26a-19a9-4ad2-9b2b-6e3b050f48bb", | ||
| "isDeleted": false, | ||
| "created": "2020-11-15T04:58:56.0748363+00:00", | ||
| "updated": "2020-11-16T16:05:20+00:00", | ||
| "createdBy": { | ||
| "objectId": "2046feea-040d-4a46-9e2b-91c2941bfa70", | ||
| "email": "john@contoso.com", | ||
| "name": "john doe" | ||
| }, | ||
| "updatedBy": { | ||
| "objectId": "2046feea-040d-4a46-9e2b-91c2941bfa70", | ||
| "email": "john@contoso.com", | ||
| "name": "john doe" | ||
| }, | ||
| "watchlistItem": { | ||
| "Gateway subnet": "10.0.255.224/27", | ||
| "Web Tier": "10.0.1.0/24", | ||
| "Business tier": "10.0.2.0/24", | ||
| "Data tier": "10.0.2.0/24", | ||
| "Private DMZ in": "10.0.0.0/27", | ||
| "Public DMZ out": "10.0.0.96/27" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "201": { | ||
| "body": { | ||
| "id": "/subscriptions/d0cfe6b2-9ac0-4464-9919-dccaee2e48c0/resourceGroups/myRg/providers/Microsoft.OperationalInsights/workspaces/myWorkspace/providers/Microsoft.SecurityInsights/WatchlistItem/", | ||
| "type": "Microsoft.SecurityInsights/WatchlistItem", | ||
| "properties": { | ||
| "watchlistItemType": "watchlist-item", | ||
| "watchlistItemId": "82ba292c-dc97-4dfc-969d-d4dd9e666842", | ||
| "tenantId": "4008512e-1d30-48b2-9ee2-d3612ed9d3ea", | ||
| "watchlistId": "dc04e26a-19a9-4ad2-9b2b-6e3b050f48bb", | ||
| "isDeleted": false, | ||
| "created": "2020-11-15T04:58:56.0748363+00:00", | ||
| "updated": "2020-11-16T16:05:20+00:00", | ||
| "createdBy": { | ||
| "objectId": "2046feea-040d-4a46-9e2b-91c2941bfa70", | ||
| "email": "john@contoso.com", | ||
| "name": "john doe" | ||
| }, | ||
| "updatedBy": { | ||
| "objectId": "2046feea-040d-4a46-9e2b-91c2941bfa70", | ||
| "email": "john@contoso.com", | ||
| "name": "john doe" | ||
| }, | ||
| "watchlistItem": { | ||
| "Gateway subnet": "10.0.255.224/27", | ||
| "Web Tier": "10.0.1.0/24", | ||
| "Business tier": "10.0.2.0/24", | ||
| "Data tier": "10.0.2.0/24", | ||
| "Private DMZ in": "10.0.0.0/27", | ||
| "Public DMZ out": "10.0.0.96/27" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2019-01-01-preview", | ||
| "subscriptionId": "d0cfe6b2-9ac0-4464-9919-dccaee2e48c0", | ||
| "resourceGroupName": "myRg", | ||
| "workspaceName": "myWorkspace", | ||
| "operationalInsightsResourceProvider": "Microsoft.OperationalInsights", | ||
| "watchlistAlias": "highValueAsset", | ||
| "watchlistItemId": "4008512e-1d30-48b2-9ee2-d3612ed9d3ea" | ||
| }, | ||
| "responses": { | ||
| "200": {}, | ||
| "204": {} | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resource type names in ARM are plural by convention. Also watchlistItems is kind of redundant since it's nested under a watchlists resource type. Can you rename to
watchlistItemsor justitems?Also, you are missing the API to list all watchlistItems in a watchlist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to
WatchlistItems.Getting all WatchlistItems endpoint will be added in future change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@majastrz : could you pls review my pr ?