-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NetAppFiles] Anf 8208 update swagger rest api to 2020 09 01 #11832
Merged
zhenglaizhang
merged 10 commits into
Azure:master
from
audunn:ANF-8208-UpdateSwaggerRestAPI-to-2020-09-01
Dec 17, 2020
Merged
[NetAppFiles] Anf 8208 update swagger rest api to 2020 09 01 #11832
zhenglaizhang
merged 10 commits into
Azure:master
from
audunn:ANF-8208-UpdateSwaggerRestAPI-to-2020-09-01
Dec 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ANF-8208-UpdateSwaggerRestAPI-to-2020-09-01
Swagger Generation Artifacts
|
This was referenced Nov 26, 2020
Hi, @audunn Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Nov 26, 2020
Hi, @audunn your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @zhenglaizhang |
This was referenced Nov 26, 2020
/azp run |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
zhenglaizhang
added
the
Approved-OkToMerge
<valid label in PR review process>add this label when assignee approve to merge the updates
label
Dec 17, 2020
This was referenced Dec 17, 2020
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
…1832) * add 2020-09-01 folder * update api version examples * Add 2020-09 update, update doc * Fix througputMips example * Add missing nextlink to volumes * Update snapshotvolumelist * Update prettier * fix:review comment Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
josuhazure
pushed a commit
to josuhazure/azure-rest-api-specs
that referenced
this pull request
Jan 6, 2021
…1832) * add 2020-09-01 folder * update api version examples * Add 2020-09 update, update doc * Fix througputMips example * Add missing nextlink to volumes * Update snapshotvolumelist * Update prettier * fix:review comment Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved-OkToMerge
<valid label in PR review process>add this label when assignee approve to merge the updates
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Adds new properties
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Adding new API(s)
Adding a new API version
Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.