added new api version for Tables resource #11850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsTroubleshootingAllowed, IsTroubleshootingEnabled, IsTroubleshootingEnabledLastActivation.
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The child tracked resource, 'tables' with immediate parent 'Workspace', must have a list by immediate parent operation. New: Microsoft.OperationalInsights/stable/2020-10-01/Workspaces.json#L401 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isTroubleshootingAllowed New: Microsoft.OperationalInsights/stable/2020-10-01/Tables.json#L190 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isTroubleshootEnabled New: Microsoft.OperationalInsights/stable/2020-10-01/Tables.json#L195 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 11 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.1)
- original: preview/2020-03-01-preview/Tables.json <---> new: stable/2020-10-01/Tables.json
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 11 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.1)
- original: stable/2020-08-01/Tables.json <---> new: stable/2020-10-01/Tables.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
ghost
added
the
customer-reported
Swagger Generation Artifacts
|
|
Thank you for your contribution dabenhamMic! We will review the pull request and get back to you soon. |
|
|
…oubleshootingAllowed from body of example
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kairu-ms
reviewed
Dec 10, 2020
...ationalinsights/resource-manager/Microsoft.OperationalInsights/stable/2020-10-01/Tables.json
Show resolved
Hide resolved
kairu-ms
reviewed
Dec 10, 2020
.../resource-manager/Microsoft.OperationalInsights/stable/2020-10-01/examples/TablesUpdate.json
Show resolved
Hide resolved
|
@ArcturusZhang CI is failed for go SDK |
|
@jianyexi Could you help with CI LintDiff issues? |
Please use v2/types.json to void conflict and also it contains correct "ErrorResponse" |
kairu-ms
approved these changes
Dec 10, 2020
lirenhe
approved these changes
Dec 14, 2020
This was referenced Dec 14, 2020
25 tasks
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
* added3 new properties to TableProperties: IsTroubleshootingAllowed, IsTroubleshootingEnabled, IsTroubleshootingEnabledLastActivation. * added Tables new api version * changed bool to boolean types * prettified jsons * fix erroes in swagger * undo changes to 2020-03-01-preview version * pr fixes * updated TableUpdate example * changed lastTroubleshootDate from date format to string, removed isTroubleshootingAllowed from body of example * changed v1 to v2 * changed WorkspaceNameParameter back to V1 * changed ErrorResponse to default ErrorResponse without ref to local definition * added systemData * removed systemData * added systemData to Patch and Get * moved systemData to Table properties * deleted systemData from Table.json, added to Get and Put examles * changed location of systemData in Tables.json * moved systemData to inside Table definition * moved systemData inside Table properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
=> new version will be deployed after the freeze is over, early December
=>expect to publish swagger during December
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.