-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2020-04-01-preview #11869
[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2020-04-01-preview #11869
Conversation
Swagger Validation Report
Only 10 items are listed, please refer to log for more details.
|
Rule | Message |
---|---|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: purgeProtectionEnabled New: Microsoft.KeyVault/preview/2020-04-01-preview/keyvault.json#L1394 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction New: Microsoft.KeyVault/preview/2020-04-01-preview/providers.json#L112 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
Swagger Generation Artifacts
|
Hi @jiacheng-L, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
...cation/keyvault/resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/keyvault.json
Outdated
Show resolved
Hide resolved
...cation/keyvault/resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/keyvault.json
Show resolved
Hide resolved
...cation/keyvault/resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/keyvault.json
Show resolved
Hide resolved
...cation/keyvault/resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/keyvault.json
Show resolved
Hide resolved
...ication/keyvault/resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/secrets.json
Outdated
Show resolved
Hide resolved
...cation/keyvault/resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/keyvault.json
Outdated
Show resolved
Hide resolved
...ication/keyvault/resource-manager/Microsoft.KeyVault/preview/2020-04-01-preview/secrets.json
Outdated
Show resolved
Hide resolved
Hi, @jiacheng-L. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
…r KPIs report Add back the response code
Hi @jiacheng-L, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.