Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commint new examples and paths #11875

Merged
merged 8 commits into from
Dec 18, 2020
Merged

Commint new examples and paths #11875

merged 8 commits into from
Dec 18, 2020

Conversation

shschwar
Copy link
Contributor

@shschwar shschwar commented Dec 1, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • [X ] update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • [X ] SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 1, 2020 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.

️⚠️LintDiff: 8 Warnings warning [Detail]

Rule Message
⚠️ R1003 - ListInOperationName Since operation 'Entities_Queries' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L2205
⚠️ R1003 - ListInOperationName Since operation 'Entities_GetInsights' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L2256
⚠️ R1005 - GetInOperationName 'GET' operation 'Entities_Queries' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L2205
⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L6905
⚠️ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options. Property name: kind
New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L10928
⚠️ R2029 - PageableOperation Based on the response model schema, operation 'Entities_Queries' might be pageable. Consider adding the x-ms-pageable extension.
New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L2195
⚠️ R3017 - GuidUsage Guid used in model definition 'EntityQueryItem' for property 'id'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L10959
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: addDefaultExtendedTimeRange
New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L10869
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 1, 2020 •
edited
Loading

Swagger Generation Artifacts

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 5a6276c. SDK Automation 14.0.0 
    command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️securityinsight/mgmt/v1.0/securityinsight [View full logs]  [Release SDK Changes] 
    info	[Changelog] No exported changes
  • ️✔️preview/securityinsight/mgmt/2019-01-01-preview/securityinsight [View full logs]  [Release SDK Changes] Breaking Change Detected
    Only show 60 items here, please refer to log for details.
    info	[Changelog] 1. InsightQueryItem.AsEntityQueryItem() (*EntityQueryItem, bool)
info	[Changelog] 1. InsightQueryItem.AsInsightQueryItem() (*InsightQueryItem, bool)
info	[Changelog] 1. InsightQueryItem.MarshalJSON() ([]byte, error)
info	[Changelog] 1. MCASCheckRequirements.AsDynamics365CheckRequirements() (*Dynamics365CheckRequirements, bool)
info	[Changelog] 1. MCASDataConnector.AsDynamics365DataConnector() (*Dynamics365DataConnector, bool)
info	[Changelog] 1. MDATPCheckRequirements.AsDynamics365CheckRequirements() (*Dynamics365CheckRequirements, bool)
info	[Changelog] 1. MDATPDataConnector.AsDynamics365DataConnector() (*Dynamics365DataConnector, bool)
info	[Changelog] 1. OfficeATPCheckRequirements.AsDynamics365CheckRequirements() (*Dynamics365CheckRequirements, bool)
info	[Changelog] 1. OfficeATPDataConnector.AsDynamics365DataConnector() (*Dynamics365DataConnector, bool)
info	[Changelog] 1. OfficeDataConnector.AsDynamics365DataConnector() (*Dynamics365DataConnector, bool)
info	[Changelog] 1. PossibleEntityQueryKindValues() []EntityQueryKind
info	[Changelog] 1. PossibleKindBasicEntityQueryItemValues() []KindBasicEntityQueryItem
info	[Changelog] 1. PossibleKindBasicEntityQueryValues() []KindBasicEntityQuery
info	[Changelog] 1. PossibleOutputTypeValues() []OutputType
info	[Changelog] 1. TICheckRequirements.AsDynamics365CheckRequirements() (*Dynamics365CheckRequirements, bool)
info	[Changelog] 1. TIDataConnector.AsDynamics365DataConnector() (*Dynamics365DataConnector, bool)
info	[Changelog] 1. TiTaxiiCheckRequirements.AsDynamics365CheckRequirements() (*Dynamics365CheckRequirements, bool)
info	[Changelog] 1. TiTaxiiDataConnector.AsDynamics365DataConnector() (*Dynamics365DataConnector, bool)
info	[Changelog]
info	[Changelog] ## Struct Changes
info	[Changelog]
info	[Changelog] ### New Structs
info	[Changelog]
info	[Changelog] 1. Dynamics365CheckRequirements
info	[Changelog] 1. Dynamics365CheckRequirementsProperties
info	[Changelog] 1. Dynamics365DataConnector
info	[Changelog] 1. Dynamics365DataConnectorDataTypes
info	[Changelog] 1. Dynamics365DataConnectorDataTypesDynamics365CdsActivities
info	[Changelog] 1. Dynamics365DataConnectorProperties
info	[Changelog] 1. EntityGetInsightsParameters
info	[Changelog] 1. EntityGetInsightsResponse
info	[Changelog] 1. EntityInsightItem
info	[Changelog] 1. EntityInsightItemQueryTimeInterval
info	[Changelog] 1. EntityQueryItem
info	[Changelog] 1. EntityQueryItemProperties
info	[Changelog] 1. EntityQueryItemPropertiesDataTypesItem
info	[Changelog] 1. EntityQueryKind1
info	[Changelog] 1. EntityQueryModel
info	[Changelog] 1. ExpansionEntityQueriesProperties
info	[Changelog] 1. ExpansionEntityQuery
info	[Changelog] 1. GetInsightsError
info	[Changelog] 1. GetInsightsResultsMetadata
info	[Changelog] 1. GetQueriesResponse
info	[Changelog] 1. InsightQueryItem
info	[Changelog] 1. InsightQueryItemProperties
info	[Changelog] 1. InsightQueryItemPropertiesAdditionalQuery
info	[Changelog] 1. InsightQueryItemPropertiesDefaultTimeRange
info	[Changelog] 1. InsightQueryItemPropertiesReferenceTimeRange
info	[Changelog] 1. InsightQueryItemPropertiesTableQuery
info	[Changelog] 1. InsightQueryItemPropertiesTableQueryColumnsDefinitionsItem
info	[Changelog] 1. InsightQueryItemPropertiesTableQueryQueriesDefinitionsItem
info	[Changelog] 1. InsightQueryItemPropertiesTableQueryQueriesDefinitionsItemLinkColumnsDefinitionsItem
info	[Changelog] 1. InsightsTableResult
info	[Changelog] 1. InsightsTableResultColumnsItem
info	[Changelog]
info	[Changelog] ### New Struct Fields
info	[Changelog]
info	[Changelog] 1. EntityQuery.Etag
info	[Changelog] 1. EntityQuery.Kind
info	[Changelog]
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 5a6276c. SDK Automation 14.0.0 
    warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.SecurityInsights [View full logs]  [Release SDK Changes]
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 5a6276c. SDK Automation 14.0.0 
    warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
  • ⚠️azure-mgmt-securityinsight [View full logs]  [Release SDK Changes] 
    cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-securityinsight
cmderr	[buildConf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-securityinsight
cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-securityinsight
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[changelogReport] Traceback (most recent call last):
cmderr	[changelogReport]   File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
cmderr	[changelogReport]     "__main__", mod_spec)
cmderr	[changelogReport]   File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
cmderr	[changelogReport]     exec(code, run_globals)
cmderr	[changelogReport]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 390, in <module>
cmderr	[changelogReport]     main(args.package_name, args.version, args.no_venv, args.pypi, args.last_pypi, args.output)
cmderr	[changelogReport]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 245, in main
cmderr	[changelogReport]     path_to_package = resolve_package_directory(package_name)
cmderr	[changelogReport]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 133, in resolve_package_directory
cmderr	[changelogReport]     return packages[0]
cmderr	[changelogReport] IndexError: list index out of range
warn	Script return with result [warning] code [1] signal [null] cwd [azure-sdk-for-python]: python
cmderr	[changelogReportLatest] Traceback (most recent call last):
cmderr	[changelogReportLatest]   File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
cmderr	[changelogReportLatest]     "__main__", mod_spec)
cmderr	[changelogReportLatest]   File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
cmderr	[changelogReportLatest]     exec(code, run_globals)
cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 390, in <module>
cmderr	[changelogReportLatest]     main(args.package_name, args.version, args.no_venv, args.pypi, args.last_pypi, args.output)
cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 245, in main
cmderr	[changelogReportLatest]     path_to_package = resolve_package_directory(package_name)
cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 133, in resolve_package_directory
cmderr	[changelogReportLatest]     return packages[0]
cmderr	[changelogReportLatest] IndexError: list index out of range
warn	Script return with result [warning] code [1] signal [null] cwd [azure-sdk-for-python]: python
warn	Not exact 2 reports found:
warn	Not generating changelog.
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 5a6276c. SDK Automation 14.0.0 
    warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=3.0.6272 --use=@autorest/python@5.4.3 --python --python-mode=update --multiapi --track2 --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'AwsCloudTrailDataConnectorDataTypes-logs' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-exchange' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-sharePoint' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'TIDataConnectorDataTypes-indicators' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRuleTemplatesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRulesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'BookmarkList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DataConnectorList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentCommentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OfficeConsentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceWithEtag' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'MCASDataConnectorDataTypes' has a property 'alerts' that is already declared the parent schema 'AlertsDataTypeOfDataConnector' but isn't significantly different. The property has been removed from MCASDataConnectorDataTypes
  • ️✔️track2_azure-mgmt-securityinsight [View full logs]  [Release SDK Changes] 
    cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-securityinsight
cmderr	[buildConf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-securityinsight
cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-securityinsight
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[changelogReport] INFO:__main__:Building code report of azure-mgmt-securityinsight for version None in default folder (False/False/False)
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.securityinsight
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.securityinsight
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.securityinsight
cmderr	[changelogReport] INFO:__main__:Report written to sdk/securityinsight/azure-mgmt-securityinsight/code_reports/latest/report.json
cmderr	[changelogReportLatest] INFO:__main__:Building code report of azure-mgmt-securityinsight for version None in default folder (False/False/True)
cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-securityinsight on PyPI
cmderr	[changelogReportLatest] INFO:__main__:Got ['1.0.0b1']
cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
cmderr	[changelogReportLatest] INFO:__main__:Installing version 1.0.0b1 of azure-mgmt-securityinsight in a venv
cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
cmderr	[changelogReportLatest] INFO:__main__:Building code report of azure-mgmt-securityinsight for version 1.0.0b1 in default folder (True/False/False)
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.securityinsight
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.securityinsight
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.securityinsight
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/securityinsight/azure-mgmt-securityinsight/code_reports/1.0.0b1/report.json
cmderr	[changelogReportLatest] INFO:__main__:Writing metadata: {'reports': ['sdk/securityinsight/azure-mgmt-securityinsight/code_reports/1.0.0b1/report.json']}
warn	Not exact 2 reports found:
warn	Not generating changelog.
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 5a6276c. SDK Automation 14.0.0 
    warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
  • ️✔️@azure/arm-securityinsight [View full logs]  [Release SDK Changes] 
    cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/securityInsights.js → ./dist/arm-securityinsight.js...
cmderr	[npmPack] created ./dist/arm-securityinsight.js in 468ms
️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 5a6276c. Azure CLI Automation 14.0.0 
    warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'AwsCloudTrailDataConnectorDataTypes-logs' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-exchange' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-sharePoint' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'TIDataConnectorDataTypes-indicators' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRuleTemplatesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRulesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'BookmarkList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'DataConnectorList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentCommentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OfficeConsentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceWithEtag' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'MCASDataConnectorDataTypes' has a property 'alerts' that is already declared the parent schema 'AlertsDataTypeOfDataConnector' but isn't significantly different. The property has been removed from MCASDataConnectorDataTypes
cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmderr	[Autorest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
cmderr	[Autorest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest]   test-scenario:
cmderr	[Autorest]     - name: /Actions/get/Get all actions of alert rule.
cmderr	[Autorest]     - name: /AlertRules/put/Creates or updates a Fusion alert rule.
cmderr	[Autorest]     - name: /AlertRules/put/Creates or updates a MicrosoftSecurityIncidentCreation rule.
cmderr	[Autorest]     - name: /AlertRules/put/Creates or updates a Scheduled alert rule.
cmderr	[Autorest]     - name: /AlertRules/put/Creates or updates an action of alert rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get a Fusion alert rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get a MicrosoftSecurityIncidentCreation rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get a Scheduled alert rule.
cmderr	[Autorest]     - name: /AlertRules/get/Get all alert rules.
cmderr	[Autorest]     - name: /AlertRules/get/Get an action of alert rule.
cmderr	[Autorest]     - name: /AlertRules/delete/Delete an action of alert rule.
cmderr	[Autorest]     - name: /AlertRules/delete/Delete an alert rule.
cmderr	[Autorest]     - name: /AlertRuleTemplates/get/Get alert rule template by Id.
cmderr	[Autorest]     - name: /AlertRuleTemplates/get/Get all alert rule templates.
cmderr	[Autorest]     - name: /Bookmarks/put/Creates or updates a bookmark.
cmderr	[Autorest]     - name: /Bookmarks/get/Get a bookmark.
cmderr	[Autorest]     - name: /Bookmarks/get/Get all bookmarks.
cmderr	[Autorest]     - name: /Bookmarks/delete/Delete a bookmark.
cmderr	[Autorest]     - name: /DataConnectors/put/Creates or updates an Office365 data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get a ASC data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get a MCAS data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get a MDATP data connector
cmderr	[Autorest]     - name: /DataConnectors/get/Get a TI data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get all data connectors.
cmderr	[Autorest]     - name: /DataConnectors/get/Get an AAD data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get an AATP data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get an AwsCloudTrail data connector.
cmderr	[Autorest]     - name: /DataConnectors/get/Get an Office365 data connector.
cmderr	[Autorest]     - name: /DataConnectors/delete/Delete an Office365 data connector.
cmderr	[Autorest]     - name: /IncidentComments/put/Creates an incident comment.
cmderr	[Autorest]     - name: /IncidentComments/get/Get all incident comments.
cmderr	[Autorest]     - name: /IncidentComments/get/Get an incident comment.
cmderr	[Autorest]     - name: /Incidents/put/Creates or updates an incident.
cmderr	[Autorest]     - name: /Incidents/get/Get all incidents.
cmderr	[Autorest]     - name: /Incidents/get/Get an incident.
cmderr	[Autorest]     - name: /Incidents/delete/Delete an incident.
cmderr	[Autorest] --------------------------------------------------------
  • ️✔️securityinsight [View full logs]  [Release Azure CLI Changes]
️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 5a6276c. Schema Automation 14.0.0 
    warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
  • ️✔️securityinsights [View full logs]  [Release Schema Changes] 
    cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
 Please click here to preview with your @microsoft account.
Posted by Swagger Pipeline | How to fix these errors?

@ghost
Copy link

ghost commented Dec 1, 2020

Thank you for your contribution shschwar! We will review the pull request and get back to you soon.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Dec 1, 2020
@openapi-workflow-bot
Copy link

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

This was referenced Dec 1, 2020
Closed
Closed
Closed
Closed
Closed
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Dec 1, 2020
Closed
@yungezz yungezz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 4, 2020
@yungezz
Copy link
Member

yungezz commented Dec 4, 2020

add WaitForARMFeedback since new APIs added

@j5lim j5lim added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Dec 4, 2020
@shschwar shschwar requested review from ori-licht and j5lim December 8, 2020 12:50
j5lim
j5lim approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@j5lim j5lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from ARM side. For breaking changes, there is a process we need to follow. Please check Breaking Change Review Checklist in the pr description and get an approval for breaking changes.

@j5lim j5lim added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 9, 2020
@yungezz
Copy link
Member

yungezz commented Dec 10, 2020

Hi @shschwar, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback.

hi @shschwar could you pls follow the guideline to create the ADO item for breaking change review? thanks

@JeffreyRichter JeffreyRichter self-requested a review December 14, 2020 17:40
@JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Dec 14, 2020
@yungezz
Copy link
Member

yungezz commented Dec 15, 2020

hi @ArcturusZhang could you pls help to look at azure-sdk-for-go task failure? thanks

@ArcturusZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

ArcturusZhang
ArcturusZhang requested changes Dec 16, 2020
View reviewed changes
Copy link
Member

@ArcturusZhang ArcturusZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A typo in enum name is breaking SDK generation, please fix, thanks

...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json Outdated Show resolved Hide resolved
ArcturusZhang
ArcturusZhang approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@ArcturusZhang ArcturusZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@yungezz yungezz merged commit 5a6276c into Azure:master Dec 18, 2020
This was referenced Dec 18, 2020
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
giromm2ms pushed a commit to giromm2ms/azure-rest-api-specs that referenced this pull request Dec 20, 2020
@shschwar
Commint new examples and paths (Azure#11875)
1c7bb18
josuhazure pushed a commit to josuhazure/azure-rest-api-specs that referenced this pull request Jan 6, 2021
@shschwar
Commint new examples and paths (Azure#11875)
62351af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ori-licht ori-licht ori-licht approved these changes

@j5lim j5lim j5lim approved these changes

@yungezz yungezz yungezz approved these changes

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

@JeffreyRichter JeffreyRichter JeffreyRichter approved these changes

Assignees

@yungezz yungezz

Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shschwar @yungezz @ArcturusZhang @JeffreyRichter @j5lim @ori-licht