Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sensor Threat Intelligence Package Update #11915

Merged
merged 4 commits into from
Dec 14, 2020
Merged

Sensor Threat Intelligence Package Update #11915

merged 4 commits into from
Dec 14, 2020

Conversation

galmoshe
Copy link
Contributor

@galmoshe galmoshe commented Dec 2, 2020 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 2, 2020 •
edited
Loading

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

Rule Message
❌ 1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.Security/preview/2020-08-06-preview/iotSensors.json#L291:5
️️✔️LintDiff succeeded [Detail] [Expand] 
Validation passes for LintDiff.

️⚠️Avocado: 1 Warnings warning [Detail]
Rule Message
⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/security/resource-manager/readme.md
tag: specification/security/resource-manager/readme.md#tag-package-composite-v3
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
There are no breaking changes.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 2, 2020 •
edited
Loading

Swagger Generation Artifacts

️⚠️ azure-sdk-for-net warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from fef6173. SDK Automation 14.0.0 
    warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/security/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.SecurityCenter [View full logs]  [Release SDK Changes]
️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from fef6173. SDK Automation 14.0.0 
    warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/security/resource-manager/readme.md
  • ️✔️azure-mgmt-security [View full logs]  [Release SDK Changes] Breaking Change Detected
    cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-security
cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-security
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.security
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.security
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.security
cmderr	[changelogReport] INFO:__main__:Report written to sdk/security/azure-mgmt-security/code_reports/latest/report.json
cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-security on PyPI
cmderr	[changelogReportLatest] INFO:__main__:Got ['0.1.0', '0.2.0', '0.3.0', '0.4.0', '0.4.1', '0.5.0', '0.6.0', '1.0.0b1']
cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
cmderr	[changelogReportLatest] INFO:__main__:Installing version 0.6.0 of azure-mgmt-security in a venv
cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.security
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.security
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.security
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/security/azure-mgmt-security/code_reports/0.6.0/report.json
cmdout	[Changelog] Size of delta 3.347% size of original (original: 196703 chars, delta: 6584 chars)
cmdout	[Changelog] **Features**
cmdout	[Changelog]   - Model PackageDownloads has a new parameter wmi_tool
cmdout	[Changelog]   - Model PackageDownloads has a new parameter snmp
cmdout	[Changelog]   - Model PackageDownloads has a new parameter authorized_devices_import_template
cmdout	[Changelog]   - Model PackageDownloads has a new parameter device_information_update_import_template
cmdout	[Changelog]   - Added operation IotDefenderSettingsOperations.download_manager_activation
cmdout	[Changelog]   - Added operation IotSensorsOperations.trigger_ti_package_update
cmdout	[Changelog]   - Added operation IotSensorsOperations.download_reset_password
cmdout	[Changelog]   - Added operation OnPremiseIotSensorsOperations.download_reset_password
cmdout	[Changelog]   - Added operation group IotSitesOperations
cmdout	[Changelog] **Breaking changes**
cmdout	[Changelog]   - Operation IotSensorsOperations.create_or_update has a new signature
warn	Breaking change found in changelog
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from fef6173. SDK Automation 14.0.0 
    warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/security/resource-manager/readme.md
  • ️✔️@azure/arm-security [View full logs]  [Release SDK Changes] 
    cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/securityCenter.js → ./dist/arm-security.js...
cmderr	[npmPack] created ./dist/arm-security.js in 1.1s
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from fef6173. SDK Automation 14.0.0 
    command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️preview/security/mgmt/v3.0/security [View full logs]  [Release SDK Changes] Breaking Change Detected
    Only show 40 items here, please refer to log for details.
    info	[Changelog] 1. IotSensorsClient.TriggerTiPackageUpdate(context.Context, string, string) (autorest.Response, error)
info	[Changelog] 1. IotSensorsClient.TriggerTiPackageUpdatePreparer(context.Context, string, string) (*http.Request, error)
info	[Changelog] 1. IotSensorsClient.TriggerTiPackageUpdateResponder(*http.Response) (autorest.Response, error)
info	[Changelog] 1. IotSensorsClient.TriggerTiPackageUpdateSender(*http.Request) (*http.Response, error)
info	[Changelog] 1. IotSensorsModel.MarshalJSON() ([]byte, error)
info	[Changelog] 1. IotSiteProperties.MarshalJSON() ([]byte, error)
info	[Changelog] 1. IotSitesClient.CreateOrUpdate(context.Context, string, IotSitesModel) (IotSitesModel, error)
info	[Changelog] 1. IotSitesClient.CreateOrUpdatePreparer(context.Context, string, IotSitesModel) (*http.Request, error)
info	[Changelog] 1. IotSitesClient.CreateOrUpdateResponder(*http.Response) (IotSitesModel, error)
info	[Changelog] 1. IotSitesClient.CreateOrUpdateSender(*http.Request) (*http.Response, error)
info	[Changelog] 1. IotSitesClient.Delete(context.Context, string) (autorest.Response, error)
info	[Changelog] 1. IotSitesClient.DeletePreparer(context.Context, string) (*http.Request, error)
info	[Changelog] 1. IotSitesClient.DeleteResponder(*http.Response) (autorest.Response, error)
info	[Changelog] 1. IotSitesClient.DeleteSender(*http.Request) (*http.Response, error)
info	[Changelog] 1. IotSitesClient.Get(context.Context, string) (IotSitesModel, error)
info	[Changelog] 1. IotSitesClient.GetPreparer(context.Context, string) (*http.Request, error)
info	[Changelog] 1. IotSitesClient.GetResponder(*http.Response) (IotSitesModel, error)
info	[Changelog] 1. IotSitesClient.GetSender(*http.Request) (*http.Response, error)
info	[Changelog] 1. IotSitesClient.List(context.Context, string) (IotSitesList, error)
info	[Changelog] 1. IotSitesClient.ListPreparer(context.Context, string) (*http.Request, error)
info	[Changelog] 1. IotSitesClient.ListResponder(*http.Response) (IotSitesList, error)
info	[Changelog] 1. IotSitesClient.ListSender(*http.Request) (*http.Response, error)
info	[Changelog] 1. IotSitesModel.MarshalJSON() ([]byte, error)
info	[Changelog] 1. NewIotSitesClient(string, string) IotSitesClient
info	[Changelog] 1. NewIotSitesClientWithBaseURI(string, string, string) IotSitesClient
info	[Changelog] 1. PossibleSensorStatusValues() []SensorStatus
info	[Changelog] 1. PossibleTiStatusValues() []TiStatus
info	[Changelog]
info	[Changelog] ## Struct Changes
info	[Changelog]
info	[Changelog] ### New Structs
info	[Changelog]
info	[Changelog] 1. IotSensorProperties
info	[Changelog] 1. IotSensorsModel
info	[Changelog] 1. IotSiteProperties
info	[Changelog] 1. IotSitesClient
info	[Changelog] 1. IotSitesList
info	[Changelog] 1. IotSitesModel
info	[Changelog] 1. SettingModel
info	[Changelog]
  • ️✔️preview/security/mgmt/v2.0/security [View full logs]  [Release SDK Changes] Breaking Change Detected
    Only show 40 items here, please refer to log for details.
    info	[Changelog] 		- From: Setting
info	[Changelog] 		- To: BasicSetting
info	[Changelog] 1. SettingsListPage.Values
info	[Changelog] 	- Returns
info	[Changelog] 		- From: []Setting
info	[Changelog] 		- To: []BasicSetting
info	[Changelog]
info	[Changelog] ### Struct Fields
info	[Changelog]
info	[Changelog] 1. AadExternalSecuritySolution.Kind changed type from KindEnum to KindEnum1
info	[Changelog] 1. AtaExternalSecuritySolution.Kind changed type from KindEnum to KindEnum1
info	[Changelog] 1. CefExternalSecuritySolution.Kind changed type from KindEnum to KindEnum1
info	[Changelog] 1. DataExportSetting.Kind changed type from SettingKind to KindEnum
info	[Changelog] 1. ExternalSecuritySolution.Kind changed type from KindEnum to KindEnum1
info	[Changelog] 1. Setting.Kind changed type from SettingKind to KindEnum
info	[Changelog] 1. SettingsList.Value changed type from *[]Setting to *[]BasicSetting
info	[Changelog]
info	[Changelog] ### New Constants
info	[Changelog]
info	[Changelog] 1. KindEnum.KindDataExportSetting
info	[Changelog] 1. KindEnum.KindSetting
info	[Changelog]
info	[Changelog] ### New Funcs
info	[Changelog]
info	[Changelog] 1. *SettingModel.UnmarshalJSON([]byte) error
info	[Changelog] 1. *SettingsList.UnmarshalJSON([]byte) error
info	[Changelog] 1. DataExportSetting.AsBasicSetting() (BasicSetting, bool)
info	[Changelog] 1. DataExportSetting.AsDataExportSetting() (*DataExportSetting, bool)
info	[Changelog] 1. DataExportSetting.AsSetting() (*Setting, bool)
info	[Changelog] 1. PossibleKindEnum1Values() []KindEnum1
info	[Changelog] 1. Setting.AsBasicSetting() (BasicSetting, bool)
info	[Changelog] 1. Setting.AsDataExportSetting() (*DataExportSetting, bool)
info	[Changelog] 1. Setting.AsSetting() (*Setting, bool)
info	[Changelog]
info	[Changelog] ## Struct Changes
info	[Changelog]
info	[Changelog] ### New Structs
info	[Changelog]
info	[Changelog] 1. SettingModel
info	[Changelog]
  • ️✔️preview/security/mgmt/v1.0/security [View full logs]  [Release SDK Changes] Breaking Change Detected
    Only show 40 items here, please refer to log for details.
    info	[Changelog] 		- From: Setting
info	[Changelog] 		- To: BasicSetting
info	[Changelog] 1. SettingsListPage.Values
info	[Changelog] 	- Returns
info	[Changelog] 		- From: []Setting
info	[Changelog] 		- To: []BasicSetting
info	[Changelog]
info	[Changelog] ### Struct Fields
info	[Changelog]
info	[Changelog] 1. AadExternalSecuritySolution.Kind changed type from KindEnum to KindEnum1
info	[Changelog] 1. AtaExternalSecuritySolution.Kind changed type from KindEnum to KindEnum1
info	[Changelog] 1. CefExternalSecuritySolution.Kind changed type from KindEnum to KindEnum1
info	[Changelog] 1. DataExportSetting.Kind changed type from SettingKind to KindEnum
info	[Changelog] 1. ExternalSecuritySolution.Kind changed type from KindEnum to KindEnum1
info	[Changelog] 1. Setting.Kind changed type from SettingKind to KindEnum
info	[Changelog] 1. SettingsList.Value changed type from *[]Setting to *[]BasicSetting
info	[Changelog]
info	[Changelog] ### New Constants
info	[Changelog]
info	[Changelog] 1. KindEnum.KindDataExportSetting
info	[Changelog] 1. KindEnum.KindSetting
info	[Changelog]
info	[Changelog] ### New Funcs
info	[Changelog]
info	[Changelog] 1. *SettingModel.UnmarshalJSON([]byte) error
info	[Changelog] 1. *SettingsList.UnmarshalJSON([]byte) error
info	[Changelog] 1. DataExportSetting.AsBasicSetting() (BasicSetting, bool)
info	[Changelog] 1. DataExportSetting.AsDataExportSetting() (*DataExportSetting, bool)
info	[Changelog] 1. DataExportSetting.AsSetting() (*Setting, bool)
info	[Changelog] 1. PossibleKindEnum1Values() []KindEnum1
info	[Changelog] 1. Setting.AsBasicSetting() (BasicSetting, bool)
info	[Changelog] 1. Setting.AsDataExportSetting() (*DataExportSetting, bool)
info	[Changelog] 1. Setting.AsSetting() (*Setting, bool)
info	[Changelog]
info	[Changelog] ## Struct Changes
info	[Changelog]
info	[Changelog] ### New Structs
info	[Changelog]
info	[Changelog] 1. SettingModel
info	[Changelog]
️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from fef6173. Schema Automation 14.0.0 
    warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/security/resource-manager/readme.md
  • ️✔️security [View full logs]  [Release Schema Changes] 
    cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.2 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
cmderr	[resource-manager]  ERR! code ELIFECYCLE
cmderr	[resource-manager] npm ERR! errno 31
cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 test: `mocha -r ts-node/register tests.ts`
cmderr	[resource-manager] npm ERR! Exit status 31
cmderr	[resource-manager] npm ERR!
cmderr	[resource-manager] npm ERR! Failed at the template-schema-validation-tools@1.0.0 test script.
cmderr	[resource-manager] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
cmderr	[resource-manager]  A complete log of this run can be found in:
cmderr	[resource-manager] npm ERR!     /home/vsts/.npm/_logs/2020-12-14T02_16_05_682Z-debug.log
cmderr	[resource-manager] Error: Command failed: npm run test --prefix tools
cmderr	[resource-manager]     at checkExecSyncError (child_process.js:635:11)
cmderr	[resource-manager]     at Object.execSync (child_process.js:671:15)
cmderr	[resource-manager]     at Object.<anonymous> (/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas/sdkauto_afterscript.js:13:28)
cmderr	[resource-manager]     at Module._compile (internal/modules/cjs/loader.js:999:30)
cmderr	[resource-manager]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
cmderr	[resource-manager]     at Module.load (internal/modules/cjs/loader.js:863:32)
cmderr	[resource-manager]     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
cmderr	[resource-manager]     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
cmderr	[resource-manager]     at internal/main/run_main_module.js:17:47 {
cmderr	[resource-manager]   status: 31,
cmderr	[resource-manager]   signal: null,
cmderr	[resource-manager]   output: [ null, null, null ],
cmderr	[resource-manager]   pid: 3607,
cmderr	[resource-manager]   stdout: null,
cmderr	[resource-manager]   stderr: null
cmderr	[resource-manager] }
️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
 Please click here to preview with your @microsoft account.
Posted by Swagger Pipeline | How to fix these errors?

@galmoshe galmoshe changed the title add ti package update Sensor Threat Intelligence Package Update Dec 2, 2020
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Dec 2, 2020
Closed
@openapi-workflow-bot
Copy link

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Dec 2, 2020
Closed
This was referenced Dec 2, 2020
Closed
Closed
@galmoshe
Copy link
Contributor Author

galmoshe commented Dec 3, 2020

@liranc @MichalHel Your review is welcome

@JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Dec 3, 2020
@jianyexi jianyexi added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 8, 2020
@RamyasreeChakka RamyasreeChakka added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 10, 2020
@jianyexi jianyexi merged commit fef6173 into Azure:master Dec 14, 2020
This was referenced Dec 14, 2020
Closed
Closed
Closed
Merged
Closed
This was referenced Dec 14, 2020
Closed
Closed
dabenhamMic pushed a commit to dabenhamMic/azure-rest-api-specs that referenced this pull request Dec 14, 2020
@galmoshe @gamoshe @dabenhamMic
Sensor Threat Intelligence Package Update (Azure#11915)
9fdac23 
* add ti package update

* remove redundant spec

* fix case sensitive path

* prettier

Co-authored-by: Gal Moshe <gamoshe@gamoshe.local>
Co-authored-by: Gal Moshe <gamoshe@microsoft.com>
giromm2ms pushed a commit to giromm2ms/azure-rest-api-specs that referenced this pull request Dec 20, 2020
@galmoshe @gamoshe
Sensor Threat Intelligence Package Update (Azure#11915)
49fb703 
* add ti package update

* remove redundant spec

* fix case sensitive path

* prettier

Co-authored-by: Gal Moshe <gamoshe@gamoshe.local>
Co-authored-by: Gal Moshe <gamoshe@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffreyRichter JeffreyRichter JeffreyRichter approved these changes

@jianyexi jianyexi jianyexi approved these changes

Assignees

@jianyexi jianyexi

Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@galmoshe @JeffreyRichter @jianyexi @RamyasreeChakka @gamoshe