Capacity RP Quota APIs for GA #11930

rahuls-microsoft · 2020-12-03T20:58:59Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version - New API Version for GA.
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-12-03T20:59:03Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 13 Warnings warning [Detail]

Only 10 items are listed, please refer to log for more details.

Linted configuring files (Based on source branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- reservations/resource-manager/readme.md tag:package-2020-10-25
Linted configuring files (Based on target branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- reservations/resource-manager/readme.md tag:default

Rule	Message
⚠️ R2010 - LongRunningOperationsOptionsValidator	A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. New: Microsoft.Capacity/stable/2017-11-01/reservations.json#L227
⚠️ R2010 - LongRunningOperationsOptionsValidator	A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. New: Microsoft.Capacity/stable/2017-11-01/reservations.json#L180
⚠️ R4021 - DescriptionAndTitleMissing	'ErrorResponseCode' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.Capacity/stable/2017-11-01/reservations.json#L496
⚠️ R4021 - DescriptionAndTitleMissing	'capabilities' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.Capacity/stable/2017-11-01/reservations.json#L652
⚠️ R4021 - DescriptionAndTitleMissing	'SkuCapability' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.Capacity/stable/2017-11-01/reservations.json#L668
⚠️ R4021 - DescriptionAndTitleMissing	'provisioningState' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.Capacity/stable/2017-11-01/reservations.json#L767
⚠️ R4021 - DescriptionAndTitleMissing	'location' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.Capacity/stable/2017-11-01/reservations.json#L782
⚠️ R4021 - DescriptionAndTitleMissing	'provisioningState' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.Capacity/stable/2017-11-01/reservations.json#L840
⚠️ R4021 - DescriptionAndTitleMissing	'Error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.Capacity/stable/2017-11-01/reservations.json#L970
⚠️ R4021 - DescriptionAndTitleMissing	'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.Capacity/stable/2017-11-01/reservations.json#L973

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/reservations/resource-manager/readme.md tag: specification/reservations/resource-manager/readme.md#tag-package-2020-10-25

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 10 Warnings warning [Detail]

Compared Swaggers (Based on Oad v0.8.1)
- original: preview/2019-07-19/quota.json <---> new: stable/2020-10-25/quota.json

Rule	Message
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Capacity/autoQuotaIncrease' removed or restructured? New: azure-rest-api-specs/blob/b034d7f015609d46a6fec622581b54ef588f6418/ Old: Microsoft.Capacity/preview/2019-07-19/quota.json#L384:5
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'autoQuotaIncreaseSettings' removed or renamed? New: Microsoft.Capacity/stable/2020-10-25/quota.json#L382:3 Old: Microsoft.Capacity/preview/2019-07-19/quota.json#L467:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'aqiSettings' removed or renamed? New: Microsoft.Capacity/stable/2020-10-25/quota.json#L382:3 Old: Microsoft.Capacity/preview/2019-07-19/quota.json#L467:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'SupportRequestAction' removed or renamed? New: Microsoft.Capacity/stable/2020-10-25/quota.json#L382:3 Old: Microsoft.Capacity/preview/2019-07-19/quota.json#L467:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'AutoQuotaIncreaseDetail' removed or renamed? New: Microsoft.Capacity/stable/2020-10-25/quota.json#L382:3 Old: Microsoft.Capacity/preview/2019-07-19/quota.json#L467:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'ContactMethod' removed or renamed? New: Microsoft.Capacity/stable/2020-10-25/quota.json#L382:3 Old: Microsoft.Capacity/preview/2019-07-19/quota.json#L467:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'AqiState' removed or renamed? New: Microsoft.Capacity/stable/2020-10-25/quota.json#L382:3 Old: Microsoft.Capacity/preview/2019-07-19/quota.json#L467:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'EmailActions' removed or renamed? New: Microsoft.Capacity/stable/2020-10-25/quota.json#L382:3 Old: Microsoft.Capacity/preview/2019-07-19/quota.json#L467:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'Actions' removed or renamed? New: Microsoft.Capacity/stable/2020-10-25/quota.json#L382:3 Old: Microsoft.Capacity/preview/2019-07-19/quota.json#L467:3
⚠️ 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'SeverityTypes' removed or renamed? New: Microsoft.Capacity/stable/2020-10-25/quota.json#L382:3 Old: Microsoft.Capacity/preview/2019-07-19/quota.json#L467:3

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2020-12-03T20:59:04Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 343fbe0. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/reservations/resource-manager/readme.md

️✔️azure-mgmt-reservations [View full logs] [Release SDK Changes] Breaking Change Detected

cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-reservations
cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-reservations
cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.reservations
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.reservations
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.reservations
cmderr	[changelogReport] INFO:__main__:Report written to sdk/reservations/azure-mgmt-reservations/code_reports/latest/report.json
cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-reservations on PyPI
cmderr	[changelogReportLatest] INFO:__main__:Got ['0.1.0', '0.2.0', '0.2.1', '0.3.0', '0.3.1', '0.3.2', '0.4.0', '0.5.0', '0.6.0', '0.7.0', '0.8.0', '1.0.0b1']
cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
cmderr	[changelogReportLatest] INFO:__main__:Installing version 1.0.0b1 of azure-mgmt-reservations in a venv
cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.reservations
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.reservations
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.reservations
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/reservations/azure-mgmt-reservations/code_reports/1.0.0b1/report.json
cmdout	[Changelog] Size of delta 49.956% size of original (original: 21439 chars, delta: 10710 chars)
cmdout	[Changelog] **Features**
cmdout	[Changelog]   - Model ReservationResponse has a new parameter kind
cmdout	[Changelog]   - Model Catalog has a new parameter tier
cmdout	[Changelog]   - Model Catalog has a new parameter size
cmdout	[Changelog]   - Model Catalog has a new parameter capabilities
cmdout	[Changelog]   - Added operation QuotaOperations.create_or_update
cmdout	[Changelog]   - Added operation QuotaOperations.update
cmdout	[Changelog]   - Added operation ReservationOperations.split
cmdout	[Changelog]   - Added operation ReservationOperations.merge
cmdout	[Changelog]   - Added operation ReservationOperations.update
cmdout	[Changelog] **Breaking changes**
cmdout	[Changelog]   - Operation QuotaRequestStatusOperations.list has a new signature
cmdout	[Changelog]   - Operation QuotaRequestStatusOperations.get has a new signature
cmdout	[Changelog]   - Operation QuotaOperations.list has a new signature
cmdout	[Changelog]   - Operation QuotaOperations.get has a new signature
cmdout	[Changelog]   - Operation AzureReservationAPIOperationsMixin.get_applied_reservation_list has a new signature
cmdout	[Changelog]   - Model ReservationOrderResponse no longer has parameter plan_information
cmdout	[Changelog]   - Model ReservationOrderResponse no longer has parameter billing_plan
cmdout	[Changelog]   - Model ReservationProperties no longer has parameter renew_source
cmdout	[Changelog]   - Model ReservationProperties no longer has parameter billing_plan
cmdout	[Changelog]   - Model ReservationProperties no longer has parameter reserved_resource_type
cmdout	[Changelog]   - Model ReservationProperties no longer has parameter billing_scope_id
cmdout	[Changelog]   - Model ReservationProperties no longer has parameter term
cmdout	[Changelog]   - Model ReservationProperties no longer has parameter sku_description
cmdout	[Changelog]   - Model ReservationProperties no longer has parameter renew_destination
cmdout	[Changelog]   - Model ReservationProperties no longer has parameter instance_flexibility
cmdout	[Changelog]   - Model ReservationProperties no longer has parameter renew_properties
cmdout	[Changelog]   - Model ReservationProperties no longer has parameter renew
cmdout	[Changelog]   - Model Catalog no longer has parameter sku_properties
cmdout	[Changelog]   - Model Catalog no longer has parameter billing_plans
cmdout	[Changelog]   - Model Patch no longer has parameter instance_flexibility
cmdout	[Changelog]   - Model Patch no longer has parameter name
cmdout	[Changelog]   - Model Patch no longer has parameter renew_properties
cmdout	[Changelog]   - Model Patch no longer has parameter renew
cmdout	[Changelog]   - Operation AzureReservationAPIOperationsMixin.get_catalog has a new signature
cmdout	[Changelog]   - Operation OperationOperations.list has a new signature
cmdout	[Changelog]   - Removed operation QuotaOperations.begin_create_or_update
cmdout	[Changelog]   - Removed operation QuotaOperations.begin_update
cmdout	[Changelog]   - Removed operation ReservationOperations.begin_available_scopes
cmdout	[Changelog]   - Removed operation ReservationOperations.begin_split
cmdout	[Changelog]   - Removed operation ReservationOperations.begin_merge
cmdout	[Changelog]   - Removed operation ReservationOperations.begin_update
cmdout	[Changelog]   - Removed operation ReservationOrderOperations.change_directory
cmdout	[Changelog]   - Removed operation ReservationOrderOperations.calculate
cmdout	[Changelog]   - Removed operation ReservationOrderOperations.begin_purchase
cmdout	[Changelog]   - Removed operation group CalculateExchangeOperations
cmdout	[Changelog]   - Removed operation group AutoQuotaIncreaseOperations
cmdout	[Changelog]   - Removed operation group ExchangeOperations
warn	Breaking change found in changelog

️⚠️ azure-sdk-for-net warning [Detail]

⚠️Warning [Logs]Release - Generate from 343fbe0. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/reservations/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Reservations [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.Reservations.1.14.0-preview.nupkg
- Microsoft.Azure.Management.Reservations.1.14.0-preview.snupkg

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 343fbe0. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️reservations/mgmt/2020-10-25/reservations [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
```
️✔️preview/reservations/mgmt/2019-07-19-preview/reservations [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/reservations/mgmt/2019-04-01/reservations [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/reservations/mgmt/2018-06-01/reservations [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️reservations/mgmt/2017-11-01/reservations [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 343fbe0. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/reservations/resource-manager/readme.md

️✔️reservations [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.2 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️❌ azure-sdk-for-js failed [Detail]

❌Failed [Logs]Release - Generate from 343fbe0. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/reservations/resource-manager/readme.md

❌@azure/arm-reservations [View full logs] [Release SDK Changes]

error	Script return with result [failed] code [2] signal [null] cwd [azure-sdk-for-js/azure-sdk-for-js/sdk/reservations/arm-reservations]: npm pack --silent

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

rahuls-microsoft · 2020-12-04T02:18:47Z

Please review it.
Some Doc changes for GA and removing the API, which are not going to GA.

rahuls-microsoft · 2020-12-04T20:23:31Z

@raych1 - The issues are fixed. It looks like there was a bad merge from master.
Please review it. The issues are resolved. Thanks.

raych1 · 2020-12-07T01:10:04Z

@raych1 - The issues are fixed. It looks like there was a bad merge from master.
Please review it. The issues are resolved. Thanks.

@rahuls-microsoft , all the checks except JS SDK automation passes. Can you read through the contribution list in first comment and check on it then ARM will review this PR. The assignee @xccc-msft will follow up with you for this PR review. Thanks.

openapi-workflow-bot · 2020-12-07T01:10:22Z

Hi, @rahuls-microsoft your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @xccc-msft

openapi-workflow-bot · 2020-12-07T19:22:09Z

Hi, @rahuls-microsoft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2020-12-07T19:22:10Z

Hi, @rahuls-microsoft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

RamyasreeChakka · 2020-12-09T23:24:30Z

@rahuls-microsoft Your PR has a single commit with all the newly added files. Its hard to review the PR as I do not know what exactly changed from earlier preview version to GA version. To expedite the ARM review, I recommend to do first commit by copying all the earlier version files as is. From 2nd commit onwards, you can make the required GA changes.

openapi-workflow-bot · 2020-12-10T01:31:44Z

Hi, @rahuls-microsoft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

rahuls-microsoft · 2020-12-10T18:24:15Z

@rahuls-microsoft Your PR has a single commit with all the newly added files. Its hard to review the PR as I do not know what exactly changed from earlier preview version to GA version. To expedite the ARM review, I recommend to do first commit by copying all the earlier version files as is. From 2nd commit onwards, you can make the required GA changes.

Sure, This is a new version for GA. I can point to the Preview version.

RamyasreeChakka · 2020-12-10T18:28:37Z

@rahuls-microsoft

        Rahul Singh
        FTE Your PR has a single commit with all the newly added files. Its hard to review the PR as I do not know what exactly changed from earlier preview version to GA version. To expedite the ARM review, I recommend to do first commit by copying all the earlier version files as is. From 2nd commit onwards, you can make the required GA changes.

Sure, This is a new version for GA. I can point to the Preview version.

@rahuls-microsoft can you please submit a new PR with the first commit by copying all the earlier version files as is. From 2nd commit onwards, you can make the required GA changes.

rahuls-microsoft · 2020-12-10T18:32:44Z

@rahuls-microsoft
        Rahul Singh
        FTE Your PR has a single commit with all the newly added files. Its hard to review the PR as I do not know what exactly changed from earlier preview version to GA version. To expedite the ARM review, I recommend to do first commit by copying all the earlier version files as is. From 2nd commit onwards, you can make the required GA changes.
Sure, This is a new version for GA. I can point to the Preview version.
@rahuls-microsoft can you please submit a new PR with the first commit by copying all the earlier version files as is. From 2nd commit onwards, you can make the required GA changes.

Preview version - https://github.com/Azure/azure-rest-api-specs/blob/master/specification/reservations/resource-manager/Microsoft.Capacity/preview/2019-07-19/quota.json

rahuls-microsoft · 2020-12-10T19:20:56Z

@rahuls-microsoft
        Rahul Singh
        FTE Your PR has a single commit with all the newly added files. Its hard to review the PR as I do not know what exactly changed from earlier preview version to GA version. To expedite the ARM review, I recommend to do first commit by copying all the earlier version files as is. From 2nd commit onwards, you can make the required GA changes.
Sure, This is a new version for GA. I can point to the Preview version.
@rahuls-microsoft can you please submit a new PR with the first commit by copying all the earlier version files as is. From 2nd commit onwards, you can make the required GA changes.
Preview version - https://github.com/Azure/azure-rest-api-specs/blob/master/specification/reservations/resource-manager/Microsoft.Capacity/preview/2019-07-19/quota.json

Overwrote the files with Preview version and updated it to GA version.

rahuls-microsoft · 2020-12-10T19:22:49Z

@RamyasreeChakka - Overwrote the files with Preview version checked in, then updated it to GA version.
Does it look fine? Please review.

rahuls-microsoft · 2020-12-10T23:26:26Z

@leni-msft @raych1 @orquiri @lirenhe
Can I get a sign off from the reviewers?
ARMSignedOff has been added.

raych1 · 2020-12-11T04:54:16Z

@leni-msft @raych1 @orquiri @lirenhe
Can I get a sign off from the reviewers?
ARMSignedOff has been added.

@xccc-msft , could you help with the follow-ups?

xseeseesee · 2020-12-14T03:28:07Z

@rahuls-microsoft Please let me know once it's ready to merge. Thanks.

rahuls-microsoft · 2020-12-14T19:06:57Z

@rahuls-microsoft Please let me know once it's ready to merge. Thanks.

Yes, we are ready to merge. Please merge it. Thanks.

* Capacity RP Quota APIs for GA * Adding preview version to stable dir as base files. * Files from preview version, which will be removed. * Updating to GA Version.

Capacity RP Quota APIs for GA

15e533d

openapi-assignment-bot bot assigned xseeseesee Dec 3, 2020

rahuls-microsoft mentioned this pull request Dec 3, 2020

[Draft] Capacity RP Quota APIs for GA #11195

Closed

11 tasks

rahuls-microsoft requested review from corquiri and leni-msft December 3, 2020 21:03

openapi-pipeline-app bot added the CI-BreakingChange-Python label Dec 3, 2020

openapi-sdkautomation bot mentioned this pull request Dec 3, 2020

[AutoPR Microsoft.Azure.Management.Reservations] Capacity RP Quota APIs for GA AzureSDKAutomation/azure-sdk-for-net#2511

Closed

rahuls-microsoft requested a review from raych1 December 3, 2020 23:26

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 7, 2020

RamyasreeChakka added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 9, 2020

rahuls-microsoft added 2 commits December 10, 2020 11:14

Adding preview version to stable dir as base files.

8f96e78

Files from preview version, which will be removed.

8beb75c

rahuls-microsoft requested a review from lirenhe as a code owner December 10, 2020 19:17

Updating to GA Version.

b034d7f

RamyasreeChakka added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Dec 10, 2020

xseeseesee approved these changes Dec 14, 2020

View reviewed changes

xseeseesee merged commit 343fbe0 into Azure:master Dec 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Capacity RP Quota APIs for GA #11930

Capacity RP Quota APIs for GA #11930

rahuls-microsoft commented Dec 3, 2020 •

edited

Loading

openapi-pipeline-app bot commented Dec 3, 2020 •

edited

Loading

openapi-pipeline-app bot commented Dec 3, 2020 •

edited

Loading

rahuls-microsoft commented Dec 4, 2020

rahuls-microsoft commented Dec 4, 2020

raych1 commented Dec 7, 2020

openapi-workflow-bot bot commented Dec 7, 2020

openapi-workflow-bot bot commented Dec 7, 2020

openapi-workflow-bot bot commented Dec 7, 2020

RamyasreeChakka commented Dec 9, 2020

openapi-workflow-bot bot commented Dec 10, 2020

rahuls-microsoft commented Dec 10, 2020

RamyasreeChakka commented Dec 10, 2020

rahuls-microsoft commented Dec 10, 2020

rahuls-microsoft commented Dec 10, 2020

rahuls-microsoft commented Dec 10, 2020

rahuls-microsoft commented Dec 10, 2020

raych1 commented Dec 11, 2020

xseeseesee commented Dec 14, 2020

rahuls-microsoft commented Dec 14, 2020

Capacity RP Quota APIs for GA #11930

Capacity RP Quota APIs for GA #11930

Conversation

rahuls-microsoft commented Dec 3, 2020 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Dec 3, 2020 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Dec 3, 2020 • edited Loading

Swagger Generation Artifacts

rahuls-microsoft commented Dec 4, 2020

rahuls-microsoft commented Dec 4, 2020

raych1 commented Dec 7, 2020

openapi-workflow-bot bot commented Dec 7, 2020

openapi-workflow-bot bot commented Dec 7, 2020

openapi-workflow-bot bot commented Dec 7, 2020

RamyasreeChakka commented Dec 9, 2020

openapi-workflow-bot bot commented Dec 10, 2020

rahuls-microsoft commented Dec 10, 2020

RamyasreeChakka commented Dec 10, 2020

rahuls-microsoft commented Dec 10, 2020

rahuls-microsoft commented Dec 10, 2020

rahuls-microsoft commented Dec 10, 2020

rahuls-microsoft commented Dec 10, 2020

raych1 commented Dec 11, 2020

xseeseesee commented Dec 14, 2020

rahuls-microsoft commented Dec 14, 2020

rahuls-microsoft commented Dec 3, 2020 •

edited

Loading

openapi-pipeline-app bot commented Dec 3, 2020 •

edited

Loading

openapi-pipeline-app bot commented Dec 3, 2020 •

edited

Loading