-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Advisor to add version preview/2020-07-01-preview #12117
Merged
ArcturusZhang
merged 4 commits into
Azure:master
from
mudit794:dev-advisor-Score-Microsoft.Advisor-2020-07-01-preview
Dec 16, 2020
Merged
[Hub Generated] Review request for Microsoft.Advisor to add version preview/2020-07-01-preview #12117
ArcturusZhang
merged 4 commits into
Azure:master
from
mudit794:dev-advisor-Score-Microsoft.Advisor-2020-07-01-preview
Dec 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Validation Report
|
Rule | Message |
---|---|
1033 - RemovedProperty |
The new version is missing a property found in the old version. Was 'data' renamed or removed? New: Microsoft.Advisor/preview/2020-07-01-preview/advisor.json#L247:9 Old: Microsoft.Advisor/preview/2020-07-01-preview/advisor.json#L242:9 |
1033 - RemovedProperty |
The new version is missing a property found in the old version. Was 'data' renamed or removed? New: Microsoft.Advisor/preview/2020-07-01-preview/advisor.json#L247:9 Old: Microsoft.Advisor/preview/2020-07-01-preview/advisor.json#L242:9 |
1041 - AddedPropertyInResponse |
The new version has a new property 'scoreHistory' in response that was not found in the old version. New: Microsoft.Advisor/preview/2020-07-01-preview/advisor.json#L247:9 Old: Microsoft.Advisor/preview/2020-07-01-preview/advisor.json#L242:9 |
️️✔️
LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
Swagger Generation Artifacts
|
This api version is in preview released in august. Does this require breaking change review? |
This was referenced Dec 15, 2020
JeffreyRichter
added
the
Approved-BreakingChange
DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
label
Dec 15, 2020
JeffreyRichter
approved these changes
Dec 15, 2020
@ArcturusZhang can you please help approve and merge it |
ArcturusZhang
approved these changes
Dec 16, 2020
This was referenced Dec 16, 2020
Closed
[ReleasePR azure-mgmt-advisor] add error response flag for 400 code
Azure/azure-sdk-for-python#15523
Closed
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
…review/2020-07-01-preview (Azure#12117) * Add new category count * Update GetAdvisorScoreDetail.json * Update ListAdvisorScore.json * Update GetAdvisorScoreDetail.json
josuhazure
pushed a commit
to josuhazure/azure-rest-api-specs
that referenced
this pull request
Jan 6, 2021
…review/2020-07-01-preview (Azure#12117) * Add new category count * Update GetAdvisorScoreDetail.json * Update ListAdvisorScore.json * Update GetAdvisorScoreDetail.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved-BreakingChange
DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
CI-BreakingChange-Go
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.