Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable azure-sdk-for-net-track2 #12169

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Enable azure-sdk-for-net-track2 #12169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions specificationRepositoryConfiguration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@
"integrationRepository": "AzureSDKAutomation/azure-sdk-for-net",
"mainRepository": "Azure/azure-sdk-for-net"
},
"azure-sdk-for-net-track2": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I know this PR is merged already but before we start using this in a bunch of places can we rename it? I don't like using the terminology of "track2" in these artifacts as that is a code name that doesn't really mean anything. It would be better if we called it something that was more connected to the changes. "azure-sdk-for-net-v3-generator" or just "azure-sdk-for-net-generator".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's up to your team to choose a name. You only need to update this config file to make it work. I'm OK for this change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShivangiReja as part of your work could you please update this name before starting to do the configurations.

"integrationRepository": "AzureSDKAutomation/azure-sdk-for-net",
"mainRepository": "Azure/azure-sdk-for-net",
"configFilePath": "eng/swagger_to_sdk_config.json"
},
"azure-sdk-for-python": {
"integrationRepository": "AzureSDKAutomation/azure-sdk-for-python",
"mainRepository": "Azure/azure-sdk-for-python",
Expand Down