[Hub Generated] Review request for Microsoft.KubernetesConfiguration to add version preview/2020-10-01-preview #12195

NarayanThiru · 2020-12-22T01:01:05Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2020-12-22T01:01:08Z

Hi, @NarayanThiru Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2020-12-22T01:01:08Z

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.5)
- original: preview/2020-10-01-preview/kubernetesconfiguration.json <---> new: preview/2020-10-01-preview/kubernetesconfiguration.json

Rule	Message
`❌` 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.KubernetesConfiguration/preview/2020-10-01-preview/kubernetesconfiguration.json#L277:11

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- kubernetesconfiguration/resource-manager/readme.md tag:package-preview-2020-10
Linted configuring files (Based on target branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- kubernetesconfiguration/resource-manager/readme.md tag:package-preview-2020-10

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2020-12-22T01:01:09Z

Swagger Generation Artifacts

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 3e3a9ce. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6351 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/kubernetesconfiguration/resource-manager/readme.md

️✔️kubernetesconfiguration [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 3e3a9ce. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/kubernetesconfiguration/resource-manager/readme.md

️✔️@azure/arm-kubernetesconfiguration [View full logs] [Release SDK Changes]

azure-arm-kubernetesconfiguration-2.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/sourceControlConfigurationClient.js → ./dist/arm-kubernetesconfiguration.js...
cmderr	[npmPack] created ./dist/arm-kubernetesconfiguration.js in 182ms

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 3e3a9ce. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-01-19 02:02:14 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-kubernetesconfiguration"
cmderr	[generate.py] 2021-01-19 02:02:14 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-01-19 02:02:14 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.9 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/kubernetesconfiguration/azure-resourcemanager-kubernetesconfiguration --java.namespace=com.azure.resourcemanager.kubernetesconfiguration   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/kubernetesconfiguration/resource-manager/readme.md
cmderr	[generate.py] 2021-01-19 02:02:58 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-01-19 02:02:58 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-01-19 02:02:58 INFO [POM][Skip] pom already has module azure-resourcemanager-kubernetesconfiguration
cmderr	[generate.py] 2021-01-19 02:02:58 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-01-19 02:02:58 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-01-19 02:02:58 INFO [POM][Success] Write to root pom
cmderr	[generate.py] 2021-01-19 02:03:57 ERROR [COMPILE] Maven build fail

️✔️azure-resourcemanager-kubernetesconfiguration [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-01-19 02:04:59 DEBUG Got artifact_id: azure-resourcemanager-kubernetesconfiguration
cmderr	[Inst] 2021-01-19 02:04:59 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-19 02:04:59 DEBUG Got artifact: azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-01-19 02:04:59 DEBUG Got artifact: azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-01-19 02:04:59 DEBUG Got artifact: azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-19 02:04:59 DEBUG Match jar package: azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-19 02:04:59 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12195/azure-sdk-for-java/azure-resourcemanager-kubernetesconfiguration/azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.1.jar\" -o azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-kubernetesconfiguration -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-kubernetesconfiguration-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 3e3a9ce. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/kubernetesconfiguration/resource-manager/readme.md

️✔️azure-mgmt-kubernetesconfiguration [View full logs] [Release SDK Changes] Breaking Change Detected

cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-kubernetesconfiguration
cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-kubernetesconfiguration
cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.kubernetesconfiguration
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.kubernetesconfiguration
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.kubernetesconfiguration
cmderr	[changelogReport] INFO:__main__:Report written to sdk/kubernetesconfiguration/azure-mgmt-kubernetesconfiguration/code_reports/latest/report.json
cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-kubernetesconfiguration on PyPI
cmderr	[changelogReportLatest] INFO:__main__:Got ['0.1.0', '0.2.0', '1.0.0b1']
cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
cmderr	[changelogReportLatest] INFO:__main__:Installing version 0.2.0 of azure-mgmt-kubernetesconfiguration in a venv
cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.kubernetesconfiguration
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.kubernetesconfiguration
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.kubernetesconfiguration
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/kubernetesconfiguration/azure-mgmt-kubernetesconfiguration/code_reports/0.2.0/report.json
cmdout	[Changelog] Size of delta 29.230% size of original (original: 9172 chars, delta: 2681 chars)
cmdout	[Changelog] **Features**
cmdout	[Changelog]   - Model SourceControlConfiguration has a new parameter system_data
cmdout	[Changelog]   - Model SourceControlConfiguration has a new parameter configuration_protected_settings
cmdout	[Changelog]   - Model SourceControlConfiguration has a new parameter ssh_known_hosts_contents
cmdout	[Changelog]   - Model ResourceProviderOperation has a new parameter is_data_action
cmdout	[Changelog]   - Model Resource has a new parameter system_data
cmdout	[Changelog]   - Model ProxyResource has a new parameter system_data
cmdout	[Changelog] **Breaking changes**
cmdout	[Changelog]   - Model ErrorDefinition has a new signature
warn	Breaking change found in changelog

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 3e3a9ce. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️preview/kubernetesconfiguration/mgmt/2019-11-01-preview/kubernetesconfiguration [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2020-12-22T01:03:46Z

Hi @NarayanThiru, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback.

NarayanThiru · 2021-01-07T00:15:50Z

Since we have GA in <2 months, we will introduce this change as part of the new api-version we will create for GA. In the meantime, we will likely file for an exception for this issue. So, closing this PR.

NarayanThiru · 2021-01-13T00:36:44Z

Reopening the PR, in response to the latest recommendations for 'Window to Fix Broken' for Swagger Correctness issues, and the fact that this preview api-version will still be available until all preview customers move over to GA release, I want to add this fix.

NarayanThiru · 2021-01-13T02:32:08Z

Created Breaking Change Intake Form: https://msazure.visualstudio.com/One/_workitems/edit/9116029

msyyc · 2021-01-18T06:51:35Z

For python, the breaking change is OK

NarayanThiru · 2021-01-18T14:50:52Z

@zhenglaizhang, can you merge this PR?

Fix Swagger Linting issue.

c22daae

openapi-assignment-bot bot assigned zhenglaizhang Dec 22, 2020

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Dec 22, 2020

openapi-pipeline-app bot added the CI-BreakingChange-Python label Dec 22, 2020

openapi-sdkautomation bot mentioned this pull request Dec 22, 2020

[AutoPR azure-resourcemanager-kubernetesconfiguration] [Hub Generated] Review request for Microsoft.KubernetesConfiguration to add version preview/2020-10-01-preview AzureSDKAutomation/azure-sdk-for-java#7043

Closed

NarayanThiru closed this Jan 7, 2021

NarayanThiru reopened this Jan 13, 2021

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 17, 2021

JeffreyRichter approved these changes Jan 17, 2021

View reviewed changes

zhenglaizhang merged commit 3e3a9ce into Azure:master Jan 19, 2021

mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021

Fix Swagger Linting issue. (Azure#12195)

9eccb50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.KubernetesConfiguration to add version preview/2020-10-01-preview #12195

[Hub Generated] Review request for Microsoft.KubernetesConfiguration to add version preview/2020-10-01-preview #12195

NarayanThiru commented Dec 22, 2020 •

edited

Loading

openapi-workflow-bot bot commented Dec 22, 2020

openapi-pipeline-app bot commented Dec 22, 2020 •

edited

Loading

openapi-pipeline-app bot commented Dec 22, 2020 •

edited

Loading

openapi-workflow-bot bot commented Dec 22, 2020

NarayanThiru commented Jan 7, 2021

NarayanThiru commented Jan 13, 2021

NarayanThiru commented Jan 13, 2021

msyyc commented Jan 18, 2021

NarayanThiru commented Jan 18, 2021

[Hub Generated] Review request for Microsoft.KubernetesConfiguration to add version preview/2020-10-01-preview #12195

[Hub Generated] Review request for Microsoft.KubernetesConfiguration to add version preview/2020-10-01-preview #12195

Conversation

NarayanThiru commented Dec 22, 2020 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Dec 22, 2020

openapi-pipeline-app bot commented Dec 22, 2020 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Dec 22, 2020 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Dec 22, 2020

NarayanThiru commented Jan 7, 2021

NarayanThiru commented Jan 13, 2021

NarayanThiru commented Jan 13, 2021

msyyc commented Jan 18, 2021

NarayanThiru commented Jan 18, 2021

NarayanThiru commented Dec 22, 2020 •

edited

Loading

openapi-pipeline-app bot commented Dec 22, 2020 •

edited

Loading

openapi-pipeline-app bot commented Dec 22, 2020 •

edited

Loading