Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added move validation enum values & fix S360 linting issues #12275

Merged
merged 3 commits into from
Jan 12, 2021
Merged

Added move validation enum values & fix S360 linting issues #12275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ccd4d2
Added new move product validation error codes
Jan 4, 2021
a857e07
Added integer formats to fix S360 swagger lint validation
Jan 4, 2021
b22cbd8
Fixed ModelValidation errors for v2018-11-01-preview
Jan 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...cation/billing/resource-manager/Microsoft.Billing/preview/2017-02-27-preview/billing.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@
"in": "query",
"required": false,
"type": "integer",
"format": "int32",
"minimum": 1,
"maximum": 100
},
Expand Down
2 changes: 2 additions & 0 deletions ...cation/billing/resource-manager/Microsoft.Billing/preview/2017-04-24-preview/billing.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
"in": "query",
"required": false,
"type": "integer",
"format": "int32",
"minimum": 1,
"maximum": 100
}
Expand Down Expand Up @@ -194,6 +195,7 @@
"in": "query",
"required": false,
"type": "integer",
"format": "int32",
"minimum": 1,
"maximum": 100
}
Expand Down
2 changes: 2 additions & 0 deletions ...cation/billing/resource-manager/Microsoft.Billing/preview/2018-03-01-preview/billing.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@
"in": "query",
"required": false,
"type": "integer",
"format": "int32",
"minimum": 1,
"maximum": 100
}
Expand Down Expand Up @@ -252,6 +253,7 @@
"in": "query",
"required": false,
"type": "integer",
"format": "int32",
"minimum": 1,
"maximum": 100
}
Expand Down
1 change: 1 addition & 0 deletions ...tion/billing/resource-manager/Microsoft.Billing/preview/2018-03-01-preview/billingV2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@
"in": "query",
"required": false,
"type": "integer",
"format": "int32",
"minimum": 1,
"maximum": 100
}
Expand Down
17 changes: 12 additions & 5 deletions ...cation/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,8 @@
},
"Retry-After": {
"description": "Recommends the retryable time after receiving this.",
"type": "integer"
"type": "integer",
"format": "int32"
},
"Azure-AsyncOperation": {
"description": "URI to poll for the operation status",
Expand Down Expand Up @@ -736,7 +737,8 @@
},
"Retry-After": {
"description": "Recommends the retryable time after receiving this.",
"type": "integer"
"type": "integer",
"format": "int32"
},
"Azure-AsyncOperation": {
"description": "URI to poll for the operation status",
Expand Down Expand Up @@ -1713,7 +1715,8 @@
},
"Retry-After": {
"description": "Recommends the retryable time after receiving this.",
"type": "integer"
"type": "integer",
"format": "int32"
},
"Azure-AsyncOperation": {
"description": "URI to poll for the operation status",
Expand Down Expand Up @@ -1975,7 +1978,8 @@
},
"Retry-After": {
"description": "Recommends the retryable time after receiving this.",
"type": "integer"
"type": "integer",
"format": "int32"
},
"Azure-AsyncOperation": {
"description": "URI to poll for the operation status",
Expand Down Expand Up @@ -3938,7 +3942,8 @@
},
"Retry-After": {
"description": "Recommends the retryable time after receiving this.",
"type": "integer"
"type": "integer",
"format": "int32"
},
"Azure-AsyncOperation": {
"description": "URI to poll for the operation status",
Expand Down Expand Up @@ -4953,6 +4958,7 @@
"invoiceDay": {
"description": "Invoice day.",
"type": "integer",
"format": "int32",
"readOnly": true
},
"currency": {
Expand Down Expand Up @@ -5869,6 +5875,7 @@
"quantity": {
"description": "Purchase quantity.",
"type": "integer",
"format": "int32",
"readOnly": true
},
"customerId": {
Expand Down
2 changes: 1 addition & 1 deletion ...esource-manager/Microsoft.Billing/preview/2018-11-01-preview/examples/AcceptTransfer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"transferName": "transferName",
"body": {
"properties": {
"value": [
"productDetails": [
{
"productType": "AzureSubscription",
"productId": "subscriptionId"
Expand Down
2 changes: 1 addition & 1 deletion ...ource-manager/Microsoft.Billing/preview/2018-11-01-preview/examples/InitiateTransfer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"invoiceSectionName": "invoiceSectionName",
"body": {
"properties": {
"billingProfileName": "billingProfileName",
"billingProfileId": "billingProfileId",
"recipientEmailId": "user@contoso.com"
}
}
Expand Down
38 changes: 28 additions & 10 deletions ...cation/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,8 @@
},
"Retry-After": {
"description": "Recommended time to wait before making another request to check the status of the operation. The time is specified in seconds.",
"type": "integer"
"type": "integer",
"format": "int32"
}
}
},
Expand Down Expand Up @@ -947,7 +948,8 @@
},
"Retry-After": {
"description": "Recommended time to wait before making another request to check the status of the operation. The time is specified in seconds.",
"type": "integer"
"type": "integer",
"format": "int32"
}
}
},
Expand Down Expand Up @@ -2479,7 +2481,8 @@
},
"Retry-After": {
"description": "Recommended time to wait before making another request to check the status of the operation. The time is specified in seconds.",
"type": "integer"
"type": "integer",
"format": "int32"
}
}
},
Expand Down Expand Up @@ -2746,7 +2749,8 @@
},
"Retry-After": {
"description": "Recommended time to wait before making another request to check the status of the operation. The time is specified in seconds.",
"type": "integer"
"type": "integer",
"format": "int32"
}
}
},
Expand Down Expand Up @@ -6214,14 +6218,26 @@
"type": "string",
"description": "Error code of the transfer validation response.",
"enum": [
"BillingAccountInactive",
"CrossBillingAccountNotAllowed",
"DestinationBillingProfileInactive",
"DestinationBillingProfileNotFound",
"DestinationBillingProfilePastDue",
"DestinationInvoiceSectionInactive",
"DestinationInvoiceSectionNotFound",
"InsufficientPermissionOnDestination",
"InsufficientPermissionOnSource",
"InvalidDestination",
"InvalidSource",
"MarketplaceNotEnabledOnDestination",
"NotAvailableForDestinationMarket",
"ProductInactive",
"ProductNotFound",
"ProductTypeNotSupported",
"SourceBillingProfilePastDue",
"SourceInvoiceSectionInactive",
"SubscriptionNotActive",
"InsufficientPermissionOnSource",
"InsufficientPermissionOnDestination",
"DestinationBillingProfilePastDue",
"SubscriptionTypeNotSupported",
"CrossBillingAccountNotAllowed",
"NotAvailableForDestinationMarket"
"SubscriptionTypeNotSupported"
],
"x-ms-enum": {
"name": "subscriptionTransferValidationErrorCode",
Expand Down Expand Up @@ -6866,6 +6882,7 @@
"invoiceDay": {
"description": "The day of the month when the invoice for the billing profile is generated.",
"type": "integer",
"format": "int32",
"readOnly": true
},
"currency": {
Expand Down Expand Up @@ -8057,6 +8074,7 @@
"quantity": {
"description": "The quantity purchased in the transaction.",
"type": "integer",
"format": "int32",
"readOnly": true
},
"invoiceSectionId": {
Expand Down
38 changes: 28 additions & 10 deletions specification/billing/resource-manager/Microsoft.Billing/stable/2020-05-01/billing.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,8 @@
},
"Retry-After": {
"description": "Recommended time to wait before making another request to check the status of the operation. The time is specified in seconds.",
"type": "integer"
"type": "integer",
"format": "int32"
}
}
},
Expand Down Expand Up @@ -800,7 +801,8 @@
},
"Retry-After": {
"description": "Recommended time to wait before making another request to check the status of the operation. The time is specified in seconds.",
"type": "integer"
"type": "integer",
"format": "int32"
}
}
},
Expand Down Expand Up @@ -1905,7 +1907,8 @@
},
"Retry-After": {
"description": "Recommended time to wait before making another request to check the status of the operation. The time is specified in seconds.",
"type": "integer"
"type": "integer",
"format": "int32"
}
}
},
Expand Down Expand Up @@ -2264,7 +2267,8 @@
},
"Retry-After": {
"description": "Recommended time to wait before making another request to check the status of the operation. The time is specified in seconds.",
"type": "integer"
"type": "integer",
"format": "int32"
}
}
},
Expand Down Expand Up @@ -3719,14 +3723,26 @@
"type": "string",
"description": "Error code of the transfer validation response.",
"enum": [
"BillingAccountInactive",
"CrossBillingAccountNotAllowed",
"DestinationBillingProfileInactive",
"DestinationBillingProfileNotFound",
"DestinationBillingProfilePastDue",
"DestinationInvoiceSectionInactive",
"DestinationInvoiceSectionNotFound",
"InsufficientPermissionOnDestination",
"InsufficientPermissionOnSource",
"InvalidDestination",
"InvalidSource",
"MarketplaceNotEnabledOnDestination",
"NotAvailableForDestinationMarket",
"ProductInactive",
"ProductNotFound",
"ProductTypeNotSupported",
"SourceBillingProfilePastDue",
"SourceInvoiceSectionInactive",
"SubscriptionNotActive",
"InsufficientPermissionOnSource",
"InsufficientPermissionOnDestination",
"DestinationBillingProfilePastDue",
"SubscriptionTypeNotSupported",
"CrossBillingAccountNotAllowed",
"NotAvailableForDestinationMarket"
"SubscriptionTypeNotSupported"
],
"x-ms-enum": {
"name": "subscriptionTransferValidationErrorCode",
Expand Down Expand Up @@ -4346,6 +4362,7 @@
"invoiceDay": {
"description": "The day of the month when the invoice for the billing profile is generated.",
"type": "integer",
"format": "int32",
"readOnly": true
},
"currency": {
Expand Down Expand Up @@ -5641,6 +5658,7 @@
"quantity": {
"description": "The quantity purchased in the transaction.",
"type": "integer",
"format": "int32",
"readOnly": true
},
"invoiceSectionId": {
Expand Down