Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S360: Add server security alerts list by server #12302

Merged
merged 8 commits into from
Jan 12, 2021
Merged

S360: Add server security alerts list by server #12302

merged 8 commits into from
Jan 12, 2021

Conversation

ayeletshpigelman
Copy link
Contributor

@ayeletshpigelman ayeletshpigelman commented Jan 6, 2021 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @ayeletshpigelman Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    Swagger pipeline can not start as the pull request has merge conflicts.

    1 similar comment
    @openapi-pipeline-app
    Copy link

    Swagger pipeline can not start as the pull request has merge conflicts.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 6, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 6 Errors, 0 Warnings failed [Detail]

    Rule Message
    ❌ 1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L1415:5
    ❌ 1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.DBforMariaDB/stable/2018-06-01/ServerSecurityAlertPolicies.json#L139:5
    ❌ 1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.DBforMySQL/preview/2017-12-01-preview/mysql.json#L1725:5
    ❌ 1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.DBforMySQL/stable/2017-12-01/ServerSecurityAlertPolicies.json#L139:5
    ❌ 1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.DBforPostgreSQL/preview/2017-12-01-preview/postgresql.json#L1728:5
    ❌ 1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.DBforPostgreSQL/stable/2017-12-01/ServerSecurityAlertPolicies.json#L139:5
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.

    ️⚠️Avocado: 3 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/mariadb/resource-manager/readme.md
    tag: specification/mariadb/resource-manager/readme.md#tag-package-2020-01-01
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/mysql/resource-manager/readme.md
    tag: specification/mysql/resource-manager/readme.md#tag-package-2020-01-01
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/postgresql/resource-manager/readme.md
    tag: specification/postgresql/resource-manager/readme.md#tag-package-2020-01-01
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 6, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 03d81a5. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/mariadb/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/mysql/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/postgresql/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.MariaDB [View full logs]  [Release SDK Changes] 
      warn	Skip artifact folder because it doesn't exist: artifacts/packages
    • ️✔️Microsoft.Azure.Management.MySQL [View full logs]  [Release SDK Changes]
    • ️✔️Microsoft.Azure.Management.PostgreSQL [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 03d81a5. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/mariadb/resource-manager/readme.md
command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/mysql/resource-manager/readme.md
command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/postgresql/resource-manager/readme.md
    • ️✔️azure-mgmt-rdbms [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.rdbms.mysql.v2020_07_01_privatepreview
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.rdbms.mysql.v2020_07_01_privatepreview
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.rdbms.postgresql
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.rdbms.postgresql.aio
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.rdbms.postgresql.v2020_01_01
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.rdbms.postgresql.v2020_01_01
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.rdbms.postgresql.v2020_02_14_preview
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.rdbms.postgresql.v2020_02_14_preview
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.rdbms.mariadb
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/rdbms/azure-mgmt-rdbms/code_reports/7.0.0b1/mariadb.json
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.rdbms.mysql.v2020_01_01
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/rdbms/azure-mgmt-rdbms/code_reports/7.0.0b1/mysql.v2020_01_01.json
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.rdbms.mysql.v2020_07_01_privatepreview
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/rdbms/azure-mgmt-rdbms/code_reports/7.0.0b1/mysql.v2020_07_01_privatepreview.json
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.rdbms.postgresql.v2020_01_01
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/rdbms/azure-mgmt-rdbms/code_reports/7.0.0b1/postgresql.v2020_01_01.json
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.rdbms.postgresql.v2020_02_14_preview
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/rdbms/azure-mgmt-rdbms/code_reports/7.0.0b1/postgresql.v2020_02_14_preview.json
cmderr	[changelogReportLatest] INFO:__main__:Merged report written to sdk/rdbms/azure-mgmt-rdbms/code_reports/7.0.0b1/merged_report.json
cmdout	[Changelog] Size of delta 45.671% size of original (original: 73975 chars, delta: 33785 chars)
cmdout	[Changelog] **Features**
cmdout	[Changelog]   - Model Server has a new parameter server_tags
cmdout	[Changelog]   - Model LogFile has a new parameter log_file_type
cmdout	[Changelog]   - Added operation VirtualNetworkRulesOperations.create_or_update
cmdout	[Changelog]   - Added operation VirtualNetworkRulesOperations.delete
cmdout	[Changelog]   - Added operation FirewallRulesOperations.create_or_update
cmdout	[Changelog]   - Added operation FirewallRulesOperations.delete
cmdout	[Changelog]   - Added operation ServerKeysOperations.create_or_update
cmdout	[Changelog]   - Added operation ServerKeysOperations.delete
cmdout	[Changelog]   - Added operation ConfigurationsOperations.update
cmdout	[Changelog]   - Added operation PrivateEndpointConnectionsOperations.update_tags
cmdout	[Changelog]   - Added operation PrivateEndpointConnectionsOperations.create_or_update
cmdout	[Changelog]   - Added operation PrivateEndpointConnectionsOperations.delete
cmdout	[Changelog]   - Added operation ServerSecurityAlertPoliciesOperations.create_or_update
cmdout	[Changelog]   - Added operation ServerSecurityAlertPoliciesOperations.list_by_server
cmdout	[Changelog]   - Added operation MariaDBManagementClientOperationsMixin.create_recommended_action_session
cmdout	[Changelog]   - Added operation MariaDBManagementClientOperationsMixin.reset_query_performance_insight_data
cmdout	[Changelog]   - Added operation ServerAdministratorsOperations.create_or_update
cmdout	[Changelog]   - Added operation ServerAdministratorsOperations.delete
cmdout	[Changelog]   - Added operation ServersOperations.stop
cmdout	[Changelog]   - Added operation ServersOperations.restart
cmdout	[Changelog]   - Added operation ServersOperations.create
cmdout	[Changelog]   - Added operation ServersOperations.start
cmdout	[Changelog]   - Added operation ServersOperations.update
cmdout	[Changelog]   - Added operation ServersOperations.delete
cmdout	[Changelog]   - Added operation MySQLManagementClientOperationsMixin.create_recommended_action_session
cmdout	[Changelog]   - Added operation MySQLManagementClientOperationsMixin.reset_query_performance_insight_data
cmdout	[Changelog]   - Added operation DatabasesOperations.create
cmdout	[Changelog]   - Added operation DatabasesOperations.delete
cmdout	[Changelog]   - Added operation group ServerBasedPerformanceTierOperations
cmdout	[Changelog]   - Added operation group RecoverableServersOperations
cmdout	[Changelog]   - Added operation group ServerParametersOperations
cmdout	[Changelog] **Breaking changes**
cmdout	[Changelog]   - Parameter virtual_network_subnet_id of model VirtualNetworkRule is now required
cmdout	[Changelog]   - Parameter server_key_type of model ServerKey is now required
cmdout	[Changelog]   - Parameter administrator_type of model ServerAdministratorResource is now required
cmdout	[Changelog]   - Parameter tenant_id of model ServerAdministratorResource is now required
cmdout	[Changelog]   - Parameter sid of model ServerAdministratorResource is now required
cmdout	[Changelog]   - Parameter login of model ServerAdministratorResource is now required
cmdout	[Changelog]   - Parameter state of model ServerSecurityAlertPolicy is now required
cmdout	[Changelog]   - Operation WaitStatisticsOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation WaitStatisticsOperations.get has a new signature
cmdout	[Changelog]   - Operation VirtualNetworkRulesOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation VirtualNetworkRulesOperations.get has a new signature
cmdout	[Changelog]   - Operation TopQueryStatisticsOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation TopQueryStatisticsOperations.get has a new signature
cmdout	[Changelog]   - Operation ServerKeysOperations.list has a new signature
cmdout	[Changelog]   - Operation ServerKeysOperations.get has a new signature
cmdout	[Changelog]   - Operation ReplicasOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation RecommendedActionsOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation RecommendedActionsOperations.get has a new signature
cmdout	[Changelog]   - Operation QueryTextsOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation QueryTextsOperations.get has a new signature
cmdout	[Changelog]   - Operation PrivateLinkResourcesOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation PrivateLinkResourcesOperations.get has a new signature
cmdout	[Changelog]   - Operation PrivateEndpointConnectionsOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation PrivateEndpointConnectionsOperations.get has a new signature
cmdout	[Changelog]   - Operation LogFilesOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation LocationBasedRecommendedActionSessionsResultOperations.list has a new signature
cmdout	[Changelog]   - Operation LocationBasedRecommendedActionSessionsOperationStatusOperations.get has a new signature
cmdout	[Changelog]   - Operation LocationBasedPerformanceTierOperations.list has a new signature
cmdout	[Changelog]   - Operation LocationBasedCapabilitiesOperations.execute has a new signature
cmdout	[Changelog]   - Operation FirewallRulesOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation FirewallRulesOperations.get has a new signature
cmdout	[Changelog]   - Operation ConfigurationsOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation ConfigurationsOperations.get has a new signature
cmdout	[Changelog]   - Operation AdvisorsOperations.list_by_server has a new signature
cmdout	[Changelog]   - Operation AdvisorsOperations.get has a new signature
cmdout	[Changelog]   - Model ConfigurationListResult no longer has parameter next_link
cmdout	[Changelog]   - Model Server no longer has parameter tags_properties_tags
cmdout	[Changelog]   - Model LogFile no longer has parameter type_properties_type
cmdout	[Changelog]   - Operation CheckNameAvailabilityOperations.execute has a new signature
cmdout	[Changelog]   - Operation Operations.list has a new signature
cmdout	[Changelog]   - Operation VirtualNetworkSubnetUsageOperations.execute has a new signature
cmdout	[Changelog]   - Operation CheckVirtualNetworkSubnetUsageOperations.execute has a new signature
cmdout	[Changelog]   - Model PerformanceTierProperties has a new signature
cmdout	[Changelog]   - Removed operation VirtualNetworkRulesOperations.begin_delete
cmdout	[Changelog]   - Removed operation VirtualNetworkRulesOperations.begin_create_or_update
cmdout	[Changelog]   - Removed operation FirewallRulesOperations.begin_delete
cmdout	[Changelog]   - Removed operation FirewallRulesOperations.begin_create_or_update
cmdout	[Changelog]   - Removed operation ServerKeysOperations.begin_delete
cmdout	[Changelog]   - Removed operation ServerKeysOperations.begin_create_or_update
cmdout	[Changelog]   - Removed operation ConfigurationsOperations.begin_update
cmdout	[Changelog]   - Removed operation PrivateEndpointConnectionsOperations.begin_delete
cmdout	[Changelog]   - Removed operation PrivateEndpointConnectionsOperations.begin_update_tags
cmdout	[Changelog]   - Removed operation PrivateEndpointConnectionsOperations.begin_create_or_update
cmdout	[Changelog]   - Removed operation ServerSecurityAlertPoliciesOperations.begin_create_or_update
cmdout	[Changelog]   - Removed operation MariaDBManagementClientOperationsMixin.begin_create_recommended_action_session
cmdout	[Changelog]   - Removed operation ServerAdministratorsOperations.begin_delete
cmdout	[Changelog]   - Removed operation ServerAdministratorsOperations.begin_create_or_update
cmdout	[Changelog]   - Removed operation ServersOperations.begin_restart
cmdout	[Changelog]   - Removed operation ServersOperations.begin_update
cmdout	[Changelog]   - Removed operation ServersOperations.begin_create
cmdout	[Changelog]   - Removed operation ServersOperations.begin_start
cmdout	[Changelog]   - Removed operation ServersOperations.begin_delete
cmdout	[Changelog]   - Removed operation ServersOperations.begin_stop
cmdout	[Changelog]   - Removed operation MySQLManagementClientOperationsMixin.begin_create_recommended_action_session
cmdout	[Changelog]   - Removed operation DatabasesOperations.begin_delete
cmdout	[Changelog]   - Removed operation DatabasesOperations.begin_create_or_update
warn	Breaking change found in changelog
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 03d81a5. Schema Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/mariadb/resource-manager/readme.md
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/mysql/resource-manager/readme.md
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/postgresql/resource-manager/readme.md
    • ️✔️mariadb [View full logs]  [Release Schema Changes] 
      cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
cmderr	[resource-manager]  WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
cmderr	[resource-manager]  WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager]  optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 03d81a5. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-01-12 09:42:06 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-mariadb"
cmderr	[generate.py] 2021-01-12 09:42:06 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-01-12 09:42:06 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.8 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/mariadb/azure-resourcemanager-mariadb --java.namespace=com.azure.resourcemanager.mariadb  --package-version=1.0.0-beta.1 --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/mariadb/resource-manager/readme.md
cmderr	[generate.py] 2021-01-12 09:42:53 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-01-12 09:42:53 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-01-12 09:42:53 INFO [POM][Skip] pom already has module azure-resourcemanager-mariadb
cmderr	[generate.py] 2021-01-12 09:42:53 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-01-12 09:42:53 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-01-12 09:42:53 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
    • ️✔️azure-resourcemanager-mariadb [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-01-12 09:45:27 DEBUG Got artifact_id: azure-resourcemanager-mariadb
cmderr	[Inst] 2021-01-12 09:45:27 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-12 09:45:27 DEBUG Got artifact: azure-resourcemanager-mariadb-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-12 09:45:27 DEBUG Match jar package: azure-resourcemanager-mariadb-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-12 09:45:27 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12302/azure-sdk-for-java/azure-resourcemanager-mariadb/azure-resourcemanager-mariadb-1.0.0-beta.1.jar\" -o azure-resourcemanager-mariadb-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-mariadb -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-mariadb-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    • ️✔️azure-resourcemanager-mysql [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-01-12 09:47:44 DEBUG Got artifact_id: azure-resourcemanager-mysql
cmderr	[Inst] 2021-01-12 09:47:44 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-12 09:47:44 DEBUG Got artifact: azure-resourcemanager-mysql-1.0.0-beta.2-sources.jar
cmderr	[Inst] 2021-01-12 09:47:44 DEBUG Got artifact: azure-resourcemanager-mysql-1.0.0-beta.2.jar
cmderr	[Inst] 2021-01-12 09:47:44 DEBUG Match jar package: azure-resourcemanager-mysql-1.0.0-beta.2.jar
cmderr	[Inst] 2021-01-12 09:47:44 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12302/azure-sdk-for-java/azure-resourcemanager-mysql/azure-resourcemanager-mysql-1.0.0-beta.2.jar\" -o azure-resourcemanager-mysql-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-mysql -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-mysql-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
```"}
    • ️✔️azure-resourcemanager-postgresql [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-01-12 09:49:51 DEBUG Got artifact_id: azure-resourcemanager-postgresql
cmderr	[Inst] 2021-01-12 09:49:51 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-12 09:49:51 DEBUG Got artifact: azure-resourcemanager-postgresql-1.0.0-beta.2-javadoc.jar
cmderr	[Inst] 2021-01-12 09:49:51 DEBUG Got artifact: azure-resourcemanager-postgresql-1.0.0-beta.2-sources.jar
cmderr	[Inst] 2021-01-12 09:49:51 DEBUG Got artifact: azure-resourcemanager-postgresql-1.0.0-beta.2.jar
cmderr	[Inst] 2021-01-12 09:49:51 DEBUG Match jar package: azure-resourcemanager-postgresql-1.0.0-beta.2.jar
cmderr	[Inst] 2021-01-12 09:49:51 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12302/azure-sdk-for-java/azure-resourcemanager-postgresql/azure-resourcemanager-postgresql-1.0.0-beta.2.jar\" -o azure-resourcemanager-postgresql-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-postgresql -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-postgresql-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 03d81a5. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️preview/postgresql/mgmt/2020-11-05-preview/postgresqlflexibleservers [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/mysql/mgmt/2020-07-01-preview/mysqlflexibleservers [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/postgresql/mgmt/2020-02-14-preview/postgresqlflexibleservers [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️mariadb/mgmt/2020-01-01/mariadb [View full logs]  [Release SDK Changes]
      Only show 11 items here, please refer to log for details.
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 66 additive change(s).
info	[Changelog]
    • ️✔️mysql/mgmt/2020-01-01/mysql [View full logs]  [Release SDK Changes]
      Only show 11 items here, please refer to log for details.
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 66 additive change(s).
info	[Changelog]
    • ️✔️postgresql/mgmt/2020-01-01/postgresql [View full logs]  [Release SDK Changes]
      Only show 11 items here, please refer to log for details.
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 57 additive change(s).
info	[Changelog]
    • ️✔️mariadb/mgmt/2018-06-01/mariadb [View full logs]  [Release SDK Changes]
      Only show 11 items here, please refer to log for details.
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 66 additive change(s).
info	[Changelog]
    • ️✔️preview/mysql/mgmt/2017-12-01-preview/mysql [View full logs]  [Release SDK Changes]
      Only show 11 items here, please refer to log for details.
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 57 additive change(s).
info	[Changelog]
    • ️✔️preview/postgresql/mgmt/2017-12-01-preview/postgresql [View full logs]  [Release SDK Changes]
      Only show 11 items here, please refer to log for details.
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 57 additive change(s).
info	[Changelog]
    • ️✔️mysql/mgmt/2017-12-01/mysql [View full logs]  [Release SDK Changes]
      Only show 11 items here, please refer to log for details.
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 57 additive change(s).
info	[Changelog]
    • ️✔️postgresql/mgmt/2017-12-01/postgresql [View full logs]  [Release SDK Changes]
      Only show 11 items here, please refer to log for details.
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 57 additive change(s).
info	[Changelog]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 03d81a5. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/mariadb/resource-manager/readme.md
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/mysql/resource-manager/readme.md
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/postgresql/resource-manager/readme.md
    • ️✔️@azure/arm-mariadb [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/mariaDBManagementClient.js → ./dist/arm-mariadb.js...
cmderr	[npmPack] created ./dist/arm-mariadb.js in 672ms
    • ️✔️@azure/arm-mysql [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/mySQLManagementClient.js → ./dist/arm-mysql.js...
cmderr	[npmPack] created ./dist/arm-mysql.js in 718ms
    • ️✔️@azure/arm-postgresql [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/postgreSQLManagementClient.js → ./dist/arm-postgresql.js...
cmderr	[npmPack] created ./dist/arm-postgresql.js in 596ms
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @ayeletshpigelman, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
     If you need further help, please feedback via swagger feedback."

    @openapi-workflow-bot
    Copy link

    Hi @ayeletshpigelman, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    This was referenced Jan 6, 2021
    Closed
    Closed
    Closed
    Closed
    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jan 6, 2021
    Closed
    @jorgecotillo jorgecotillo added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 11, 2021
    @ArcturusZhang ArcturusZhang changed the title Add server security alerts list by server S360: Add server security alerts list by server Jan 12, 2021
    @PhoenixHe-NV
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 2 pipeline(s).

    @ArcturusZhang ArcturusZhang merged commit 03d81a5 into Azure:master Jan 12, 2021
    This was referenced Jan 12, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Merged
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Jan 14, 2021
    [ReleasePR mariadb] S360: Add server security alerts list by server (#…
    1f758a5 
    …1401)

Create to sync Azure/azure-rest-api-specs#12302
[ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/master...AzureSDKAutomation:sdkAuto/mariadb?expand=1)
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @JeffreyRichter JeffreyRichter JeffreyRichter approved these changes

    @QingqingYuan2 QingqingYuan2 Awaiting requested review from QingqingYuan2

    Assignees

    @ArcturusZhang ArcturusZhang

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-Python
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @ayeletshpigelman @ArcturusZhang @majastrz @jorgecotillo @PhoenixHe-NV @JeffreyRichter